Re: [DISCUSS] BP-51: BookKeeper client memory limits

2022-09-28 Thread Michael Marshall
I support adding back pressure based on client memory limits to the bookkeeper client. My biggest concern is how the back pressure is propagated to the client application. If I am reading the draft implementation correctly, it is via a blocking operation on the calling thread for the `BookieClient

Re: [VOTE] Release 4.15.2, release candidate #0

2022-09-28 Thread Nicolò Boschi
+1 - non binding - checksum and signatures - built sources on Mac, jdk11 - verified localbookie and shell - upgraded BK on Apache Pulsar (2.11 snapshot) and verified several scenario in K8S installation Thanks!! BR, Nicolò Boschi Il giorno mar 27 set 2022 alle ore 17:41 Enrico Olivelli < eoliv

Re: [DISCUSS] BP-51: BookKeeper client memory limits

2022-09-28 Thread Enrico Olivelli
Yong, Il giorno mer 28 set 2022 alle ore 10:23 Yong Zhang ha scritto: > > We have improved the memory issue with backpressure with PR > https://github.com/apache/bookkeeper/pull/3324 > > The backpressure way can prevent there have too many Add requests > pending to the client and waiting for the

Re: [DISCUSS] BP-51: BookKeeper client memory limits

2022-09-28 Thread Yong Zhang
We have improved the memory issue with backpressure with PR https://github.com/apache/bookkeeper/pull/3324 The backpressure way can prevent there have too many Add requests pending to the client and waiting for the response. It makes the add requests fail fast, so if the channel is not writable, i