Steven, the story is: - I noticed we don't have integration test for later releases and added the tests - I noticed that integration tests do not run at all (not discovered) - I fixed that and the tests attempted to run but failed
The problem appears to be around the Arquillian test runner and I am not familiar with it / it seems to be obsolete (?). If anyone here is familiar with Arquillian and can easily fix the tests it would be amazing. I didn't have time to investigate much deeper. Internally we talked about it with the team and the consensus was that it makes sense to rewrite the tests to testcontainers (as it is used in other integration tests, including Pulsar's) but given the schedule/priorities we can't fix it right now. On Wed, Jul 5, 2023 at 2:28 AM steven lu <lushiji2...@gmail.com> wrote: > +1 (non-binding) > but workflow run failed, this pr cannot be merged, please see below for > details > https://github.com/apache/bookkeeper/pull/3981#issuecomment-1617613606 > > Andrey Yegorov <ayego...@apache.org> 于2023年6月7日周三 06:38写道： > > > Hi, > > > > We have a few problems related to integration tests: > > > > 1. backwards compat tests did not include recent releases. > > https://github.com/apache/bookkeeper/pull/3981 is supposed to fix that > > > > 2. Integration/backwards compat tests do not run on CI > > E.g.: > > > > > > mvn -B -nsu -DintegrationTests -pl :upgrade test > > .. > > [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0 > > > > > > and the same is with other tests in the integration test suites. CI does > > not fail in this case. > > > > This means that we didn't have backwards compat tests executed during the > > last releases. > > > > For the context, I started on this path as a follow up to a report of > > problems during BK/pulsar upgrade > > > https://urldefense.com/v3/__https://apache-pulsar.slack.com/archives/C5ZSVEN4E/p1686019408280939__;!!PbtH5S7Ebw!cu0XwMngGAbPD4B-um2NYpkWL8ChQCqk79kBiCxkc7uNnEfokjLxK4V6H-UtyZvyJLE-zNpSHkOOtOrgSh8PqNYDA4c$ > > > > Adding > > ``` > > <dependency> > > <groupId>org.junit.vintage</groupId> > > <artifactId>junit-vintage-engine</artifactId> > > <version>${junit5.version}</version> > > <scope>test</scope> > > </dependency> > > ``` > > to the backwards compat modules makes mvn find the test but there are > > missing dependencies and/or some conflicts in the runtime that I haven't > > figured out. > > > > I'd appreciate help from someone who understands what the heck Arquillian > > test runner (used in groovy tests) needs. > > > > -- > > Andrey > > > -- Andrey Yegorov
