[GitHub] bookkeeper issue #193: BOOKKEEPER-1098: ZkUnderreplicationManager cache watc...

2017-06-28 Thread athanatos
Github user athanatos commented on the issue: https://github.com/apache/bookkeeper/pull/193 @sijie Oops, I just noticed the comments. I guess you just changed the title? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] bookkeeper pull request #193: BOOKKEEPER-1086: ZkUnderreplicationManager cac...

2017-06-15 Thread athanatos
GitHub user athanatos opened a pull request: https://github.com/apache/bookkeeper/pull/193 BOOKKEEPER-1086: ZkUnderreplicationManager cache watcher Previously, getLedgerToReplicate left watches each time it traversed the tree until it found a suitable replication target. Since

[GitHub] bookkeeper issue #80: BOOKKEEPER-816: use native fallocate & sync_file_range...

2017-04-13 Thread athanatos
Github user athanatos commented on the issue: https://github.com/apache/bookkeeper/pull/80 @sijie @eolivelli If I'm reading this right, you are trying to use sync_file_range to avoid calling FileChannel.force, which presumably calls fsync. You actually can't use sync_file_range

[GitHub] bookkeeper issue #130: BOOKKEEPER-1031: close the ledger handle in Replicati...

2017-04-11 Thread athanatos
Github user athanatos commented on the issue: https://github.com/apache/bookkeeper/pull/130 Cool, what's the next step? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] bookkeeper issue #130: BOOKKEEPER-1031: close the ledger handle in Replicati...

2017-04-10 Thread athanatos
Github user athanatos commented on the issue: https://github.com/apache/bookkeeper/pull/130 Build's failing due to Tests in error: BookieRecoveryTest.ensurePasswordUsedForOldLedgers[4] » BKNoSuchLedgerExists BookieRecoveryTest.ensurePasswordUsedForOldLedgers[5] Â

[GitHub] bookkeeper pull request #130: BOOKKEEPER-1031: close the ledger handle in Re...

2017-04-10 Thread athanatos
GitHub user athanatos opened a pull request: https://github.com/apache/bookkeeper/pull/130 BOOKKEEPER-1031: close the ledger handle in ReplicationWorker.rerepli… …cate Otherwise, we build up an unbounded set of Listeners in the AbstractZkLedgerManager listenerSet