Re: [DISCUSS] Introducing Typo CI Check to Apache BookKeeper

2024-05-26 Thread Enrico Olivelli
+1 Enrico Il giorno dom 26 mag 2024 alle ore 01:53 Hang Chen ha scritto: > +1 > > We need to keep an eye on the public methods and configurations. > > Best, > Hang > > Andrey Yegorov 于2024年5月22日周三 02:15写道: > > > > > > Awesome idea, thank you for tackling this. > > > > We need to keep an eye

Re: [DISCUSS] Introducing Typo CI Check to Apache BookKeeper

2024-05-25 Thread Hang Chen
+1 We need to keep an eye on the public methods and configurations. Best, Hang Andrey Yegorov 于2024年5月22日周三 02:15写道: > > > Awesome idea, thank you for tackling this. > > We need to keep an eye on changes in config parameter names in yaml/configs > to avoid unexpected breaks. > So far I

Re: [DISCUSS] Introducing Typo CI Check to Apache BookKeeper

2024-05-21 Thread Andrey Yegorov
Awesome idea, thank you for tackling this. We need to keep an eye on changes in config parameter names in yaml/configs to avoid unexpected breaks. So far I haven't noticed any, but it is an easy miss in a big PR. On 2024/05/19 07:20:30 ZhangJian He wrote: > Hi, I want to introduce new lint

[DISCUSS] Introducing Typo CI Check to Apache BookKeeper

2024-05-19 Thread ZhangJian He
Hi, I want to introduce new lint tools: typos[1]. This tool is designed to automatically detect and correct typographical errors in our codebase, documentation, and comments. It’s a valuable addition to ensure high-quality contributions and maintain the professional standard of our project. It