Github user jiazhai commented on the issue:
https://github.com/apache/bookkeeper/pull/217
The change looks good, Please open an issue or a Jira ticket for this PR,
and at the end of this PR description, For the checks that you have done,
please place "x" in the "[ ]".
---
If your p
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/217
I am okay with using a checkstyle plugin. it shouldn't be a big deal with
existing pull requests.
I am fine with merging this change and having a separate follow up jira to
enable checksty
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/217
@sigee I will be happy to have the checkstyle plugin on but we should
discuss on the d...@bookeeper.apache.org list about the rules to set up, maybe
you can start a new thread
---
If your pr
Github user sigee commented on the issue:
https://github.com/apache/bookkeeper/pull/217
@eolivelli,
If it is fine for you I can keep this PR up to date after every merge you
make (and break this one).
So you can merge it when you want. ;)
I can add maven checkstyle plu
Github user eolivelli commented on the issue:
https://github.com/apache/bookkeeper/pull/217
Thank you @sigee interesting proposal.
@sijie I think this patch could break some pending Pull Request
in general I am OK with this kind of patch but I think it would be better
