sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper
URL: https://github.com/apache/bookkeeper/pull/183#issuecomment-319502198
merging this (will resolve the conflicts manually)
This is an automated
sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper
URL: https://github.com/apache/bookkeeper/pull/183#issuecomment-319277666
+1
@kishorekasi it seems that the latest push isn't compilable. can you fix
that? we are ready to merge this one.
sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper
URL: https://github.com/apache/bookkeeper/pull/183#issuecomment-318223491
@kishorekasi travis and jenkins failed to compile this pull request. I think
a ';' is missing in ClientConfiguration. Can you take a look at
sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper
URL: https://github.com/apache/bookkeeper/pull/183#issuecomment-317592597
@kishorekasi @eolivelli what is the plan for this? Are we including this in
4.5.0?
sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper
URL: https://github.com/apache/bookkeeper/pull/183#issuecomment-317159345
@kishorekasi do you have time to review the comments? It would be great if
we can attempt to close this one
sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper
URL: https://github.com/apache/bookkeeper/pull/183#issuecomment-311802299
fyi, I added @merlimat and me to the reviewers list, making sure we have
other eyes on reviewing this change.
sijie commented on issue #183: BOOKKEEPER-588 SSL Support for Bookkeeper
URL: https://github.com/apache/bookkeeper/pull/183#issuecomment-311799940
@eolivelli I will try to go through this again.
/cc @merlimat for reviewing as well
