[GitHub] sijie commented on issue #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint

2017-08-14 Thread git
sijie commented on issue #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint URL: https://github.com/apache/bookkeeper/pull/278#issuecomment-322264799 @eolivelli @dcastor just to check if we are good to go with this pull request.

[GitHub] sijie commented on issue #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint

2017-08-01 Thread git
sijie commented on issue #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint URL: https://github.com/apache/bookkeeper/pull/278#issuecomment-319279024 @eolivelli the http port can be turned off by default. I don't see a strong point to include security at this point. we can

[GitHub] sijie commented on issue #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint

2017-07-28 Thread git
sijie commented on issue #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint URL: https://github.com/apache/bookkeeper/pull/278#issuecomment-318740951 @eolivelli : @yzang already addressed your comments, can you review it again? @dcastor : can you review @yzang 's

[GitHub] sijie commented on issue #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint

2017-07-25 Thread git
sijie commented on issue #278: BOOKKEEPER-1100: Add module for Bookkeeper Http Endpoint URL: https://github.com/apache/bookkeeper/pull/278#issuecomment-317789926 >> "I wonder if we really need to implement so many variants of the http server or simply implement one" different