Re: [VOTE] Release 4.13.0, release candidate #0

2021-02-24 Thread Henry Saputra
Thanks for driving the release, Andrey On Wed, Feb 24, 2021 at 9:46 AM Andrey Yegorov wrote: > I checked with Enrico, the release is good to go. > > On Wed, Feb 24, 2021 at 08:53 Andrey Yegorov > wrote: > > > > > So far we have three +1 votes and one note from Flavio regarding the > > copyright

Re: [VOTE] Release 4.13.0, release candidate #0

2021-02-24 Thread Andrey Yegorov
I checked with Enrico, the release is good to go. On Wed, Feb 24, 2021 at 08:53 Andrey Yegorov wrote: > > So far we have three +1 votes and one note from Flavio regarding the > copyright year in the NOTICE file. > Given that copyright fix https://github.com/apache/bookkeeper/pull/2621 > is merge

Re: [VOTE] Release 4.13.0, release candidate #0

2021-02-24 Thread Andrey Yegorov
So far we have three +1 votes and one note from Flavio regarding the copyright year in the NOTICE file. Given that copyright fix https://github.com/apache/bookkeeper/pull/2621 is merged and scheduled for 4.13.1 I'd like to proceed with the release. -- Andrey Yegorov On Tue, Feb 23, 2021

Re: Clean build and NOTICE (was: Re: [VOTE] Release 4.13.0, release candidate #0)

2021-02-24 Thread Flavio Junqueira
I ran another build overnight and this time it finished successfully. It does look like there are a few flaky tests. As for whether the NOTICE file issue is a blocker, the ASF documentation is not very clear about the year in the copyright: https://infra.apache.org/licensing-howto.html b

Re: Clean build and NOTICE (was: Re: [VOTE] Release 4.13.0, release candidate #0)

2021-02-24 Thread Henry Saputra
Hmm I did not see those errors Oh, and I have sent PR for the NOTICE file here: https://github.com/apache/bookkeeper/pull/2621 Wonder if they happen due to "flaky" tests - Henry On Tue, Feb 23, 2021 at 2:15 PM Flavio Junqueira wrote: > A couple of things: > > 1- I haven't been able to get a c

Re: Clean build and NOTICE (was: Re: [VOTE] Release 4.13.0, release candidate #0)

2021-02-24 Thread Enrico Olivelli
Flavio, Il giorno mar 23 feb 2021 alle ore 23:15 Flavio Junqueira ha scritto: > A couple of things: > > 1- I haven't been able to get a clean build, I'll list the tests failures > I observed below. > Can you share info about your env ? I saw those tests fail something in CI or in some machine.

Re: [VOTE] Release 4.13.0, release candidate #0

2021-02-23 Thread Enrico Olivelli
Jia, The KEYS file is at another location, please check the initial message from this thread I imported Andrey's key correctly Enrico Il Mer 24 Feb 2021, 02:34 Jia Zhai ha scritto: > +1(binding) > Environment: macOS 10.15.6, jdk 8. > > - verified packages checksum and signatures, they look goo

Re: [VOTE] Release 4.13.0, release candidate #0

2021-02-23 Thread Jia Zhai
+1(binding) Environment: macOS 10.15.6, jdk 8. - verified packages checksum and signatures, they look good. - the source package build and test all run successfully. - in both binary package(server & all) and the target that build from src package, after change standalone.conf of allowloopback=t

Clean build and NOTICE (was: Re: [VOTE] Release 4.13.0, release candidate #0)

2021-02-23 Thread Flavio Junqueira
A couple of things: 1- I haven't been able to get a clean build, I'll list the tests failures I observed below. 2- We need to update the year range in the NOTICE file to say 2021 instead of 2020. -Flavio [ERROR] org.apache.bookkeeper.client.SlowBookieTest.testSlowBookieAndFastFailOn Time el

Re: [VOTE] Release 4.13.0, release candidate #0

2021-02-23 Thread Henry Saputra
+1 (binding) LICENSE file looks good NOTICE file looks good Signature file looks good Checksum file matched No binary in the source artifact distribution RAT, Checkstyle passed Source compiled and tests passed (OSX, Java 1.8) On Thu, Feb 18, 2021 at 9:48 AM Andrey Yegorov wrote: > Hi everyone, >

Re: [VOTE] Release 4.13.0, release candidate #0

2021-02-22 Thread Enrico Olivelli
I forgot to add that I tested also the RC binaries against HerdDB, everything worked like a charm Enrico Il giorno lun 22 feb 2021 alle ore 14:52 Enrico Olivelli < eolive...@gmail.com> ha scritto: > +1 (binding) > - Verified RAT,Spotbugs,Checkstyle... > - Verified signatures and digests > - Buil

Re: [VOTE] Release 4.13.0, release candidate #0

2021-02-22 Thread Enrico Olivelli
+1 (binding) - Verified RAT,Spotbugs,Checkstyle... - Verified signatures and digests - Built and Run tests on Ubuntu+JDK8 (no integration tests). I created a few issues about flaky tests on DLog (the build passed because we have auto retrial on failures) - Run smoke tests on JDK8 with localbookie a

[VOTE] Release 4.13.0, release candidate #0

2021-02-18 Thread Andrey Yegorov
Hi everyone, Please review and vote on the release candidate #0 for the version 4.13.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * Release notes [1] https:/