Re: [Vote] Apache BookKeeper Release 4.6.0, release candidate #2, without -all package

2017-12-22 Thread Jia Zhai
Thanks everyone for your help on the voting. will close this vote and send out a vote result for this. On Fri, Dec 22, 2017 at 2:48 AM, David Rusek wrote: > +1 (binding) > > verified signatures, build, and standalone, > > -Dave > > On Wed, Dec 20, 2017 at 4:37 AM, Ivan Kelly wrote: > > > +1 (bi

Re: [Vote] Apache BookKeeper Release 4.6.0, release candidate #2, without -all package

2017-12-21 Thread David Rusek
+1 (binding) verified signatures, build, and standalone, -Dave On Wed, Dec 20, 2017 at 4:37 AM, Ivan Kelly wrote: > +1 (binding) > > 1) Notices and licenses look good to me (some minor issues, but not > enough to hold up release) > 2) md5, sha1, sig look good > 3) findbugs, rat and tests pass

Re: [Vote] Apache BookKeeper Release 4.6.0, release candidate #2, without -all package

2017-12-20 Thread Ivan Kelly
+1 (binding) 1) Notices and licenses look good to me (some minor issues, but not enough to hold up release) 2) md5, sha1, sig look good 3) findbugs, rat and tests pass 4) Jepsen test passes (exercise both client and bin package) Env: Debian 9 Good work Jia! -Ivan On Tue, Dec 19, 2017 at 8:13 AM

Re: [Vote] Apache BookKeeper Release 4.6.0, release candidate #2, without -all package

2017-12-18 Thread Sijie Guo
+1 (binding) 1) notices, licenses look good to me (I can be biased since I made that change) 2) md5, signature look good 3) binary package looks good (run standalone) 4) source package looks good (compile, test and run standalone) 5) artifactory, tag look good Environment: OSX On Mon, Dec 18, 20

Re: [Vote] Apache BookKeeper Release 4.6.0, release candidate #2, without -all package

2017-12-18 Thread Enrico Olivelli
Il mar 19 dic 2017, 02:13 Jia Zhai ha scritto: > Hi everyone, > > Please review and vote on the release candidate #2 for the version > 4.6.0, as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > +1 run tests from src package Checked

[Vote] Apache BookKeeper Release 4.6.0, release candidate #2, without -all package

2017-12-18 Thread Jia Zhai
Hi everyone, Please review and vote on the release candidate #2 for the version 4.6.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) This new release candidate mainly fixed the license issue, also removed bookkeeper-all package for i