> > Not an issue with master as blockAddCompletions has been replaced with
> > a simple boolean and failure handling changed to only deal with one
> > failure at a time. However, looking at it again, I think I did spot a
> > similar bug. will dig in after I send this.
>
> Great; looking forward.
I
On Mon, Dec 3, 2018 at 1:40 AM Ivan Kelly wrote:
> > This may not be an issue with the master as we moved to immutable
> metadata,
>
> Not an issue with master as blockAddCompletions has been replaced with
> a simple boolean and failure handling changed to only deal with one
> failure at a time.
> This may not be an issue with the master as we moved to immutable metadata,
Not an issue with master as blockAddCompletions has been replaced with
a simple boolean and failure handling changed to only deal with one
failure at a time. However, looking at it again, I think I did spot a
similar bug
This may not be an issue with the master as we moved to immutable metadata,
but older releases have an issue with not decrementing blockAddCompletions.
Sijie/Ivan/Sam can you validate this?
blockAddCompletions gets incremented while initiating the ensemble change
in handleBookieFailure(). Base
