Re: ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Enrico Olivelli
Il ven 21 lug 2017, 20:11 Sijie Guo ha scritto: > Checked the code and also confirmed with Matteo: > > - if you are using V3 protocol, all the ByteBuf are unpooled because of the > deserialization of protobuf. It already makes the copy of the memory coming > from Netty. so there is not memory lea

Re: ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Sijie Guo
Checked the code and also confirmed with Matteo: - if you are using V3 protocol, all the ByteBuf are unpooled because of the deserialization of protobuf. It already makes the copy of the memory coming from Netty. so there is not memory leak even you don't iterate over the enumeration. - if you are

Re: ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Enrico Olivelli
Il ven 21 lug 2017, 18:39 Sijie Guo ha scritto: > On Jul 21, 2017 9:25 AM, "Enrico Olivelli" wrote: > > Il ven 21 lug 2017, 18:19 Sijie Guo ha scritto: > > > On Jul 21, 2017 12:59 AM, "Enrico Olivelli" wrote: > > > > Hi, > > I have just file this issue > > https://github.com/apache/bookkeeper/

Re: ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Sijie Guo
On Jul 21, 2017 9:25 AM, "Enrico Olivelli" wrote: Il ven 21 lug 2017, 18:19 Sijie Guo ha scritto: > On Jul 21, 2017 12:59 AM, "Enrico Olivelli" wrote: > > Hi, > I have just file this issue > https://github.com/apache/bookkeeper/issues/271 > > After the switch to Netty 4 I noticed this "API cha

Re: ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Enrico Olivelli
Il ven 21 lug 2017, 18:19 Sijie Guo ha scritto: > On Jul 21, 2017 12:59 AM, "Enrico Olivelli" wrote: > > Hi, > I have just file this issue > https://github.com/apache/bookkeeper/issues/271 > > After the switch to Netty 4 I noticed this "API change", that is very > important to be documented and/

Re: ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Sijie Guo
On Jul 21, 2017 9:17 AM, "Enrico Olivelli" wrote: Il ven 21 lug 2017, 16:55 Enrico Olivelli ha scritto: > (I am writing comments and proposals on the issue, I don't know where is > the best place to talk) > https://github.com/apache/bookkeeper/issues/271 > > > I think that we could break existi

Re: ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Sijie Guo
On Jul 21, 2017 12:59 AM, "Enrico Olivelli" wrote: Hi, I have just file this issue https://github.com/apache/bookkeeper/issues/271 After the switch to Netty 4 I noticed this "API change", that is very important to be documented and/or to be addresses. I think documentation is important in this

Re: ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Enrico Olivelli
Il ven 21 lug 2017, 16:55 Enrico Olivelli ha scritto: > (I am writing comments and proposals on the issue, I don't know where is > the best place to talk) > https://github.com/apache/bookkeeper/issues/271 > > > I think that we could break existing downstream applications, we must > address this p

Re: ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Enrico Olivelli
(I am writing comments and proposals on the issue, I don't know where is the best place to talk) https://github.com/apache/bookkeeper/issues/271 I think that we could break existing downstream applications, we must address this problem I think that we should change in a braking way the readEntri

Re: ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Venkateswara Rao Jujjuri
Can we also add some stats around this to track these. ? Discipline around memory release is new concept to Java world. On Fri, Jul 21, 2017 at 12:59 AM Enrico Olivelli wrote: > Hi, > I have just file this issue > https://github.com/apache/bookkeeper/issues/271 > > After the switch to Netty 4

ByteBuf memory leak after Netty 4 switch on the client API

2017-07-21 Thread Enrico Olivelli
Hi, I have just file this issue https://github.com/apache/bookkeeper/issues/271 After the switch to Netty 4 I noticed this "API change", that is very important to be documented and/or to be addresses. Inside LedgerEntry object we retain a ByteBuf, which is turn is automatically 'released' only in