Re: CI shows successfully but the tests actually has errors

2023-02-20 Thread Yong Zhang
Here is the PR for fixing this https://github.com/apache/bookkeeper/pull/3790 I am still trying to get the tests passed https://github.com/zymap/bookkeeper/pull/20 Thanks, Yong On Tue, 21 Feb 2023 at 10:10, Yong Zhang wrote: > I took a look at the issue and found the root cause. > > I will

Re: CI shows successfully but the tests actually has errors

2023-02-20 Thread Yong Zhang
I took a look at the issue and found the root cause. I will push a fix later. Yong On Tue, 21 Feb 2023 at 10:00, Yan Zhao wrote: > > Hi Yong, > > Thanks for finding this critical issue. I think it's dangerous to > > merge new PRs before the CI is fixed, because we can't ensure whether >

Re: CI shows successfully but the tests actually has errors

2023-02-20 Thread Yan Zhao
> Hi Yong, > Thanks for finding this critical issue. I think it's dangerous to > merge new PRs before the CI is fixed, because we can't ensure whether > the new PRs introduces bugs. +1

Re: CI shows successfully but the tests actually has errors

2023-02-20 Thread Hang Chen
Hi Yong, Thanks for finding this critical issue. I think it's dangerous to merge new PRs before the CI is fixed, because we can't ensure whether the new PRs introduces bugs. Thanks, Hang Yong Zhang 于2023年2月21日周二 09:15写道: > > Hi folks, > > I found our CI may have some problems. > > In the

CI shows successfully but the tests actually has errors

2023-02-20 Thread Yong Zhang
Hi folks, I found our CI may have some problems. In the master code, the tests failed, but the CI was successful. The following is the latest commit CI action: https://github.com/apache/bookkeeper/actions/runs/4219246330/jobs/7324432945 Error: Tests run: 633, Failures: 0, Errors: 29, Skipped: