Re: Usefulness of ensemble change during recovery

2018-08-13 Thread Ivan Kelly
Yup, we had already concluded we need the ensemble change for some cases. Code didn't turn out as messy as I'd feared though (I don't think I've pushed this yet). -Ivan On Mon, Aug 13, 2018 at 8:29 PM, Sam Just wrote: > To flesh out JV's point a bit more, suppose we've got a 5/5/4 ledger which

Re: Usefulness of ensemble change during recovery

2018-08-13 Thread Sam Just
To flesh out JV's point a bit more, suppose we've got a 5/5/4 ledger which needs to be recovery opened. In such a scenario, suppose the last entry on each of the 5 bookies (no holes) are 10,10,10,10,19. Any entry in [10,19] is valid as the end of the ledger, but the safest answer for the end of

Re: Usefulness of ensemble change during recovery

2018-08-06 Thread Venkateswara Rao Jujjuri
I don't think it a good idea to leave the tail to the replication. This could lead to the perception of data loss, and it's more evident in the case of larger WQ and disparity with AQ. If we determine LLAC based on having 'a copy', which is never acknowledged to the client, and if that bookie goes

Re: Usefulness of ensemble change during recovery

2018-08-06 Thread Sijie Guo
On Mon, Aug 6, 2018 at 12:08 AM Ivan Kelly wrote: > >> Recovery operates on a few seconds of data (from the last LAC written > >> to the end of the ledger, call this LLAC). > > > > the data during this duration can be very large if the traffic of the > > ledger is large. That has > > been

Re: Usefulness of ensemble change during recovery

2018-08-06 Thread Ivan Kelly
>> Recovery operates on a few seconds of data (from the last LAC written >> to the end of the ledger, call this LLAC). > > the data during this duration can be very large if the traffic of the > ledger is large. That has > been observed at Twitter's production. so when we are talking about "a few

Re: Usefulness of ensemble change during recovery

2018-08-06 Thread Sijie Guo
On Sun, Aug 5, 2018 at 11:46 PM Sijie Guo wrote: > > > On Sat, Aug 4, 2018 at 1:49 AM Ivan Kelly wrote: > >> Hi folks, >> >> Recently I've been working to make the ledger metadata on the client >> immutable, with the goal of making client metadata management more >> understandable. The basic

Re: Usefulness of ensemble change during recovery

2018-08-06 Thread Sijie Guo
On Sat, Aug 4, 2018 at 1:49 AM Ivan Kelly wrote: > Hi folks, > > Recently I've been working to make the ledger metadata on the client > immutable, with the goal of making client metadata management more > understandable. The basic idea is that the metadata the client uses > should reflect what

Usefulness of ensemble change during recovery

2018-08-04 Thread Ivan Kelly
Hi folks, Recently I've been working to make the ledger metadata on the client immutable, with the goal of making client metadata management more understandable. The basic idea is that the metadata the client uses should reflect what is in zookeeper. So if a client wants to modify the metadata,