[GitHub] incubator-brooklyn pull request: Jclouds machines: do not persist ...

Github user neykov commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1082#discussion_r46522492 --- Diff: locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/RebindJcloudsLocationLiveTest.java --- @@ -94,6 +101,100 @@ public

[GitHub] incubator-brooklyn pull request: Jclouds machines: do not persist ...

Github user neykov commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1082#issuecomment-161546685 Really happy to see so much brittle state removed from persistence. Looks good so far. --- If your project is set up for it, you can reply to this email an

Build failed in Jenkins: incubator-brooklyn-master-windows #379

See Changes: [aled.sage] Adds @Since to Configurable.getConfig [aled.sage] WinRM testing: refactor so can be sub-classed [aled.sage] WinRm machine: extract config for WinRmTool --

[GitHub] incubator-brooklyn pull request: [do not merge] For discussion ......

GitHub user m4rkmckenna opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1085 [do not merge] For discussion ... Making PortForwarderAsync Async Ive made a change to PortForwarderAsync that makes it asynchronous. Im looking for suggestions on how to ve

[GitHub] incubator-brooklyn pull request: Type registry - validation and al...

Github user neykov commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1073#issuecomment-161621581 Looks good. Very minor comments to address and some others to respond to. --- If your project is set up for it, you can reply to this email and have your re

Re: [PROPOSAL] Location model refactoring

Hadrian- TL;DR - I like the direction you're going in, although I'm not sure of the conclustions. Firstly there is a lot of synergy with two things I've been working on lately: (1) typed relationships (2) multiple supertypes/interfaces on entities/brooklyn objects With (1) we're be bette

[GitHub] incubator-brooklyn pull request: Fix: winrm and jclouds to private...

GitHub user aledsage opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1086 Fix: winrm and jclouds to private-VMs, and miscelaneous You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/incubator-brookly

[GitHub] incubator-brooklyn pull request: Fix: winrm and jclouds to private...

Github user bostko commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1086#issuecomment-161730749 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] incubator-brooklyn pull request: [do not merge] For discussion ......

Github user aledsage commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1085#issuecomment-161744052 I'm looking at how we test this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] incubator-brooklyn pull request: Fix: winrm and jclouds to private...

Github user aledsage commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1086#issuecomment-161750080 Thanks @bostko - merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-brooklyn pull request: Fix: winrm and jclouds to private...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1086 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

Re: YAML Blueprints Failing to Stop

Problem reduced to simpler and more generic terms: -Stop is called on a BasicApplication "A" -Stop is then called on A's children, X and Y, in parallel[1] -Y has a `shell.env` value which is an `attributeWhenReady` of a value from X -Y hangs infinitely trying to resolve the value from X which has

[GitHub] incubator-brooklyn pull request: JcloudsLocation: fix waitForWinRm...

Github user bostko commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1087#discussion_r46630734 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -2537,28 +2563,53 @@ protected LoginCr

[GitHub] incubator-brooklyn pull request: JcloudsLocation: fix waitForWinRm...

GitHub user aledsage opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1087 JcloudsLocation: fix waitForWinRm, for alternate WinRmTool Previously JcloudsLocation was hard-coded to use the winrm4j directly, in waitForWinrmAvailable. Now it follows the same p

[GitHub] incubator-brooklyn pull request: JcloudsLocation: fix waitForWinRm...

Github user bostko commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1087#issuecomment-161827503 Looks good, with one minor comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-brooklyn pull request: [DISCUSSION] Sequential Entity St...

GitHub user mikezaccardo opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1088 [DISCUSSION] Sequential Entity Stop Order This adds a `stop.sequence.position` config value which enables YAML blueprint authors to explicitly specify a stop order. This can preve

Re: YAML Blueprints Failing to Stop

I went ahead and partially implemented the second, simpler solution[1]. With this fix, the blueprint I posted above which demonstrates this problem will now stop when proper `stop.sequence.position` values are added to the YAML file. Any thoughts (posted here or in the PR)? -Mike [1] https://git