Build failed in Jenkins: incubator-brooklyn-master-windows #395

See -- [...truncated 41797 lines...] [INFO] [INFO] [INFO] [INFO] --- maven-site-plugin:3.4:attach-descriptor (attach-descriptor) @ brooklyn-sample --- [INFO] [INFO] [INFO] [INFO] --- m

[GitHub] incubator-brooklyn pull request: Test correct persistence of attri...

Github user aledsage commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1120#issuecomment-169709323 Thanks @googlielmo - merging now (and will check about tabs versus spaces after that). --- If your project is set up for it, you can reply to this email

[GitHub] incubator-brooklyn pull request: Test correct persistence of attri...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1120 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-brooklyn pull request: Update commons-lang3 to 3.3.2

Github user aledsage commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1125#issuecomment-169708963 Not sure this change is enough. Looking at `mvn dependency:tree`, it also has: [INFO] +- io.swagger:swagger-core:jar:1.5.3:compile [IN

[GitHub] incubator-brooklyn pull request: Fix getRequiredOpenPorts in SameS...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1129 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-brooklyn pull request: Fix getRequiredOpenPorts in SameS...

Github user sjcorbett commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1129#issuecomment-169697503 @nakomis Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-brooklyn pull request: Fix getRequiredOpenPorts in SameS...

Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1129#discussion_r49084975 --- Diff: brooklyn-server/software/base/src/main/java/org/apache/brooklyn/entity/software/base/SameServerDriverLifecycleEffectorTasks.java ---

[GitHub] incubator-brooklyn pull request: Fix getRequiredOpenPorts in SameS...

Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1129#discussion_r49084915 --- Diff: brooklyn-server/software/base/src/main/java/org/apache/brooklyn/entity/software/base/SameServerDriverLifecycleEffectorTasks.java ---

[GitHub] incubator-brooklyn pull request: Fix getRequiredOpenPorts in SameS...

Github user nakomis commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1129#issuecomment-169697179 One minor point (more of a clarification), but other than that, LGTM --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-brooklyn pull request: Support "externalised config" in ...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1130#discussion_r49080187 --- Diff: brooklyn-server/core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -391,18 +396,61 @@ else

[GitHub] incubator-brooklyn pull request: WinRm documentation - In Powershe...

GitHub user bostko opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1131 WinRm documentation - In Powershell use Start-Process ... -Wait You can merge this pull request into a Git repository by running: $ git pull https://github.com/bostko/incubator-bro

[GitHub] incubator-brooklyn pull request: Support "externalised config" in ...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1130#discussion_r49079996 --- Diff: brooklyn-server/core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java --- @@ -391,18 +396,61 @@ else

Re: Support for external config in catalog definition

Hi, This is the PR - #1130 . Could someone review please? Thanks! Best, Ivana On 5 January 2016 at 19:36, Aled Sage wrote: > Hi Ivana, > > Tricky - given the first level of yaml parsing is being done in a > completely different place. >

[GitHub] incubator-brooklyn pull request: improvements to rest-api module

Github user andreaturli commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-169665520 thanks @ahgittin for comments - `Object.hashCode` or `Objects.equals` from Guava are nicer but I wanted to avoid to have a direct dependency on Guav

[GitHub] incubator-brooklyn pull request: improvements to rest-api module

Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-169663939 why move `HighAvailabilityMode` and `ManagementNodeState` to different packages? that will break backwards compatibility (and so should be in README if w

[GitHub] incubator-brooklyn pull request: improvements to rest-api module

Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-169661760 i prefer `Objects.hashCode` over autogenerated and use of `Objects.equal(.., ..)` over three-part check but no strong feeling. i have no preference on th

[GitHub] incubator-brooklyn pull request: improvements to rest-api module

Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-169661215 are you sure the `LocationApi` methods aren't used in the current UI ? --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] incubator-brooklyn pull request: improvements to rest-api module

Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-169661022 using https://github.com/apache/incubator-brooklyn/pull/1127/files?w=1 you can at least see the changes in github. (@andreaturli worth checking what your

[GitHub] incubator-brooklyn pull request: improvements to rest-api module

Github user sjcorbett commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-169656652 Likewise with AccessSummary.equals could do the type checks and then `Objects.equals(this.locationProvisioningAllowed, that.locationProvisioningAllowed)

[GitHub] incubator-brooklyn pull request: improvements to rest-api module

Github user sjcorbett commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-169656161 brooklyn-server/rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/AccessSummary.java I think it would be better to continue using `Objects.h

[GitHub] incubator-brooklyn pull request: improvements to rest-api module

Github user sjcorbett commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-169654793 brooklyn-server/rest/rest-api/generated/swagger-api-spec/retrofit2.json: What is this file for? Why does it refer to "petstore"? ``` { "l

[GitHub] incubator-brooklyn pull request: improvements to rest-api module

Github user sjcorbett commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-169654547 brooklyn-server/karaf/features/src/main/history/dependencies.xml: Do you really want to remove `BROOKLYN_VERSION` from --- If your project is set up

[GitHub] incubator-brooklyn pull request: improvements to rest-api module

GitHub user andreaturli reopened a pull request: https://github.com/apache/incubator-brooklyn/pull/1127 improvements to rest-api module Initial work to simplify the rest server: - remove `JsonNode` from API interfaces - refactor consistently `toString`and `hashCode` and