Build failed in Jenkins: brooklyn-master-windows #118

See -- Started by upstream project "brooklyn-master-build" build number 196 originally caused by: Started by timer [EnvInject] - Loading node environment variables. Building remotely on windows1 (

Jenkins build is back to normal : brooklyn-master-build #196

See

[GitHub] brooklyn-server pull request: Transformer enricher: support trigge...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/141#discussion_r63970349 --- Diff: core/src/main/java/org/apache/brooklyn/enricher/stock/AbstractTransformer.java --- @@ -59,27 +72,55 @@ public void setEntity(EntityLocal

[GitHub] brooklyn-server pull request: Transformer enricher: support trigge...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/141#discussion_r63970280 --- Diff: core/src/main/java/org/apache/brooklyn/enricher/stock/AbstractTransformer.java --- @@ -59,27 +72,55 @@ public void setEntity(EntityLocal

[GitHub] brooklyn-server pull request: Transformer enricher: support trigge...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/141#discussion_r63969965 --- Diff: core/src/main/java/org/apache/brooklyn/enricher/stock/AbstractTransformer.java --- @@ -59,27 +72,55 @@ public void setEntity(EntityLocal

[GitHub] brooklyn-server pull request: BROOKLYN-259: Fix JcloudsByonLocatio...

Github user aledsage commented on the pull request: https://github.com/apache/brooklyn-server/pull/132#issuecomment-220478329 Rebasing fixed the problem in my test where `assertEquals(machine.getUser(), "myuser");` was failing (so that is now uncommented). I hope that whatever fixed t

[jira] [Commented] (BROOKLYN-259) jcloudsByon location spec leaks location instances

[ https://issues.apache.org/jira/browse/BROOKLYN-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292325#comment-15292325 ] ASF GitHub Bot commented on BROOKLYN-259: - Github user aledsage commented on the

[jira] [Commented] (BROOKLYN-271) ConfigKey card shows object hashCode of default values

[ https://issues.apache.org/jira/browse/BROOKLYN-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292133#comment-15292133 ] Aled Sage commented on BROOKLYN-271: [~kiuby88] yes, I think that makes sense. We ca

[jira] [Commented] (BROOKLYN-271) ConfigKey card shows object hashCode of default values

[ https://issues.apache.org/jira/browse/BROOKLYN-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292063#comment-15292063 ] Jose Carrasco commented on BROOKLYN-271: [~aled.sage] Following, you can find th

Build failed in Jenkins: brooklyn-master-build #195

See -- [...truncated 43802 lines...] [INFO] Brooklyn Vagrant Getting Started Environment ... SKIPPED [INFO] Brooklyn Quick-Start Project Archetype . SKIPPED [INFO] Brooklyn DEB Packag

Build failed in Jenkins: brooklyn-master-windows #117

See -- [...truncated 20004 lines...] 2016-05-19 18:00:34,493 WARN Task Task[LSM.publish(TestEntityImpl{id=ap85kenP}.Sensor: service.isUp (java.lang.Boolean)=false @ 1463677232437);[subscription

[GitHub] brooklyn-server pull request: Transformer enricher: support trigge...

Github user neykov commented on the pull request: https://github.com/apache/brooklyn-server/pull/141#issuecomment-220390596 Minor comments only, mostly for discussion. Can be merged as is. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-server pull request: Transformer enricher: support trigge...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/141#discussion_r63917529 --- Diff: core/src/main/java/org/apache/brooklyn/enricher/stock/AbstractTransformer.java --- @@ -59,27 +72,55 @@ public void setEntity(EntityLocal en

[GitHub] brooklyn-server pull request: Transformer enricher: support trigge...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/141#discussion_r63916684 --- Diff: core/src/main/java/org/apache/brooklyn/enricher/stock/AbstractTransformer.java --- @@ -59,27 +72,55 @@ public void setEntity(EntityLocal en

Jenkins build is back to normal : brooklyn-server-master #82

See

[GitHub] brooklyn-server pull request: Transformer enricher: support trigge...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/141#discussion_r63915125 --- Diff: core/src/main/java/org/apache/brooklyn/enricher/stock/AbstractTransformer.java --- @@ -59,27 +72,55 @@ public void setEntity(EntityLocal en

[GitHub] brooklyn-docs pull request: Documentation on configuring Openstack...

Github user mikezaccardo commented on the pull request: https://github.com/apache/brooklyn-docs/pull/67#issuecomment-220385229 Thanks @sjcorbett, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] brooklyn-server pull request: Transformer enricher: support trigge...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/141#discussion_r63913952 --- Diff: core/src/main/java/org/apache/brooklyn/enricher/stock/AbstractTransformer.java --- @@ -59,27 +72,55 @@ public void setEntity(EntityLocal en

[GitHub] brooklyn-server pull request: Transformer enricher: support trigge...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/141#discussion_r63913837 --- Diff: core/src/main/java/org/apache/brooklyn/enricher/stock/AbstractTransformer.java --- @@ -59,27 +72,55 @@ public void setEntity(EntityLocal en

Jenkins build is back to normal : brooklyn-master-build #194

See

[jira] [Commented] (BROOKLYN-271) ConfigKey card shows object hashCode of default values

[ https://issues.apache.org/jira/browse/BROOKLYN-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291372#comment-15291372 ] Jose Carrasco commented on BROOKLYN-271: [~aled.sage], thanks for your reply. I

[GitHub] brooklyn-docs pull request: Corrected broken link 'git-clone'

GitHub user f377isB opened a pull request: https://github.com/apache/brooklyn-docs/pull/69 Corrected broken link 'git-clone' Found a broken link on the Brooklyn website https://brooklyn.apache.org/v/latest/yaml/creating-yaml.html - its the git-clone link towards the bottom. Cu

[jira] [Commented] (BROOKLYN-259) jcloudsByon location spec leaks location instances

[ https://issues.apache.org/jira/browse/BROOKLYN-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291361#comment-15291361 ] ASF GitHub Bot commented on BROOKLYN-259: - Github user aledsage commented on a d

[GitHub] brooklyn-server pull request: BROOKLYN-259: Fix JcloudsByonLocatio...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/132#discussion_r63905627 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsByonLocationResolver.java --- @@ -61,129 +56,140 @@ * @

[GitHub] brooklyn-docs pull request: Fix BROOKLYN-271: ConfigKey card shows...

GitHub user kiuby88 opened a pull request: https://github.com/apache/brooklyn-docs/pull/68 Fix BROOKLYN-271: ConfigKey card shows object hashCode of default values. Fixing [BROOKLYN-271](https://issues.apache.org/jira/browse/BROOKLYN-271) Avoiding object references in catalog Con

[jira] [Commented] (BROOKLYN-271) ConfigKey card shows object hashCode of default values

[ https://issues.apache.org/jira/browse/BROOKLYN-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291362#comment-15291362 ] ASF GitHub Bot commented on BROOKLYN-271: - GitHub user kiuby88 opened a pull req

[jira] [Commented] (BROOKLYN-271) ConfigKey card shows object hashCode of default values

[ https://issues.apache.org/jira/browse/BROOKLYN-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291360#comment-15291360 ] Aled Sage commented on BROOKLYN-271: Thanks for spotting this! We're just using the

[GitHub] brooklyn-server pull request: BROOKLYN-259: Fix JcloudsByonLocatio...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/132#discussion_r63903569 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsByonLocationResolver.java --- @@ -61,129 +56,140 @@ * @

[jira] [Commented] (BROOKLYN-259) jcloudsByon location spec leaks location instances

[ https://issues.apache.org/jira/browse/BROOKLYN-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291342#comment-15291342 ] ASF GitHub Bot commented on BROOKLYN-259: - Github user aledsage commented on a d

[GitHub] brooklyn-server pull request: Adds TestEndpointReachable (for yaml...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/142 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[jira] [Created] (BROOKLYN-271) ConfigKey card shows object hashCode of default values

Jose Carrasco created BROOKLYN-271: -- Summary: ConfigKey card shows object hashCode of default values Key: BROOKLYN-271 URL: https://issues.apache.org/jira/browse/BROOKLYN-271 Project: Brooklyn

[GitHub] brooklyn-docs pull request: Documentation on configuring Openstack...

Github user drigodwin commented on the pull request: https://github.com/apache/brooklyn-docs/pull/67#issuecomment-220364331 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] brooklyn-server pull request: Adds TestEndpointReachable (for yaml...

Github user aledsage commented on the pull request: https://github.com/apache/brooklyn-server/pull/142#issuecomment-220364129 Thanks @neykov - merging now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] brooklyn-ui pull request: Location wizard generates correct spec f...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-ui/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] brooklyn-ui pull request: Location wizard generates correct spec f...

Github user sjcorbett commented on the pull request: https://github.com/apache/brooklyn-ui/pull/26#issuecomment-220357021 @mikezaccardo Thanks. Will merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] brooklyn-docs pull request: Documentation on configuring Openstack...

GitHub user sjcorbett opened a pull request: https://github.com/apache/brooklyn-docs/pull/67 Documentation on configuring Openstack networks and floating IPs You can merge this pull request into a Git repository by running: $ git pull https://github.com/sjcorbett/brooklyn-docs

[GitHub] brooklyn-ui pull request: Location wizard generates correct spec f...

Github user mikezaccardo commented on the pull request: https://github.com/apache/brooklyn-ui/pull/26#issuecomment-220355541 Tested, works as expected. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] brooklyn-ui pull request: Location wizard generates correct spec f...

GitHub user sjcorbett opened a pull request: https://github.com/apache/brooklyn-ui/pull/26 Location wizard generates correct spec for Openstack The wizard previously used `jclouds:openstack` and adding to the catalogue threw an error with "Transformer for Brooklyn OASIS CAMP interpr

[GitHub] brooklyn-server pull request: Adds TestEndpointReachable (for yaml...

Github user neykov commented on the pull request: https://github.com/apache/brooklyn-server/pull/142#issuecomment-220328965 Good to merge, once Jenkins is happy. Current failure: `[ERROR] TestEndpointReachableImpl.java[47:1] (imports) IllegalImport: Import from illegal package -

[GitHub] brooklyn-server pull request: Adds TestEndpointReachable (for yaml...

Github user neykov commented on the pull request: https://github.com/apache/brooklyn-server/pull/142#issuecomment-220309571 +1 for proposed syntax --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] brooklyn-server pull request: Adds TestEndpointReachable (for yaml...

Github user aledsage commented on the pull request: https://github.com/apache/brooklyn-server/pull/142#issuecomment-220305397 I also wondered about the inverse. Agree it's worth adding. For consistency with the other TestCase types, I'll go for YAML syntax like that below (where it de

[GitHub] brooklyn-server pull request: Adds TestEndpointReachable (for yaml...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/142#discussion_r63865867 --- Diff: test-framework/src/test/java/org/apache/brooklyn/test/framework/TestEndpointReachableTest.java --- @@ -0,0 +1,222 @@ +/* + * Lice

Re: Renaming persisted classes

For OSGi we will need to revisit the functionality to work across bundle boundaries. Supposedly users starting with the OSGi-fied distribution will have a clean slate, so don't need to worry about renamed classes, at least for the first version. I can suggest another alternative for the standard

Build failed in Jenkins: brooklyn-server-master #81

See Changes: [bostko] Suppress exceptions in the isRunning check for Windows -- [...truncated 40372 lines...] [INFO] Brooklyn Groovy Utilities .. SUCCESS [ 2.813 s]

[GitHub] brooklyn-library pull request: Allow creating roles for PostgreSQL

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/33#discussion_r63860899 --- Diff: software/database/src/main/java/org/apache/brooklyn/entity/database/postgresql/PostgreSqlSshDriver.java --- @@ -328,9 +342,51 @@ private

[GitHub] brooklyn-library pull request: Allow creating roles for PostgreSQL

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/33#discussion_r63860470 --- Diff: software/database/src/main/java/org/apache/brooklyn/entity/database/postgresql/PostgreSqlSshDriver.java --- @@ -320,6 +324,16 @@ private

[GitHub] brooklyn-library pull request: Allow creating roles for PostgreSQL

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/33#discussion_r63860110 --- Diff: software/database/src/main/java/org/apache/brooklyn/entity/database/postgresql/PostgreSqlNode.java --- @@ -90,6 +93,23 @@

[GitHub] brooklyn-server pull request: Suppress exceptions in the isRunning...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/145 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] brooklyn-server pull request: Suppress exceptions in the isRunning...

Github user aledsage commented on the pull request: https://github.com/apache/brooklyn-server/pull/145#issuecomment-220293249 A couple of minor thoughts, but merging now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] brooklyn-server pull request: Suppress exceptions in the isRunning...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/145#discussion_r63859261 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcessWinRmDriver.java --- @@ -80,9 +84,22 @@ public

[GitHub] brooklyn-server pull request: Suppress exceptions in the isRunning...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/145#discussion_r63859115 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcessWinRmDriver.java --- @@ -80,9 +84,22 @@ public

Re: Renaming persisted classes

I'm not sure I'm happy with the idea of many 3rd-party jars adding stuff into a Brooklyn-owned package. It doesn't rule out a couple of 3rd-party packages happening to choose the same name. I also think there might be issues with OSGi, as OSGi requires explicit declaration of packages, but I don't

Renaming persisted classes

Hi Folks, Just a quick heads-up about a PR I raised yesterday When Brooklyn is rebinding from persisted state, it instantiates classes (such as entities) based on the persisted fully-qualified classname. This causes a problem if the name of the

[GitHub] brooklyn-server pull request: Suppress exceptions in the isRunning...

Github user nakomis commented on the pull request: https://github.com/apache/brooklyn-server/pull/145#issuecomment-220266139 A future improvement would be for `AbstractSoftwareProcessWinRmDriver.rebootAndWait` to set a sensor to indicate that the machine is rebooting, which could be c

[GitHub] brooklyn-server pull request: Adds TestEndpointReachable (for yaml...

Github user neykov commented on the pull request: https://github.com/apache/brooklyn-server/pull/142#issuecomment-220265656 Looks good, nice test coverage. What do you think about adding an option to reverse the test - successful if can't connect (for example by adding `assertFails: t

[GitHub] brooklyn-docs pull request: Windows - Advices for blueprints that ...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/66#discussion_r63842330 --- Diff: guide/yaml/winrm/index.md --- @@ -271,6 +271,16 @@ config like `pre.install.reboot.required` and `install.reboot.required`. If requ inst

[GitHub] brooklyn-server pull request: Adds TestEndpointReachable (for yaml...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/142#discussion_r63842237 --- Diff: test-framework/src/test/java/org/apache/brooklyn/test/framework/TestEndpointReachableTest.java --- @@ -0,0 +1,222 @@ +/* + * Licens

[GitHub] brooklyn-server pull request: Adds TestEndpointReachable (for yaml...

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/142#discussion_r63841995 --- Diff: test-framework/src/main/java/org/apache/brooklyn/test/framework/TestEndpointReachableImpl.java --- @@ -0,0 +1,180 @@ +/* + * Licens

[GitHub] brooklyn-server pull request: Suppress exceptions in the isRunning...

Github user aledsage commented on the pull request: https://github.com/apache/brooklyn-server/pull/145#issuecomment-220257668 Looks good. One minor comment worth adding to the code, then good to merge. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] brooklyn-server pull request: Suppress exceptions in the isRunning...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/145#discussion_r63838436 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcessWinRmDriver.java --- @@ -80,9 +80,15 @@ public