Build failed in Jenkins: brooklyn-master-windows #147

See -- [...truncated 31022 lines...] org.apache.brooklyn.camp.brooklyn.ConfigInheritanceYamlTest.tearDown(org.apache.brooklyn.camp.brooklyn.ConfigInheritanceYamlTest) Run 1:

[GitHub] brooklyn-server pull request #194: Prevents premature resolving of external ...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/194#discussion_r66627553 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/JcloudsLocationExternalConfigYamlTest.java --- @@ -0,0 +1,143 @@

[GitHub] brooklyn-server issue #194: Prevents premature resolving of external config

Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/194 LGTM, minor comments, including test and naming let's give it a day for @aledsage @andreaturli @neykov to comment on names/future and see whether to do in this PR but happy to

[GitHub] brooklyn-server pull request #194: Prevents premature resolving of external ...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/194#discussion_r66627723 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/config/ConfigBag.java --- @@ -367,6 +367,22 @@ public Object getStringKey(String key) {

[GitHub] brooklyn-server pull request #194: Prevents premature resolving of external ...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/194#discussion_r66626931 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/JcloudsLocationExternalConfigYamlTest.java --- @@ -0,0 +1,143 @@

[GitHub] brooklyn-server issue #195: Sanitize effector parameters when reporting an e...

Github user ygy commented on the issue: https://github.com/apache/brooklyn-server/pull/195 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server pull request #192: Adds OnSubnetNetworkEnricher

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/192#discussion_r66622693 --- Diff: core/src/main/java/org/apache/brooklyn/core/network/AbstractOnNetworkEnricher.java --- @@ -0,0 +1,402 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #192: Adds OnSubnetNetworkEnricher

Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/192#discussion_r66622079 --- Diff: core/src/main/java/org/apache/brooklyn/core/network/AbstractOnNetworkEnricher.java --- @@ -0,0 +1,407 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #195: Sanitize effector parameters when reporti...

GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-server/pull/195 Sanitize effector parameters when reporting an exception You can merge this pull request into a Git repository by running: $ git pull https://github.com/bostko/brooklyn-server

[GitHub] brooklyn-server pull request #192: Adds OnSubnetNetworkEnricher

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #192: Adds OnSubnetNetworkEnricher

Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/192 Thanks all - merging now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-server pull request #192: Adds OnSubnetNetworkEnricher

Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/192#discussion_r66616715 --- Diff: core/src/main/java/org/apache/brooklyn/core/network/AbstractOnNetworkEnricher.java --- @@ -0,0 +1,407 @@ +/* + * Licensed

[GitHub] brooklyn-server issue #194: Prevents premature resolving of external config

Github user nakomis commented on the issue: https://github.com/apache/brooklyn-server/pull/194 This is in addition to the changes in https://github.com/apache/brooklyn-server/pull/193 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-server pull request #194: Prevents premature resolving of external ...

GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-server/pull/194 Prevents premature resolving of external config If external config is resolved too early, it can lead to resolved values being persisted (security flaw). Also, changes to the external

[GitHub] brooklyn-server pull request #192: Adds OnSubnetNetworkEnricher

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/192#discussion_r66601272 --- Diff: core/src/main/java/org/apache/brooklyn/core/network/AbstractOnNetworkEnricher.java --- @@ -0,0 +1,407 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #192: Adds OnSubnetNetworkEnricher

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/192#discussion_r66600767 --- Diff: core/src/main/java/org/apache/brooklyn/core/network/AbstractOnNetworkEnricher.java --- @@ -0,0 +1,407 @@ +/* + * Licensed to the

[jira] [Commented] (BROOKLYN-298) sshj hangs (waiting for shell to finish) after script completed - maybe VPN went down+up during exec

[ https://issues.apache.org/jira/browse/BROOKLYN-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324327#comment-15324327 ] Svetoslav Neykov commented on BROOKLYN-298: --- Adding a keep-alive should detect this.

[GitHub] brooklyn-server issue #192: Adds OnSubnetNetworkEnricher

Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/192 Couple of minor questions and comments but none that *need* done, looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Created] (BROOKLYN-298) sshj hangs (waiting for shell to finish) after script completed - maybe VPN went down+up during exec

Aled Sage created BROOKLYN-298: -- Summary: sshj hangs (waiting for shell to finish) after script completed - maybe VPN went down+up during exec Key: BROOKLYN-298 URL:

[GitHub] brooklyn-server pull request #192: Adds OnSubnetNetworkEnricher

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/192#discussion_r66598970 --- Diff: core/src/main/java/org/apache/brooklyn/core/network/AbstractOnNetworkEnricher.java --- @@ -0,0 +1,407 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #192: Adds OnSubnetNetworkEnricher

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/192#discussion_r66596473 --- Diff: core/src/main/java/org/apache/brooklyn/core/network/AbstractOnNetworkEnricher.java --- @@ -0,0 +1,407 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #192: Adds OnSubnetNetworkEnricher

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/192#discussion_r66594543 --- Diff: core/src/main/java/org/apache/brooklyn/core/network/AbstractOnNetworkEnricher.java --- @@ -0,0 +1,407 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #192: Adds OnSubnetNetworkEnricher

Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/192#discussion_r66594302 --- Diff: core/src/main/java/org/apache/brooklyn/core/network/AbstractOnNetworkEnricher.java --- @@ -0,0 +1,407 @@ +/* + * Licensed to the

[GitHub] brooklyn-server issue #192: Adds OnSubnetNetworkEnricher

Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/192 Couple of comments then LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-server pull request #192: Adds OnSubnetNetworkEnricher

Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/192#discussion_r66592324 --- Diff: core/src/main/java/org/apache/brooklyn/core/network/AbstractOnNetworkEnricher.java --- @@ -0,0 +1,407 @@ +/* + * Licensed

[GitHub] brooklyn-server pull request #192: Adds OnSubnetNetworkEnricher

Github user Graeme-Miller commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/192#discussion_r66591368 --- Diff: core/src/main/java/org/apache/brooklyn/core/network/AbstractOnNetworkEnricher.java --- @@ -0,0 +1,407 @@ +/* + * Licensed

[GitHub] brooklyn-docs pull request #77: Machine naming in locations

GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-docs/pull/77 Machine naming in locations Added instructions to give a custom name to VMs in a location You can merge this pull request into a Git repository by running: $ git pull

[GitHub] brooklyn-dist pull request #37: Generate ssh keys for the brooklyn host

GitHub user andreaturli opened a pull request: https://github.com/apache/brooklyn-dist/pull/37 Generate ssh keys for the brooklyn host You can merge this pull request into a Git repository by running: $ git pull https://github.com/andreaturli/brooklyn-dist patch-1

[GitHub] brooklyn-server pull request #150: Ability to perform installation on a Wind...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/150#discussion_r66581776 --- Diff: software/winrm/src/main/java/org/apache/brooklyn/util/core/internal/winrm/WinRmTool.java --- @@ -46,7 +46,7 @@ ConfigKey

[GitHub] brooklyn-server pull request #150: Ability to perform installation on a Wind...

Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/150#discussion_r66580748 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcessWinRmDriver.java --- @@ -49,15 +50,27 @@ public

[GitHub] brooklyn-server pull request #150: Ability to perform installation on a Wind...

Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/150#discussion_r66579605 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcessWinRmDriver.java --- @@ -49,15 +50,27 @@

[GitHub] brooklyn-docs pull request #66: Windows - Advices for blueprints that are us...

Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/66 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature