[GitHub] brooklyn-server pull request #279: Allow provisioning.properties to referenc...

2016-07-29 Thread grkvlt
GitHub user grkvlt opened a pull request: https://github.com/apache/brooklyn-server/pull/279 Allow provisioning.properties to reference resolvable config Enables constructions like the following: ```YAML - type: vanilla-software-process brooklyn.config: provisio

[GitHub] brooklyn-server pull request #280: Add special flag decoration to parameters...

2016-07-29 Thread grkvlt
GitHub user grkvlt opened a pull request: https://github.com/apache/brooklyn-server/pull/280 Add special flag decoration to parameters to enable EntitySpec values You can merge this pull request into a Git repository by running: $ git pull https://github.com/grkvlt/brooklyn-se

[GitHub] brooklyn-server pull request #281: Prevent VanillaSoftwareProcess commands f...

2016-07-29 Thread grkvlt
GitHub user grkvlt opened a pull request: https://github.com/apache/brooklyn-server/pull/281 Prevent VanillaSoftwareProcess commands from being inherited by children You can merge this pull request into a Git repository by running: $ git pull https://github.com/grkvlt/brooklyn

[jira] [Commented] (BROOKLYN-317) AWS-EC2 provisioning fails: doesn't get public ip when waiting for ssh-reachability

2016-07-29 Thread Andrea Turli (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398993#comment-15398993 ] Andrea Turli commented on BROOKLYN-317: --- I couldn't reproduce the error but I can

[GitHub] brooklyn-library issue #51: Support proxying with TLS client certificates in...

2016-07-29 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-library/pull/51 LGTM, but I agree with Aled that testing would be beneficial. Andrew did you investigate further how to do this? --- If your project is set up for it, you can reply to this email and

[GitHub] brooklyn-server issue #274: Load default exception mapper in web.xml

2016-07-29 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/274 I thought you need this in tests (where web.xml is only used). For classic brooklyn that's added in BrooklynRestApi.getMiscResources() see also BrooklynRestApp.getProperties(). For Karaf in

Re: [PROPOSAL] Brooklyn DSL in YAML using custom YAML types

2016-07-29 Thread Svetoslav Neykov
Agree with that. Something I wrote a couple of hours ago while offline, so didn't see Alex's email: Something to have in mind when discussing this - YAML is a superset of JSON as all of you are well aware. Today we can express the Brooklyn CAMP spec completely in JSON and it will just work. I'v

[jira] [Commented] (BROOKLYN-319) RabbitMQ restart failure

2016-07-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399263#comment-15399263 ] ASF GitHub Bot commented on BROOKLYN-319: - GitHub user drigodwin opened a pull r

[GitHub] brooklyn-library pull request #54: Added wait to restart effector

2016-07-29 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-library/pull/54 Added wait to restart effector This addresses [BROOKLYN-319](https://issues.apache.org/jira/browse/BROOKLYN-319). You can merge this pull request into a Git repository by running: $

[GitHub] brooklyn-server pull request #271: Move karaf distribution to brooklyn-dist.

2016-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/271 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] brooklyn-library pull request #53: Move karaf distribution to brooklyn-dist.

2016-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-library/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] brooklyn-dist pull request #41: Move karaf distribution to brooklyn-dist.

2016-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-dist/pull/41 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Build failed in Jenkins: brooklyn-dist-master #26

2016-07-29 Thread Apache Jenkins Server
See Changes: [geoff.macartney] Move karaf distribution to brooklyn-dist. -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H10 (docker Ubuntu u

Build failed in Jenkins: brooklyn-server-master #208

2016-07-29 Thread Apache Jenkins Server
See Changes: [geoff.macartney] Move karaf distribution to brooklyn-dist. -- [...truncated 35210 lines...] 2016-07-29 13:31:30,854 INFO Stopping application BasicApplicationImpl{id=ap6gpok

Build failed in Jenkins: brooklyn-master-build #339

2016-07-29 Thread Apache Jenkins Server
See -- [...truncated 36758 lines...] [INFO] Brooklyn REST JavaScript Web GUI ... SUCCESS [01:11 min] [INFO] Brooklyn Server Root ... SUCCESS [ 0.984 s] [I

[GitHub] brooklyn-server issue #281: Prevent VanillaSoftwareProcess commands from bei...

2016-07-29 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-server/pull/281 +1 to this, it has caught me out in the past. It potentially breaks existing blueprints though so should be raised on the mailing list. The test failures are valid: ConfigInherita

Re: [PROPOSAL] Brooklyn DSL in YAML using custom YAML types

2016-07-29 Thread Thomas Bouron
@Alex, @Svet, @Andrew: I get that it could be handy to use our YAML as JSON. Do you have any examples of this kind of use within the Brooklyn ecosystem? If not, this is not a compelling argument to me because again, our YAML is currently not valid: we shouldn't use any `$brooklyn:(.+)` as key if it

[GitHub] brooklyn-library issue #51: Support proxying with TLS client certificates in...

2016-07-29 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-library/pull/51 jenkins build failure is unrelated - @grkvlt is kicking it off again: ``` Parsing POMs Downloaded artifact http://repository.apache.org/snapshots/org/apache/brooklyn/brookly

[GitHub] brooklyn-library issue #51: Support proxying with TLS client certificates in...

2016-07-29 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-library/pull/51 @grkvlt I agree this is too hard to write a test here for! We'd need to generate a certificate for the specific IP address of the server that the test is running against, then have some sof

[GitHub] brooklyn-library pull request #51: Support proxying with TLS client certific...

2016-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-library/pull/51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] brooklyn-server issue #279: Allow provisioning.properties to reference resol...

2016-07-29 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/279 @grkvlt test failures look plausibly related: failures in `JcloudsLocationTest`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] brooklyn-server pull request #279: Allow provisioning.properties to referenc...

2016-07-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/279#discussion_r72820800 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -527,7 +531,7 @@ public ComputeService g

[jira] [Commented] (BROOKLYN-249) errors using external config for JcloudsLocation

2016-07-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399627#comment-15399627 ] ASF GitHub Bot commented on BROOKLYN-249: - Github user aledsage commented on a d

[GitHub] brooklyn-server issue #279: Allow provisioning.properties to reference resol...

2016-07-29 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/279 The jenkins test failures look plausibly related: `JcloudsLocationTest` tests are failing. @grkvlt please add test(s) for this. See the existing tests like those in `JcloudsLocatio

[GitHub] brooklyn-server issue #280: Add special flag decoration to parameters to ena...

2016-07-29 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/280 @grkvlt Can you add a test to demonstrate what you're fixing please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] brooklyn-server pull request #279: Allow provisioning.properties to referenc...

2016-07-29 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/279#discussion_r72821487 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java --- @@ -527,7 +531,7 @@ public ComputeService g

[GitHub] brooklyn-server issue #281: Prevent VanillaSoftwareProcess commands from bei...

2016-07-29 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/281 Suggest you add the following tests to `org.apache.brooklyn.entity.software.base.VanillaSoftwareProcessTest`: @Test public void testCmdNotInheritedByChildrenOfSoftwarePr

[GitHub] brooklyn-server issue #277: Fix TestCases, and add TestSensor.abortCondition...

2016-07-29 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/277 To clarify what I meant by "validConditions sounds like it could be a valid termination condition"... I mean that if someone is writing a test-case or is reading someone else's tes

Jenkins build is back to normal : brooklyn-master-build #340

2016-07-29 Thread Apache Jenkins Server
See

Build failed in Jenkins: brooklyn-master-windows #222

2016-07-29 Thread Apache Jenkins Server
See -- [...truncated 41122 lines...] [INFO] Brooklyn Launcher .. FAILURE [01:21 min] [INFO] Brooklyn Command Line Interface SKIPPED [INFO] Brook

[GitHub] brooklyn-dist issue #37: Generate ssh keys for the brooklyn host

2016-07-29 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-dist/pull/37 Good idea, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] brooklyn-dist pull request #37: Generate ssh keys for the brooklyn host

2016-07-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-dist/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Build failed in Jenkins: brooklyn-dist-master #27

2016-07-29 Thread Apache Jenkins Server
See Changes: [github] Generate ssh keys for the brooklyn host [github] Update servers.yaml -- [...truncated 257 lines...] [INFO] --- maven-enforcer-plugin:1.4.1:enforce (brooklyn-build-req) @

[GitHub] brooklyn-server pull request #281: Prevent VanillaSoftwareProcess commands f...

2016-07-29 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/281#discussion_r72848780 --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcess.java --- @@ -241,6 +246,7 @@ @SetFromFlag("ru

[GitHub] brooklyn-server pull request #280: Add special flag decoration to parameters...

2016-07-29 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/280#discussion_r72853888 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynEntityDecorationResolver.java --- @@ -180,20 +182,2

[GitHub] brooklyn-server issue #280: Add special flag decoration to parameters to ena...

2016-07-29 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/280 From reading the sources my understanding is that this allows parameters to have specs as default values. Something that is a common pattern in the java blueprints. Nice idea. LGTM, but a

Build failed in Jenkins: brooklyn-master-build #341

2016-07-29 Thread Apache Jenkins Server
See -- [...truncated 50403 lines...] [JENKINS] Archiving