[GitHub] brooklyn-client issue #42: Improve login handling.

2017-07-13 Thread robertgmoss
Github user robertgmoss commented on the issue: https://github.com/apache/brooklyn-client/pull/42 Thanks @geomacy LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-client issue #42: Improve login handling.

2017-07-13 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-client/pull/42 Alternatively open a separate pull request for the `logout` command. It's tangential to the rest of the PR, which is ready to merge. --- If your project is set up for it, you can reply to

[GitHub] brooklyn-client issue #42: Improve login handling.

2017-07-13 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-client/pull/42 @geomacy I was right on the cusp of merging this when I realised that logging out means you can't view help text: ``` $ br version 0.12.0-SNAPSHOT $ br NAME: br

[GitHub] brooklyn-server issue #762: Remove a bit of code duplication.

2017-07-13 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/762 @aledsage could you have a look at this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-server pull request #762: Remove a bit of code duplication.

2017-07-13 Thread geomacy
GitHub user geomacy opened a pull request: https://github.com/apache/brooklyn-server/pull/762 Remove a bit of code duplication. Small follow-up to https://github.com/apache/brooklyn-server/pull/734. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] brooklyn-server pull request #761: Async entities

2017-07-13 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/761#discussion_r127176140 --- Diff: core/src/main/java/org/apache/brooklyn/entity/stock/AsyncApplicationImpl.java --- @@ -0,0 +1,473 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #761: Async entities

2017-07-13 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/761#discussion_r127177524 --- Diff: core/src/main/java/org/apache/brooklyn/entity/stock/AsyncApplicationImpl.java --- @@ -0,0 +1,473 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #734: Support ConfigKey deprecated names

2017-07-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/734 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #734: Support ConfigKey deprecated names

2017-07-13 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/734 Going to merge this, should have done so before now, sorry! Any further changes can be done as separate PRs. --- If your project is set up for it, you can reply to this email and have your

[GitHub] brooklyn-server pull request #761: Async entities

2017-07-13 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/761 Async entities Adds `AsyncApplication`: An app that starts up asynchronously. Calling start will call start on its children, but it does not expect the children to have started by the