[GitHub] brooklyn-server issue #765: REST API returns plane-id

2017-07-17 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/765 :+1: somehow I've been viewing only the first commit. All good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] brooklyn-server issue #765: REST API returns plane-id

2017-07-17 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/765 @neykov not sure what you mean. The second commit adds it to `/ha/states`, at the top-level as `planeId`. In that response, it doesn't repeat the planeId in the `nodes` map (alongside `node

[GitHub] brooklyn-server pull request #765: REST API returns plane-id

2017-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/765 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles

2017-07-17 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/746#discussion_r127717510 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiArchiveInstaller.java --- @@ -336,14 +358,14 @@ private synchronized void close()

Re: Config keys with values that are entities

2017-07-17 Thread Richard Downer
Thanks Duncan. That bit of the blueprint is working well - the server cluster is able to come up normally, the first member being the bootstrap server, and subsequent members able to detect the first and automatically join the cluster, through the chained attributeWhenReady calls that you noticed.

[GitHub] brooklyn-server issue #765: REST API returns plane-id

2017-07-17 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/765 Is it worth adding it to `/ha/states` as well, along `nodeId`? LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] brooklyn-server pull request #765: REST API returns plane-id

2017-07-17 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/765 REST API returns plane-id This is useful for systems that use/manage Brooklyn - they want to know the stable id of that Brooklyn server, which will be the same after restarts or after HA

[jira] [Commented] (BROOKLYN-463) Improve CLI login feedback

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089720#comment-16089720 ] ASF GitHub Bot commented on BROOKLYN-463: - Github user asfgit closed the pull re

[GitHub] brooklyn-client issue #42: Improve login handling.

2017-07-17 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-client/pull/42 ok thanks @sjcorbett --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] brooklyn-client pull request #42: Improve login handling.

2017-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-client/pull/42 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-client issue #42: Improve login handling.

2017-07-17 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-client/pull/42 Thanks @geomacy. Will merge this. Printing usage when someone writes `br --skipSslChecks` or `br --json` can be a future improvement. --- If your project is set up for it, you can reply to

Re: Config keys with values that are entities

2017-07-17 Thread Duncan Grant
Richard, I haven't quite got my head round what you're doing but I did notice that you were chaining attributeWhenReady calls https://github.com/rdowner/brooklyn-consul/blob/master/catalog/consul/consul-server-cluster.bom#L50 which I don't think you can do as attributeWhenReady returns a BrooklynD

[GitHub] brooklyn-client issue #42: Improve login handling.

2017-07-17 Thread sjcorbett
Github user sjcorbett commented on the issue: https://github.com/apache/brooklyn-client/pull/42 `requiresLogin` should check that the command isn't `help`. It also needs to handle invocations of the program that set global options but don't give a command. I think that of the options

Re: Config keys with values that are entities

2017-07-17 Thread Richard Downer
Thanks Alex. Your blueprint is similar to mine, although consul.server in my case is taken from the cluster.first.entity sensor of a DynamicCluster. I've uploaded my code to https://github.com/rdowner/brooklyn-consul - can you spot anything odd there? Thanks Richard. On 17 July 2017 at 10:58, Ale

[GitHub] brooklyn-docs pull request #203: Add first addition to Aggregator

2017-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-docs/pull/203 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-docs issue #203: Add first addition to Aggregator

2017-07-17 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-docs/pull/203 LGTM; merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

Jenkins build is back to normal : brooklyn-server-master #662

2017-07-17 Thread Apache Jenkins Server
See

[GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles

2017-07-17 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/746#discussion_r127677290 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiArchiveInstaller.java --- @@ -336,14 +358,14 @@ private synchronized void close(

[GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles

2017-07-17 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/746#discussion_r127676219 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiArchiveInstaller.java --- @@ -308,11 +326,16 @@ private synchronized void close(

[GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles

2017-07-17 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/746#discussion_r127675863 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiArchiveInstaller.java --- @@ -371,23 +394,36 @@ public void run() {

[GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles

2017-07-17 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/746#discussion_r127675551 --- Diff: core/src/main/java/org/apache/brooklyn/core/location/BasicLocationRegistry.java --- @@ -194,29 +168,71 @@ public boolean registerResolve

[GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles

2017-07-17 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/746#discussion_r127675561 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogItemDtoAbstract.java --- @@ -386,7 +387,7 @@ protected void setTags(

[GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles

2017-07-17 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/746#discussion_r127675345 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiManager.java --- @@ -372,33 +376,46 @@ public synchronized Bundle registerBundle

[GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles

2017-07-17 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/746#discussion_r127675292 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBomScanner.java --- @@ -1,130 +0,0 @@ -/* --- End diff --

[GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles

2017-07-17 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/746#discussion_r127675195 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBundleLoader.java --- @@ -81,22 +91,54 @@ public CatalogBundleLoader

[GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles

2017-07-17 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/746#discussion_r127674921 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBundleLoader.java --- @@ -64,14 +62,26 @@ public CatalogBundleLoader

[GitHub] brooklyn-server pull request #746: Auto wrap YAML BOMs as catalog bundles

2017-07-17 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/746#discussion_r127674944 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBundleLoader.java --- @@ -81,22 +91,54 @@ public CatalogBundleLoader

Re: Config keys with values that are entities

2017-07-17 Thread Alex Heneveld
Hi Richard- What you're doing looks fine. Maybe something is wrong with the "consul.serverReference" value, or there is a bug around special treatment of parameters. The blueprint below shows what I think you're doing, several ways, and all work, both in bash and in the config view (IE ful

[GitHub] brooklyn-client issue #42: Improve login handling.

2017-07-17 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-client/pull/42 @sjcorbett et al is this ok to merge now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] brooklyn-server pull request #763: Add 'first' to aggregator

2017-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/763 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] brooklyn-server issue #763: Add 'first' to aggregator

2017-07-17 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/763 I've added a PR to change the docs to match this [here](https://github.com/apache/brooklyn-docs/pull/203). --- If your project is set up for it, you can reply to this email and have your

[GitHub] brooklyn-docs pull request #203: Add first addition to Aggregator

2017-07-17 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-docs/pull/203 Add first addition to Aggregator Changes docs to match brooklyn-server#763 You can merge this pull request into a Git repository by running: $ git pull https://github.com/drigodwin/bro

Config keys with values that are entities

2017-07-17 Thread Richard Downer
Hello all. I have a catalog item for an entity type. This has a number of parameters, including one parameter which is intended to hold a reference to an entity. This works fine; I can see in the "config" pane of the entity this: consul.serverReference Consul Server (bootstrap) What I want to do

[GitHub] brooklyn-server pull request #764: Fixes tested response from /server/user

2017-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/764 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Build failed in Jenkins: brooklyn-master-build #1154

2017-07-17 Thread Apache Jenkins Server
See -- [...truncated 8.62 MB...] [INFO] Building conffiles [INFO] Adding conffile: etc/brooklyn/brooklyn.conf [INFO] Adding conffile: etc/brooklyn/logback.xml [INFO] Creating changes