Build failed in Jenkins: brooklyn-library-master #458

2017-10-13 Thread Apache Jenkins Server
See -- [...truncated 533.84 KB...] Uploaded: https://repository.apache.org/content/repositories/snapshots/org/apache/brooklyn/brooklyn-library-features/1.0.0-SNAPSHOT/brooklyn-libr

[GitHub] brooklyn-server pull request #859: Delete old deprecated code

2017-10-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/859#discussion_r144663987 --- Diff: core/src/main/java/org/apache/brooklyn/util/core/osgi/BundleMaker.java --- @@ -110,8 +110,6 @@ public File createJarFromClasspathDir(Strin

[GitHub] brooklyn-server pull request #859: Delete old deprecated code

2017-10-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/859#discussion_r144589344 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogUtils.java --- @@ -112,8 +112,8 @@ public static BrooklynClassLoading

[GitHub] brooklyn-server pull request #859: Delete old deprecated code

2017-10-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/859#discussion_r144662878 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/EntityPredicates.java --- @@ -488,11 +482,6 @@ public String toString() {

[GitHub] brooklyn-server pull request #859: Delete old deprecated code

2017-10-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/859#discussion_r144662800 --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/EntityPredicates.java --- @@ -454,12 +454,6 @@ public String toString() {

[GitHub] brooklyn-server pull request #859: Delete old deprecated code

2017-10-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/859#discussion_r144588755 --- Diff: api/src/main/java/org/apache/brooklyn/api/location/Location.java --- @@ -89,29 +86,6 @@ boolean containsLocation(Location potenti

Jenkins build is back to normal : brooklyn-master-build #1271

2017-10-13 Thread Apache Jenkins Server
See

[GitHub] brooklyn-library pull request #135: Delete old deprecated code

2017-10-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-library/pull/135 ---

[GitHub] brooklyn-library issue #135: Delete old deprecated code

2017-10-13 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-library/pull/135 LGTM, thanks @aledsage 👍 ---

Build failed in Jenkins: brooklyn-server-master #768

2017-10-13 Thread Apache Jenkins Server
See Changes: [duncan.grant] Fix npr when reading streamed bundle -- [...truncated 8.27 MB...] Uploaded: https://repository.apache.org/content/repositories/snapshots/

[GitHub] brooklyn-server pull request #862: Fix npr when reading streamed bundle

2017-10-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/862 ---

[GitHub] brooklyn-server issue #862: Fix npr when reading streamed bundle

2017-10-13 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-server/pull/862 retest this please ---

[GitHub] brooklyn-server issue #862: Fix npr when reading streamed bundle

2017-10-13 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/862 LGTM. For the record, we hit a NullPointerException when there was already a bundle added to karaf (via the initial feature.xml), which we then tried to add to the catalog via `br

[GitHub] brooklyn-server pull request #856: [WIP] clean up startup logging around cat...

2017-10-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/856#discussion_r144536427 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBundleLoader.java --- @@ -128,10 +128,12 @@ private TemporaryInternal

[GitHub] brooklyn-server pull request #856: [WIP] clean up startup logging around cat...

2017-10-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/856#discussion_r144536439 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBundleLoader.java --- @@ -143,6 +145,13 @@ public void removeFromCata

[GitHub] brooklyn-server pull request #862: Fix npr when reading streamed bundle

2017-10-13 Thread duncangrant
GitHub user duncangrant opened a pull request: https://github.com/apache/brooklyn-server/pull/862 Fix npr when reading streamed bundle This happens when there is an existing unmanaged bundle with the same id and a replacement bundle is uploaded without the force flag Tes

Re: [PROPOSAL] Split Brooklyn website and documentation

2017-10-13 Thread Thomas Bouron
Hi Alex, all. For the past few days, I worked with Richard on this doc spike. Here is a short summary of what we have done: - add collapse/expandable sections on the left menu - add documentation versioning (version dropdown, top left) - improve PDF output - fix all internal links - use brooklyn s

[jira] [Commented] (BROOKLYN-525) Sensor change events fired out of order

2017-10-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16203334#comment-16203334 ] ASF GitHub Bot commented on BROOKLYN-525: - Github user neykov commented on the i

[GitHub] brooklyn-server issue #860: improve locking for sensor values

2017-10-13 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/860 Seems this fixes [BROOKLYN-525](https://issues.apache.org/jira/browse/BROOKLYN-525) as well. Worth checking by enabling the corresponding tests as done in https://github.com/apache/brookl