Build failed in Jenkins: brooklyn-master-build-docker #1045

2018-11-23 Thread Apache Jenkins Server
See -- [...truncated 50.28 MB...] Downloading from central: https://repo.maven.apache.org/maven2/org/eclipse/aether/aether-api/1.0.2.v20150114/aether-api-1.0.2.v20150114.jar

[GitHub] brooklyn-server issue #1014: [WIP] Subtype setting config val: use as key’...

2018-11-23 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/1014 I like this idea but the test failures highlight an edge cases that need some thinking. `BasicConfigKeyOverwriting` has different resolution semantics to some of the structured ke

Build failed in Jenkins: brooklyn-master-build-docker-pipeline #67

2018-11-23 Thread Apache Jenkins Server
See -- [...truncated 49.19 MB...] Progress (1): 2.2/2.7 kBProgress (1): 2.7 kBDownloaded from central: https://repo.maven.apache.org/maven2/o

Build failed in Jenkins: brooklyn-dist-master-docker #135

2018-11-23 Thread Apache Jenkins Server
See -- [...truncated 4.45 MB...] [INFO] Transformer{uniqueTag=service.isUp if no service.notUp.indicators, running=true, entity=TestEffectorImpl{id=dr4pklocd4}, id=

[GitHub] brooklyn-ui issue #112: DSL editor: support referencing `brooklyn.parameters...

2018-11-23 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-ui/pull/112 one fix needed @aledsage ---

[GitHub] brooklyn-ui pull request #112: DSL editor: support referencing `brooklyn.par...

2018-11-23 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/112#discussion_r235936483 --- Diff: ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js --- @@ -512,6 +514,16 @@ function BlueprintService($log

[GitHub] brooklyn-ui pull request #112: DSL editor: support referencing `brooklyn.par...

2018-11-23 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/112#discussion_r235935687 --- Diff: ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js --- @@ -512,6 +514,16 @@ function BlueprintService($log

[GitHub] brooklyn-server issue #1003: Update IPTables save method

2018-11-23 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/1003 as @aledsage this is largely included in #1006 . @frogfather your call whether there is value in the recent comments here and if so update this PR, make sure to `git merge master` in to t

[GitHub] brooklyn-server pull request #1003: Update IPTables save method

2018-11-23 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/1003#discussion_r235932933 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/ssh/IptablesCommands.java --- @@ -130,8 +131,9 @@ public static String firewalldSer

[GitHub] brooklyn-ui pull request #112: DSL editor: support referencing `brooklyn.par...

2018-11-23 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/112#discussion_r235930249 --- Diff: ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js --- @@ -512,6 +514,16 @@ function BlueprintService($log,

[GitHub] brooklyn-ui issue #112: DSL editor: support referencing `brooklyn.parameters...

2018-11-23 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-ui/pull/112 great work - good to merge, comment explaining `addUnlisted` can be a separate PR ---

[GitHub] brooklyn-ui pull request #112: DSL editor: support referencing `brooklyn.par...

2018-11-23 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/112#discussion_r235929789 --- Diff: ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js --- @@ -512,6 +514,16 @@ function BlueprintService($log

[GitHub] brooklyn-ui pull request #113: Fix template overrides - decorate `script` di...

2018-11-23 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/113#discussion_r235925594 --- Diff: ui-modules/utils/script-tag-non-overwrite/script-tag-non-overwrite.js --- @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] brooklyn-ui pull request #113: Fix template overrides - decorate `script` di...

2018-11-23 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/113#discussion_r235922436 --- Diff: ui-modules/utils/script-tag-non-overwrite/script-tag-non-overwrite.js --- @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] brooklyn-ui pull request #113: Fix template overrides - decorate `script` di...

2018-11-23 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/113#discussion_r235917516 --- Diff: ui-modules/utils/script-tag-non-overwrite/script-tag-non-overwrite.js --- @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] brooklyn-ui pull request #113: Fix template overrides - decorate `script` di...

2018-11-23 Thread ahgittin
Github user ahgittin commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/113#discussion_r235916351 --- Diff: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js --- @@ -79,7 +82,7 @@ export function specEditorDirective(

[GitHub] brooklyn-ui pull request #113: Fix template overrides - decorate `script` di...

2018-11-23 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/113#discussion_r235904114 --- Diff: ui-modules/utils/script-tag-non-overwrite/script-tag-non-overwrite.js --- @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] brooklyn-ui pull request #113: Fix template overrides - decorate `script` di...

2018-11-23 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/brooklyn-ui/pull/113#discussion_r235903512 --- Diff: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js --- @@ -79,7 +82,7 @@ export function specEditorDirective($

[GitHub] brooklyn-ui issue #113: Fix template overrides - decorate `script` directive...

2018-11-23 Thread sferot
Github user sferot commented on the issue: https://github.com/apache/brooklyn-ui/pull/113 It works fine for me :+1: ---