[GitHub] [brooklyn-ui] jathanasiou commented on a change in pull request #228: Feature/node management UI

jathanasiou commented on a change in pull request #228: URL: https://github.com/apache/brooklyn-ui/pull/228#discussion_r669831667 ## File path: ui-modules/home/app/views/about/about.controller.js ## @@ -55,17 +61,141 @@ export function aboutStateConfig($stateProvider) { $s

[GitHub] [brooklyn-ui] jathanasiou commented on a change in pull request #228: Feature/node management UI

jathanasiou commented on a change in pull request #228: URL: https://github.com/apache/brooklyn-ui/pull/228#discussion_r669837685 ## File path: ui-modules/home/app/views/about/about.controller.js ## @@ -55,17 +61,141 @@ export function aboutStateConfig($stateProvider) { $s

[GitHub] [brooklyn-ui] jathanasiou commented on a change in pull request #228: Feature/node management UI

jathanasiou commented on a change in pull request #228: URL: https://github.com/apache/brooklyn-ui/pull/228#discussion_r669833866 ## File path: ui-modules/home/app/views/about/about.controller.js ## @@ -55,17 +61,141 @@ export function aboutStateConfig($stateProvider) { $s

[GitHub] [brooklyn-ui] jathanasiou commented on a change in pull request #228: Feature/node management UI

jathanasiou commented on a change in pull request #228: URL: https://github.com/apache/brooklyn-ui/pull/228#discussion_r669831667 ## File path: ui-modules/home/app/views/about/about.controller.js ## @@ -55,17 +61,141 @@ export function aboutStateConfig($stateProvider) { $s

[GitHub] [brooklyn-server] zan-mateusz opened a new pull request #1201: revert for undesired changes - persistence export feature

zan-mateusz opened a new pull request #1201: URL: https://github.com/apache/brooklyn-server/pull/1201 Reverting changes of PR: https://github.com/apache/brooklyn-server/pull/1191 Due to change in solution design, these changes are no longer necessary and should be removed -- This

Build failed in Jenkins: Brooklyn » Brooklyn » master #247

See Changes: -- [...truncated 78748 lines...] at org.testng.junit.JUnit4TestRunner.start(JUnit4TestRunner.java:80) at org.testng.junit.JUnit4TestRunne

[GitHub] [brooklyn-server] tbouron commented on a change in pull request #1200: Add support setup default initializers for all deployment

tbouron commented on a change in pull request #1200: URL: https://github.com/apache/brooklyn-server/pull/1200#discussion_r669684607 ## File path: core/src/main/java/org/apache/brooklyn/core/objs/proxy/InternalEntityFactory.java ## @@ -465,12 +487,30 @@ public void run() {

[GitHub] [brooklyn-server] tbouron commented on pull request #1200: Add support setup default initializers for all deployment

tbouron commented on pull request #1200: URL: https://github.com/apache/brooklyn-server/pull/1200#issuecomment-879955713 @ahgittin That should be all your comments addressed now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [brooklyn-server] ahgittin commented on pull request #1200: Add support setup default initializers for all deployment

ahgittin commented on pull request #1200: URL: https://github.com/apache/brooklyn-server/pull/1200#issuecomment-879941899 pleased to see our test coverage caught the problem w initializers being run twice! -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [brooklyn-dist] ahgittin commented on pull request #174: Add support setup default initializers for all deployment

ahgittin commented on pull request #174: URL: https://github.com/apache/brooklyn-dist/pull/174#issuecomment-879936206 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [brooklyn-server] ahgittin commented on pull request #1200: Add support setup default initializers for all deployment

ahgittin commented on pull request #1200: URL: https://github.com/apache/brooklyn-server/pull/1200#issuecomment-879936074 looks good - a few minor comments, then can merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [brooklyn-server] ahgittin commented on a change in pull request #1200: Add support setup default initializers for all deployment

ahgittin commented on a change in pull request #1200: URL: https://github.com/apache/brooklyn-server/pull/1200#discussion_r669662325 ## File path: core/src/main/java/org/apache/brooklyn/core/objs/proxy/InternalEntityFactory.java ## @@ -369,6 +385,12 @@ public void run() {

[GitHub] [brooklyn-server] ahgittin commented on a change in pull request #1200: Add support setup default initializers for all deployment

ahgittin commented on a change in pull request #1200: URL: https://github.com/apache/brooklyn-server/pull/1200#discussion_r669661064 ## File path: core/src/main/java/org/apache/brooklyn/core/objs/proxy/InternalEntityFactory.java ## @@ -46,46 +48,60 @@ import org.apache.brookl

[GitHub] [brooklyn-server] ahgittin commented on a change in pull request #1200: Add support setup default initializers for all deployment

ahgittin commented on a change in pull request #1200: URL: https://github.com/apache/brooklyn-server/pull/1200#discussion_r669660476 ## File path: core/src/main/java/org/apache/brooklyn/core/objs/proxy/InternalEntityFactory.java ## @@ -465,12 +487,30 @@ public void run() {

[GitHub] [brooklyn-server] tbouron commented on a change in pull request #1200: Add support setup default initializers for all deployment

tbouron commented on a change in pull request #1200: URL: https://github.com/apache/brooklyn-server/pull/1200#discussion_r669655451 ## File path: core/src/main/java/org/apache/brooklyn/core/objs/proxy/InternalEntityFactory.java ## @@ -46,46 +48,60 @@ import org.apache.brookly

[GitHub] [brooklyn-server] tbouron commented on a change in pull request #1200: Add support setup default initializers for all deployment

tbouron commented on a change in pull request #1200: URL: https://github.com/apache/brooklyn-server/pull/1200#discussion_r669652985 ## File path: core/src/main/java/org/apache/brooklyn/core/objs/proxy/InternalEntityFactory.java ## @@ -369,6 +385,12 @@ public void run() {

[GitHub] [brooklyn-server] ahgittin commented on a change in pull request #1200: Add support setup default initializers for all deployment

ahgittin commented on a change in pull request #1200: URL: https://github.com/apache/brooklyn-server/pull/1200#discussion_r669651471 ## File path: core/src/main/java/org/apache/brooklyn/core/objs/proxy/InternalEntityFactory.java ## @@ -465,12 +487,30 @@ public void run() {

[GitHub] [brooklyn-server] ahgittin commented on a change in pull request #1200: Add support setup default initializers for all deployment

ahgittin commented on a change in pull request #1200: URL: https://github.com/apache/brooklyn-server/pull/1200#discussion_r669649982 ## File path: core/src/main/java/org/apache/brooklyn/core/objs/proxy/InternalEntityFactory.java ## @@ -46,46 +48,60 @@ import org.apache.brookl

[GitHub] [brooklyn-server] ahgittin commented on a change in pull request #1200: Add support setup default initializers for all deployment

ahgittin commented on a change in pull request #1200: URL: https://github.com/apache/brooklyn-server/pull/1200#discussion_r669647198 ## File path: core/src/main/java/org/apache/brooklyn/core/objs/proxy/InternalEntityFactory.java ## @@ -369,6 +385,12 @@ public void run() {

[GitHub] [brooklyn-server] ahgittin commented on pull request #1199: fix/secure-vault-values

ahgittin commented on pull request #1199: URL: https://github.com/apache/brooklyn-server/pull/1199#issuecomment-879916381 great - added one more commit tidying up the treatment of `raw` -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [brooklyn-ui] ahgittin commented on pull request #246: Fix/secure vault values

ahgittin commented on pull request #246: URL: https://github.com/apache/brooklyn-ui/pull/246#issuecomment-879916053 LGTM - will close #247 if this doesn't do so automatically -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [brooklyn-ui] asfgit closed pull request #246: Fix/secure vault values

asfgit closed pull request #246: URL: https://github.com/apache/brooklyn-ui/pull/246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr.

[GitHub] [brooklyn-ui] asfgit merged pull request #247: allow inspector to enable resolving or not resolving the config

asfgit merged pull request #247: URL: https://github.com/apache/brooklyn-ui/pull/247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr.

[GitHub] [brooklyn-server] asfgit closed pull request #1199: fix/secure-vault-values

asfgit closed pull request #1199: URL: https://github.com/apache/brooklyn-server/pull/1199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-uns

[GitHub] [brooklyn-ui] iuliana edited a comment on pull request #246: Fix/secure vault values

iuliana edited a comment on pull request #246: URL: https://github.com/apache/brooklyn-ui/pull/246#issuecomment-879898104 @ahgittin changes from https://github.com/apache/brooklyn-ui/pull/247 have been added here. The PR was made to master. The changes might have broken the build, so I cho

[GitHub] [brooklyn-ui] iuliana commented on pull request #246: Fix/secure vault values

iuliana commented on pull request #246: URL: https://github.com/apache/brooklyn-ui/pull/246#issuecomment-879898104 @ahgittin changes from https://github.com/apache/brooklyn-ui/pull/247 have been added here. The PR was made to master. The changes broke the build, so I could not merge it. So

[GitHub] [brooklyn-dist] tbouron opened a new pull request #174: Add support setup default initializers for all deployment

tbouron opened a new pull request #174: URL: https://github.com/apache/brooklyn-dist/pull/174 This looks up a new configuration options called `brooklyn.deployment.initializers` (comma separated list). If specified on a Brooklyn instance, all deployments will load and execute these initial

[GitHub] [brooklyn-server] tbouron opened a new pull request #1200: Add support setup default initializers for all deployment

tbouron opened a new pull request #1200: URL: https://github.com/apache/brooklyn-server/pull/1200 This looks up a new configuration options called `brooklyn.deployment.initializers` (comma separated list). If specified on a Brooklyn instance, all deployments will load and execute these ini

[GitHub] [brooklyn-server] algairim commented on a change in pull request #1184: code for functionality to remove a particular node from persistence via API

algairim commented on a change in pull request #1184: URL: https://github.com/apache/brooklyn-server/pull/1184#discussion_r669537927 ## File path: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/HighAvailabilityManagerImpl.java ## @@ -1004,6 +1019,15 @@ public ManagementPl

[GitHub] [brooklyn-server] algairim commented on a change in pull request #1184: code for functionality to remove a particular node from persistence via API

algairim commented on a change in pull request #1184: URL: https://github.com/apache/brooklyn-server/pull/1184#discussion_r669536725 ## File path: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/HighAvailabilityManagerImpl.java ## @@ -1072,6 +1081,26 @@ private ManagementP

[GitHub] [brooklyn-server] algairim commented on a change in pull request #1184: code for functionality to remove a particular node from persistence via API

algairim commented on a change in pull request #1184: URL: https://github.com/apache/brooklyn-server/pull/1184#discussion_r669527429 ## File path: core/src/main/java/org/apache/brooklyn/core/mgmt/ha/HighAvailabilityManagerImpl.java ## @@ -1072,6 +1081,26 @@ private ManagementP

[GitHub] [brooklyn-server] algairim commented on a change in pull request #1184: code for functionality to remove a particular node from persistence via API

algairim commented on a change in pull request #1184: URL: https://github.com/apache/brooklyn-server/pull/1184#discussion_r669457493 ## File path: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/ServerResource.java ## @@ -476,6 +477,16 @@ public Response c

[GitHub] [brooklyn-ui] iuliana commented on a change in pull request #247: allow inspector to enable resolving or not resolving the config

iuliana commented on a change in pull request #247: URL: https://github.com/apache/brooklyn-ui/pull/247#discussion_r669421974 ## File path: ui-modules/app-inspector/app/components/providers/entity-api.provider.js ## @@ -78,8 +78,9 @@ function EntityApi($http, $q) { functi

[GitHub] [brooklyn-ui] algairim commented on a change in pull request #228: Feature/node management UI

algairim commented on a change in pull request #228: URL: https://github.com/apache/brooklyn-ui/pull/228#discussion_r669411582 ## File path: ui-modules/home/app/views/about/about.template.html ## @@ -54,29 +54,71 @@ Brooklyn Server -

[GitHub] [brooklyn-ui] jathanasiou commented on a change in pull request #247: allow inspector to enable resolving or not resolving the config

jathanasiou commented on a change in pull request #247: URL: https://github.com/apache/brooklyn-ui/pull/247#discussion_r669400445 ## File path: ui-modules/app-inspector/app/components/providers/entity-api.provider.js ## @@ -78,8 +78,9 @@ function EntityApi($http, $q) { fu

[GitHub] [brooklyn-ui] iuliana commented on a change in pull request #247: allow inspector to enable resolving or not resolving the config

iuliana commented on a change in pull request #247: URL: https://github.com/apache/brooklyn-ui/pull/247#discussion_r669385885 ## File path: ui-modules/app-inspector/app/components/providers/entity-api.provider.js ## @@ -78,8 +78,9 @@ function EntityApi($http, $q) { functi