Github user CMoH closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1140
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user CMoH closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user CMoH commented on the pull request:
https://github.com/apache/brooklyn-server/pull/65#issuecomment-197428459
Well, my comment on `ServiceTracker` was about completing the list of
alternatives, not about the current solution - which I think works just fine
for the intended
Github user CMoH commented on the pull request:
https://github.com/apache/brooklyn-server/pull/65#issuecomment-197356327
I haven't tested it, but it looks like it would work.
One comment though: when calling `BundleContext.getService()` the reference
count for the servi
Github user CMoH commented on the pull request:
https://github.com/apache/brooklyn-server/pull/65#issuecomment-197368109
Forgot to mention the use of `ServiceTracker` - which is the preferred
alternative to using `ServiceReference`s, but someone reminded me.
---
If your project is
Github user CMoH commented on the pull request:
https://github.com/apache/brooklyn-ui/pull/11#issuecomment-193964032
I switched to using `startsWith`. Thanks for the tip
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user CMoH commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1182#issuecomment-181894195
I also agree transporting the changes as a single patch onto the new repos.
---
If your project is set up for it, you can reply to this email and have your
Github user CMoH commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1182#issuecomment-181638368
@neykov When finishing up I ran into the same problem with the
DefaultExceptionMapper as in #1140. Do you know anything about that?
```
[ERROR
GitHub user CMoH opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1182
[WIP] Rebase of PR #1140 onto incubator-brooklyn master
This is a rebase of #1140 onto incubator-brooklyn's master with the purpose
of applying the changes onto the new repos
Github user CMoH commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1140#issuecomment-181469498
@neykov I'm having the following issues doing an ```mvn clean install```:
```
ERROR] Failed to execute goal
org.apache.maven.plugins:
Github user CMoH commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1177#issuecomment-181414480
@neykov There are two possible ways I know of here: one is using the
```karaf:verify``` goal of ```karaf-maven-plugin```. However, I've tested thi
Github user CMoH commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1177#discussion_r51266731
--- Diff: brooklyn-server/karaf/features/src/main/history/dependencies.xml
---
@@ -0,0 +1,103 @@
+
--- End diff --
I have removed
Github user CMoH commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1177#issuecomment-176781901
Feel free to merge before #1140. That PR already has merge conflicts, that
will more time to resolve anyway. I think there's no point holding this ba
Github user CMoH commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1140#issuecomment-175296609
@neykov I have applied your changes here, and with some minor changes the
default maven build succeeds. However, running ```mvn clean install
-Djax-rs-2.0
Github user CMoH commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1140#issuecomment-172400924
On point 4: the bad news is that Jersey-1.19 cannot use
```javax.ws.rs-api.jar``` because it throws a
```java.lang.AbstractMethodError``` when using the
Github user CMoH commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1152#issuecomment-172399903
Tested OK. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user CMoH commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1140#issuecomment-172388216
@andreaturli It seems the duplication of the rest-api is already proven a
bad idea by the fact that you are working only on a copy of it. I hope that I
can
Github user CMoH commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1140#issuecomment-171728832
@neykov Thanks for taking the time to review this (rather large) PR.
I have tried to keep changes out of ```rest-api```, and now I'm trying to
f
Github user CMoH commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-171006809
See #1139 for a solution for dependencies.xml
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user CMoH opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1140
[WIP] CXF implementation of rest api
I've worked on a separate REST API project for Brooklyn using CXF, since
changing the current brooklyn-rest-server in a manner that's compa
GitHub user CMoH opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1139
Remove karaf-features auto-generated dependencies.xml
May be re-enabled in the future if its purpose is necessary, but for now
it's more of a headache.
You can merge this pull re
Github user CMoH commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1127#issuecomment-170968512
@sjcorbett @ahgittin Yes, the ```dependencies''' file is generated for
dependency control across versions. I think for now is not useful and
22 matches
Mail list logo
