[GitHub] brooklyn-library issue #134: Add Apache ActiveMQ Artemis catalog item

2017-12-21 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-library/pull/134 Thanks for the reminder @tbouron . Addressed comments. Feel free to edit my PR if you have more comments. ---

[GitHub] brooklyn-server pull request #911: Different fix for entity spec mutated bug...

2017-12-06 Thread bostko
Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/911#discussion_r155337371 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynComponentTemplateResolver.java --- @@ -509,13

[GitHub] brooklyn-server pull request #907: BROOKLYN-567 Prevent mutating EntitySpecS...

2017-12-03 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-server/pull/907 BROOKLYN-567 Prevent mutating EntitySpecSupplier's flag field I believe this fixes the issue. Glad to do a little Sunday hiking in Apache Brooklyn. You can merge this pull request

[GitHub] brooklyn-docs pull request #236: Refer to inheritance.runtime instead of dep...

2017-11-14 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-docs/pull/236 Refer to inheritance.runtime instead of deprecated inheritance.runtime Some useful change which was sitting for sometime in my workspace. You can merge this pull request into a Git repository

Re: [PROPOSAL] Deprecate @SetFromFlag

2017-10-09 Thread bostko
Hi, I'd like to address one more glitch which I think is not discussed. Setting a config for VanillaSoftwareProcess type which is be predefined for that type could cause confusion. For example [1] using brooklyn.config: - version is set to the install.version config - downloadUrl is set to the

[GitHub] brooklyn-library pull request #134: Add Apache ActiveMQ Artemis catalog item

2017-10-09 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-library/pull/134 Add Apache ActiveMQ Artemis catalog item Catalog item is visible in Apache Brooklyn karaf build BROOKLYN-541 You can merge this pull request into a Git repository by running

[GitHub] brooklyn-docs pull request #132: Using Bundle-SymbolicName in Catalog

2017-08-14 Thread bostko
Github user bostko closed the pull request at: https://github.com/apache/brooklyn-docs/pull/132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-docs issue #132: Using Bundle-SymbolicName in Catalog

2017-08-14 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-docs/pull/132 Bundle-Symbolic name should be discouraged. PR is irrelevant. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] brooklyn-server pull request #757: [WIP] BROOKLYN-519 no BasicSpecParameter ...

2017-08-14 Thread bostko
Github user bostko closed the pull request at: https://github.com/apache/brooklyn-server/pull/757 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #757: [WIP] BROOKLYN-519 no BasicSpecParameter seriali...

2017-08-14 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/757 Approach suggested on 07/07/2017 to dev@brooklyn.apache.org mailing list with subject "BROOKLYN-519 suggestion to remove BasicSpecParameter from serializing" is more suitable f

[GitHub] brooklyn-server pull request #491: (WIP) execAsync parameter for SshMachineL...

2017-08-14 Thread bostko
Github user bostko closed the pull request at: https://github.com/apache/brooklyn-server/pull/491 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #491: (WIP) execAsync parameter for SshMachineLocation...

2017-08-14 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/491 I will not use those changes. Closing for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-docs pull request #204: Fix wrong indentation in Windows Azure ARM ...

2017-08-01 Thread bostko
Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/204#discussion_r130730297 --- Diff: guide/locations/_azure-ARM.md --- @@ -158,9 +158,8 @@ brooklyn.catalog: destroyOnFailure: false templateOptions

[GitHub] brooklyn-docs pull request #204: Fix wrong indentation in Windows Azure ARM ...

2017-08-01 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-docs/pull/204 Fix wrong indentation in Windows Azure ARM config You can merge this pull request into a Git repository by running: $ git pull https://github.com/bostko/brooklyn-docs windows-azure-arm

[GitHub] brooklyn-server pull request #779: Exclude Vault headers trace log

2017-07-26 Thread bostko
Github user bostko closed the pull request at: https://github.com/apache/brooklyn-server/pull/779 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #779: Exclude Vault headers trace log

2017-07-26 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/779 Closing in favor of #780 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-server issue #780: Removes all logging of vault responses

2017-07-26 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/780 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] brooklyn-server pull request #779: Exclude Vault headers trace log

2017-07-26 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-server/pull/779 Exclude Vault headers trace log You can merge this pull request into a Git repository by running: $ git pull https://github.com/bostko/brooklyn-server exclude-headers Alternatively

[GitHub] brooklyn-server issue #775: Useful getDataAsStringMap for VaultExternalConfi...

2017-07-24 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/775 Useful when consumer of the VaultConfigSuppliler wants to have finer control over number of calls made to vault. Also this method returns Map with parameters on which a consumer can use

[GitHub] brooklyn-server pull request #775: Useful getDataAsStringMap for VaultExtern...

2017-07-22 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-server/pull/775 Useful getDataAsStringMap for VaultExternalConfigSupplier `getDataAsStringMap` allows obtaining vault data with single call. You can merge this pull request into a Git repository by running

[GitHub] brooklyn-server pull request #774: Reduce logging for Vault external config ...

2017-07-22 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-server/pull/774 Reduce logging for Vault external config supplier I consider as healthier to not log `responseBody` from vault. You can merge this pull request into a Git repository by running: $ git

[GitHub] brooklyn-server pull request #757: [WIP] BROOKLYN-519 no BasicSpecParameter ...

2017-07-07 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-server/pull/757 [WIP] BROOKLYN-519 no BasicSpecParameter serialization BasicSpecParameters are only consumed in API and no need to keep them or keep their state. - TODO rebind tests

[GitHub] brooklyn-docs issue #201: Update location structure

2017-06-23 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-docs/pull/201 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] brooklyn-docs issue #144: Configuring logging from karaf distribution of Apa...

2017-06-23 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-docs/pull/144 @tbouron I included @geomacy note. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-docs pull request #183: [For Review] Details on configuring logging...

2017-06-23 Thread bostko
Github user bostko closed the pull request at: https://github.com/apache/brooklyn-docs/pull/183 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-docs issue #183: [For Review] Details on configuring logging for OS...

2017-06-23 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-docs/pull/183 Squash changes into https://github.com/apache/brooklyn-docs/pull/144 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] brooklyn-ui pull request #46: Update maven-compiler-plugin to 3.6.1

2017-06-22 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-ui/pull/46 Update maven-compiler-plugin to 3.6.1 Related to https://github.com/apache/brooklyn-dist/pull/97 and https://github.com/apache/brooklyn-server/pull/741 You can merge this pull request into a

[GitHub] brooklyn-dist pull request #97: Update maven-compiler-plugin to 3.6.1

2017-06-22 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-dist/pull/97 Update maven-compiler-plugin to 3.6.1 Related to https://github.com/apache/brooklyn-server/pull/741 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] brooklyn-server pull request #741: Update maven-compiler-plugin to 3.6.1

2017-06-22 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-server/pull/741 Update maven-compiler-plugin to 3.6.1 I think since we upgrade java it will be useful to have later maven-compiler-plugin. If you approve this change, I will do the same PR for brooklyn

[GitHub] brooklyn-docs pull request #144: Configuring logging from karaf distribution...

2017-06-20 Thread bostko
Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/144#discussion_r123011018 --- Diff: guide/dev/tips/logging.md --- @@ -11,6 +11,10 @@ with a default configuration which just works out of the box and bindings to the other

[GitHub] brooklyn-docs pull request #156: Suggest using unique custom.machine.namer.m...

2017-06-20 Thread bostko
Github user bostko closed the pull request at: https://github.com/apache/brooklyn-docs/pull/156 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-docs issue #156: Suggest using unique custom.machine.namer.machine

2017-06-20 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-docs/pull/156 @aledsage I think problem I had was that I used machine location namer which was specifiying a constant machine name. Thus I hit an error in Azure ARM where the first problem was when jclouds

[GitHub] brooklyn-docs issue #183: [For Review] Details on configuring logging for OS...

2017-06-20 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-docs/pull/183 Any suggestions are welcome. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-docs issue #119: Opening ports for Security Group based locations

2017-06-20 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-docs/pull/119 Hi, I rebased PR and addressed Aleds' comments for `SharedLocationSecurityGroupCustomizer`. @aledsage , regarding the section talking about configuring the location, if

[GitHub] brooklyn-docs pull request #197: Point to currently supported Java 8

2017-06-14 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-docs/pull/197 Point to currently supported Java 8 Minor changes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bostko/brooklyn-docs java-8

[GitHub] brooklyn-server issue #720: Fail the build on purpose

2017-06-12 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/720 @neykov how did you verify Jenkins merges the branch to master before building? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] brooklyn-docs pull request #196: Adding docs for Windows on Azure ARM

2017-06-12 Thread bostko
Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/196#discussion_r121380456 --- Diff: guide/locations/_azure-ARM.md --- @@ -95,6 +95,88 @@ The loginUser can be anything, as long as it's specified.

[GitHub] brooklyn-server pull request #724: [BROOKLYN-516] Persist feed of WindowsPer...

2017-06-08 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-server/pull/724 [BROOKLYN-516] Persist feed of WindowsPerformanceCounterSensors initializer Also make WindowsPerformanceCounterFeed$GetPerformanceCountersJob to not throw exception when no machine is

[GitHub] brooklyn-server issue #722: [BROOKLYN-515] WindowsPerformanceCounterSensors ...

2017-06-08 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/722 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] brooklyn-server pull request #722: [BROOKLYN-515] WindowsPerformanceCounterS...

2017-06-07 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-server/pull/722 [BROOKLYN-515] WindowsPerformanceCounterSensors does not show values WindowsPerformanceCounterSensors does not show values on some deployments. You can merge this pull request into a Git

[GitHub] brooklyn-docs issue #195: Advise users to increase OS opened files limit

2017-06-07 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-docs/pull/195 @drigodwin thank you for the suggestions! I am hesitant to reword the first sentence WDYT? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-docs pull request #195: Advise users to increase OS opened files li...

2017-06-07 Thread bostko
Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/195#discussion_r120638130 --- Diff: guide/ops/troubleshooting/increase-system-resource-limits.md --- @@ -4,6 +4,16 @@ title: Increase System Resource Limits toc: /guide

[GitHub] brooklyn-docs pull request #195: Advise users to increase OS opened files li...

2017-06-07 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-docs/pull/195 Advise users to increase OS opened files limit You can merge this pull request into a Git repository by running: $ git pull https://github.com/bostko/brooklyn-docs max-files

[GitHub] brooklyn-server issue #713: Fix for BROOKLYN-510: failure with inboundPorts ...

2017-05-31 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/713 To what it will transform for the blueprint in BROOKLYN-510? Will the yaml bellow ``` inboundPorts: - 22 - 9100-9200 ``` mean `22, 9101, 9202,..., 9200

[GitHub] brooklyn-server issue #708: Getting the correct value for WinRmMachineLocati...

2017-05-30 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/708 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] brooklyn-docs pull request #190: Fix recommended OS / Java version

2017-05-23 Thread bostko
Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/190#discussion_r118036992 --- Diff: guide/ops/requirements.md --- @@ -64,14 +64,14 @@ rotation according to your organisation's policy. ## Supported Operating Sy

[GitHub] brooklyn-server pull request #690: External ip config for winrm byon locatio...

2017-05-21 Thread bostko
Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/690#discussion_r117673212 --- Diff: core/src/main/java/org/apache/brooklyn/location/byon/ByonLocationResolver.java --- @@ -152,49 +153,54 @@ protected ConfigBag

[GitHub] brooklyn-docs pull request #187: Add hint for using effector.add.openInbound...

2017-05-19 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-docs/pull/187 Add hint for using effector.add.openInboundPorts entity config You can merge this pull request into a Git repository by running: $ git pull https://github.com/bostko/brooklyn-docs ports

[GitHub] brooklyn-docs pull request #185: [Suggestion] Merge guide/dev into website/d...

2017-05-19 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-docs/pull/185 [Suggestion] Merge guide/dev into website/developers One section for all coding related matters. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] brooklyn-docs pull request #183: [For Review] Details on configuring logging...

2017-05-17 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-docs/pull/183 [For Review] Details on configuring logging for OSGi distribution I am looking for some hints which we can add in docs for logging configuration. Should we describe karaf commands in docs

[GitHub] brooklyn-server issue #682: Delete support for `--app `

2017-05-16 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/682 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] brooklyn-server issue #681: Flag allowing a Winrm4jTool to use unique contex...

2017-05-16 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/681 Thank you @neykov. I changed PR as you suggested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] brooklyn-server pull request #681: Flag allowing a Winrm4jTool to use unique...

2017-05-15 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-server/pull/681 Flag allowing a Winrm4jTool to use unique context Fixes https://github.com/cloudsoft/winrm4j/issues/63 To test add in location configuration

[GitHub] brooklyn-server issue #680: Adds JcloudsLocationCustomizer hook to allow nod...

2017-05-15 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/680 You can assign any ssh config using ``` provisioning.properties: brooklyn.ssh.config.additionalSshConfig: myValue ``` --- If your project is set up for it, you can

Re: [PROPOSAL] Delete java/groovy example apps that are misleading

2017-05-10 Thread bostko
+1 for contents in https://github.com/apache/brooklyn-library/tree/master/examples except [1] [1] https://github.com/apache/brooklyn-library/tree/master/examples/webapps On 10/05/17 16:30, Aled Sage wrote: Hi all, I suggest we delete the java/groovy examples in brooklyn-library/examples [1

Re: [PROPOSAL] Delete java/groovy example apps that are misleading

2017-05-10 Thread bostko
edit On 10/05/17 16:37, bostko wrote: +1 for *deleting* contents in https://github.com/apache/brooklyn-library/tree/master/examples except [1] [1] https://github.com/apache/brooklyn-library/tree/master/examples/webapps On 10/05/17 16:30, Aled Sage wrote: Hi all, I suggest we delete

[GitHub] brooklyn-docs issue #179: Recommend up to date JAVA_DEBUG_OPTS flags

2017-05-09 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-docs/pull/179 @neykov I removed `-Xint` option from doc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] brooklyn-docs issue #179: Recommend up to date JAVA_DEBUG_OPTS flags

2017-05-09 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-docs/pull/179 I personally use the line I quoted only and works for me. If others thing we shouldn't advice people to use `Xint` I am happy to simply remove it from this doc and probably add a

[GitHub] brooklyn-docs issue #179: Recommend up to date JAVA_DEBUG_OPTS flags

2017-05-09 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-docs/pull/179 It is interesting that IntelliJ Idea recommends using remote debug only with `-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005` and not disabling JIT. --- If your

[GitHub] brooklyn-docs pull request #179: Remove from docs deprecated -Xnoagent

2017-05-09 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-docs/pull/179 Remove from docs deprecated -Xnoagent Ignored in Oracle Java http://www.oracle.com/technetwork/java/javase/tech/faqs-jsp-142584.html#QC4http://www.oracle.com/technetwork/java/javase/tech

[GitHub] brooklyn-docs issue #176: imageId example for Azure Compute ARM

2017-05-04 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-docs/pull/176 @tbouron I agree we should look why `osVersionRegex: 7\..*` does not choose the latest and probably fire a bug instead of adding such note. Closing PR. I will create a jira issue at some

[GitHub] brooklyn-docs pull request #176: imageId example for Azure Compute ARM

2017-05-04 Thread bostko
Github user bostko closed the pull request at: https://github.com/apache/brooklyn-docs/pull/176 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-docs pull request #176: imageId example for Azure Compute ARM

2017-04-28 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-docs/pull/176 imageId example for Azure Compute ARM You can merge this pull request into a Git repository by running: $ git pull https://github.com/bostko/brooklyn-docs azure-arm/imageId-hint

[GitHub] brooklyn-server issue #655: WindowsPerformanceCounterFeed testing/tidy

2017-04-27 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/655 Thank you! Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-docs pull request #174: gDefault config key

2017-04-26 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-docs/pull/174 gDefault config key Ssh access should be strongly limited. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bostko/brooklyn-docs sec

[GitHub] brooklyn-server pull request #654: Fix BROOKLYN-493 Rebind fails when using ...

2017-04-26 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-server/pull/654 Fix BROOKLYN-493 Rebind fails when using WinRmCommandSensor You can merge this pull request into a Git repository by running: $ git pull https://github.com/bostko/brooklyn-server

[GitHub] brooklyn-docs pull request #171: A ConfigKey default value should be immutab...

2017-04-19 Thread bostko
Github user bostko closed the pull request at: https://github.com/apache/brooklyn-docs/pull/171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-docs issue #171: A ConfigKey default value should be immutable.

2017-04-19 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-docs/pull/171 Closing in favor of #171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] brooklyn-docs pull request #171: A ConfigKey default value should be immutab...

2017-04-19 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-docs/pull/171 A ConfigKey default value should be immutable. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bostko/brooklyn-docs default-config-key

[GitHub] brooklyn-server issue #639: BROOKLYN-475: fix machine-details parsing

2017-04-18 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/639 Verified without the fix test fails. I think the fix is sufficient. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] brooklyn-library issue #99: Update random passwords

2017-04-13 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-library/pull/99 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] brooklyn-server issue #634: BROOKLYN-474: rebind to policy with private cons...

2017-04-13 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/634 Are there other use cases for using private classes besides BROOKLYN-474? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] brooklyn-docs pull request #163: Update jclouds 1.9.x links to point to jclo...

2017-04-06 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-docs/pull/163 Update jclouds 1.9.x links to point to jclouds 2.0.x Removed obsolete openstack-mitaka-nova section. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] brooklyn-docs pull request #162: BROOKLYN-460: Brooklyn Camp syntax guidance

2017-04-06 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-docs/pull/162 BROOKLYN-460: Brooklyn Camp syntax guidance You can merge this pull request into a Git repository by running: $ git pull https://github.com/bostko/brooklyn-docs yaml-tags Alternatively

[GitHub] brooklyn-server pull request #612: BROOKLYN-460: Brooklyn Camp syntax for ad...

2017-04-05 Thread bostko
Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/612#discussion_r109965279 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynEntityDecorationResolver.java --- @@ -227,7

[GitHub] brooklyn-server issue #618: Sanitizer: avoid NPE on `sanitize(null)`

2017-04-04 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/618 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] brooklyn-server pull request #612: BROOKLYN-460: Brooklyn Camp syntax for ad...

2017-03-29 Thread bostko
Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/612#discussion_r108640523 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynEntityDecorationResolver.java --- @@ -227,7

[GitHub] brooklyn-server pull request #612: BROOKLYN-460: Brooklyn Camp syntax for ad...

2017-03-29 Thread bostko
Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/612#discussion_r108639142 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/DslYamlTest.java --- @@ -66,6 +71,63 @@ public void

[GitHub] brooklyn-server pull request #612: BROOKLYN-460: Brooklyn Camp syntax for ad...

2017-03-29 Thread bostko
Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/612#discussion_r108635893 --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/BrooklynTags.java --- @@ -59,6 +59,21 @@ public String getKind() { public

[GitHub] brooklyn-server pull request #612: BROOKLYN-460: Brooklyn Camp syntax for ad...

2017-03-29 Thread bostko
Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/612#discussion_r108633990 --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynComponentTemplateResolver.java --- @@ -257,6

[GitHub] brooklyn-server pull request #612: Brooklyn Camp syntax for adding tags to a...

2017-03-27 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-server/pull/612 Brooklyn Camp syntax for adding tags to an entity spec ```yaml services: - type: BasicApplication brooklyn.tags: [tag1, tag2] ``` `brooklyn.tags` adds

[GitHub] brooklyn-server issue #603: WinRmMachineLocation obtaining WinRmTool paramet...

2017-03-22 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/603 I missed to add that my concern is that I do not know find suitable place to put such test. Adding test in brooklyn-camp or brooklyn-software-winrm will introduce circular dependency

[GitHub] brooklyn-server issue #603: WinRmMachineLocation obtaining WinRmTool paramet...

2017-03-22 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/603 @neykov as far as I can see test for this requires two things: - BrooklynCampPlatformLauncherNoServer in order external config to work https://github.com/apache/brooklyn-server/blob

[GitHub] brooklyn-server pull request #603: WinRmMachineLocation obtaining WinRmTool ...

2017-03-21 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-server/pull/603 WinRmMachineLocation obtaining WinRmTool parameters via its config().get - This allows WinrmTool props to be supplied via external configuration providers. - WinRmTool instantiation is

[GitHub] brooklyn-server pull request #597: Rebind SshFeed workaround

2017-03-21 Thread bostko
Github user bostko closed the pull request at: https://github.com/apache/brooklyn-server/pull/597 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-server issue #597: Rebind SshFeed workaround

2017-03-21 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/597 No we do not need this PR since we have #598 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-server pull request #597: Rebind SshFeed workaround

2017-03-15 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-server/pull/597 Rebind SshFeed workaround You can merge this pull request into a Git repository by running: $ git pull https://github.com/bostko/brooklyn-server sshfeed-rebind Alternatively you can

[GitHub] brooklyn-server pull request #596: WinRmCommandSensor default executionDir

2017-03-15 Thread bostko
Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/596#discussion_r106206363 --- Diff: software/winrm/src/main/java/org/apache/brooklyn/core/sensor/windows/WinRmCommandSensor.java --- @@ -144,15 +144,7 @@ public T apply

[GitHub] brooklyn-server pull request #596: WinRmCommandSensor default executionDir

2017-03-15 Thread bostko
Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/596#discussion_r106205545 --- Diff: software/winrm/src/main/java/org/apache/brooklyn/core/sensor/windows/WinRmCommandSensor.java --- @@ -144,15 +144,7 @@ public T apply

[GitHub] brooklyn-server pull request #596: WinRmCommandSensor default executionDir

2017-03-15 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-server/pull/596 WinRmCommandSensor default executionDir Use default dir obtained on the winrm sesion until Apache Brooklyn has working concept for RUN_DIR on VanillaWindowsProcess You can merge this

[GitHub] brooklyn-docs issue #155: Brooklyn.initializers example with sensor from win...

2017-03-15 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-docs/pull/155 @drigodwin could you check again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-server issue #595: Workaround for WinRmCommandSensor to see CmdFeed...

2017-03-15 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/595 That worked, thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] brooklyn-server pull request #595: Workaround for WinRmCommandSensor to see ...

2017-03-15 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-server/pull/595 Workaround for WinRmCommandSensor to see CmdFeed in OSGi Move CmdFeed to the same package as WinRmCommandSensor You can merge this pull request into a Git repository by running: $ git

[GitHub] brooklyn-docs pull request #156: Suggest using unique custom.machine.namer.m...

2017-03-14 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-docs/pull/156 Suggest using unique custom.machine.namer.machine Notes on using unique VM name to avoid duplicated names in cloud. You can merge this pull request into a Git repository by running

[GitHub] brooklyn-server issue #591: Fix ssh login when provider's image requires TTY

2017-03-13 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/591 I wanted to check whether it is tested against CentOS 6. Thank you for inspecting that! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-server issue #591: Fix ssh login when provider's image requires TTY

2017-03-13 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/591 Is it possible that `PROP_ALLOCATE_PTY` breaks for Centos 6 images? Is it tested on other clouds. I thing it should be optional. I have to suggestions for implementing it: - Move

[GitHub] brooklyn-docs pull request #155: Brooklyn.initializers example with sensor f...

2017-03-13 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-docs/pull/155 Brooklyn.initializers example with sensor from windows command You can merge this pull request into a Git repository by running: $ git pull https://github.com/bostko/brooklyn-docs winrm

[GitHub] brooklyn-server issue #591: Fix ssh login when provider's image requires TTY

2017-03-13 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/591 I would move tty disable flag after the createUser statement. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] brooklyn-docs pull request #154: WinRM CMD feed usage

2017-03-13 Thread bostko
Github user bostko commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/154#discussion_r105683376 --- Diff: guide/java/feeds.md --- @@ -67,15 +69,15 @@ protected void disconnectSensors() { An SSH feed executes a command over ssh periodically

[GitHub] brooklyn-docs pull request #154: WinRM CMD feed usage

2017-03-10 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-docs/pull/154 WinRM CMD feed usage You can merge this pull request into a Git repository by running: $ git pull https://github.com/bostko/brooklyn-docs winrmcmd_feed Alternatively you can review and

  1   2   3   4   >