[GitHub] brooklyn-docs pull request #244: Update DynamicCluster docs

2018-02-12 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-docs/pull/244 Update DynamicCluster docs Update DynamicCluster docs to add config info and new information from [brooklyn-server#923](https://github.com/apache/brooklyn-server/pull/923). You can merge

[GitHub] brooklyn-server issue #943: Only log.warn once on feed failure

2018-01-30 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/943 ``` [ERROR] COMPILATION ERROR : [INFO] - [ERROR] /home/jenkins/jenkins-slave/workspace/brooklyn-server-pull

[GitHub] brooklyn-server pull request #919: Stop dynamiccluster.zone.enable inheritan...

2017-12-19 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-server/pull/919 Stop dynamiccluster.zone.enable inheritance This is required so child clusters don't inherit this from their parent as it doesn't work. You can merge this pull request

[GitHub] brooklyn-server issue #912: BROOKLYN-568: fix NPE on SshFeed rebind

2017-12-07 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/912 retest this please ---

[GitHub] brooklyn-docs pull request #239: Correct elect primary policies package

2017-11-28 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-docs/pull/239 Correct elect primary policies package Typo in the elect primary policies gave an incorrect package name. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] brooklyn-server issue #902: BROOKLYN-545: Fix DynamicCluster.zoneFailureDete...

2017-11-21 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/902 retest this please ---

[GitHub] brooklyn-docs pull request #238: Specify EBS boot volume size

2017-11-17 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/238#discussion_r151664428 --- Diff: guide/locations/_AWS.md --- @@ -42,6 +42,21 @@ Below are examples of configuration options that use values specific to AWS EC2

[GitHub] brooklyn-docs pull request #238: Specify EBS boot volume size

2017-11-17 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-docs/pull/238 Specify EBS boot volume size Document how to specify the EBS boot volume size on AWS You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] brooklyn-server issue #893: BROOKLYN-461: coerce empty string to URI as null

2017-11-16 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/893 retest this please ---

[GitHub] brooklyn-server issue #894: Adds SetLimitsCustomizer for centos/rhel

2017-11-15 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/894 retest this please ---

[GitHub] brooklyn-server issue #896: Test rest resources included

2017-11-15 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/896 retest this please ---

[GitHub] brooklyn-library issue #142: Update Zookeeper Version

2017-11-15 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-library/pull/142 retest this please ---

[GitHub] brooklyn-server issue #897: Add ElectPrimaryPolicy (and enrichers) to catalo...

2017-11-15 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/897 retest this please ---

[GitHub] brooklyn-library pull request #142: Update Zookeeper Version

2017-11-14 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-library/pull/142 Update Zookeeper Version Updates zookeeper to latest version. Tested on AWS. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] brooklyn-library issue #141: Mysql update password

2017-11-09 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-library/pull/141 Thanks @geomacy, I agree about the TODO. The shortcomings of the MySQL entity have already been identified in PRs such as #76 and I think a re-write in YAML is the best course of action

[GitHub] brooklyn-library issue #141: Mysql update password

2017-11-09 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-library/pull/141 I've tested this by starting this blueprint: ``` brooklyn.catalog: version: "1.0.0-SNAPSHOT" items: - id: test version: "1.0.0-SNAPSH

[GitHub] brooklyn-library pull request #141: Mysql update password

2017-11-08 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-library/pull/141 Mysql update password If you set the `mysql.datadir` in order to specify an existing database, the MySQL entity still tries to set the root password from blank assuming that it'

[GitHub] brooklyn-docs pull request #231: document the new ElectPrimaryPolicy and rel...

2017-11-06 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/231#discussion_r149106485 --- Diff: guide/blueprints/_elect-primary-policies.md --- @@ -0,0 +1,149 @@ + +There are a collection of policies, enrichers, and effectors

[GitHub] brooklyn-docs pull request #231: document the new ElectPrimaryPolicy and rel...

2017-11-06 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/231#discussion_r149105773 --- Diff: guide/blueprints/_elect-primary-policies.md --- @@ -0,0 +1,149 @@ + +There are a collection of policies, enrichers, and effectors

[GitHub] brooklyn-docs pull request #231: document the new ElectPrimaryPolicy and rel...

2017-11-06 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/231#discussion_r149114727 --- Diff: guide/blueprints/_elect-primary-policies.md --- @@ -0,0 +1,149 @@ + +There are a collection of policies, enrichers, and effectors

[GitHub] brooklyn-docs pull request #231: document the new ElectPrimaryPolicy and rel...

2017-11-06 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/231#discussion_r149119018 --- Diff: guide/blueprints/policies.md --- @@ -78,11 +78,18 @@ example of these working together

[GitHub] brooklyn-docs pull request #231: document the new ElectPrimaryPolicy and rel...

2017-11-06 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/231#discussion_r149114860 --- Diff: guide/blueprints/_elect-primary-policies.md --- @@ -0,0 +1,149 @@ + +There are a collection of policies, enrichers, and effectors

[GitHub] brooklyn-server pull request #876: Stop memberSpecs being inherited

2017-11-03 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-server/pull/876 Stop memberSpecs being inherited If I create a cluster inside a cluster currently the memberSpec is inherited by the second cluster. When that memberSpec is inherited it loops creating

[GitHub] brooklyn-docs pull request #227: release notes updated with recent code chan...

2017-11-02 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/227#discussion_r148543951 --- Diff: guide/misc/release-notes.md --- @@ -18,5 +18,30 @@ to Brooklyn's commercial users for funding much of this develo

[GitHub] brooklyn-server pull request #861: Update 0.13.0 versions to 1.0.0

2017-10-12 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-server/pull/861 Update 0.13.0 versions to 1.0.0 Version 0.13.0 will be 1.0.0 this PR updates those references. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] brooklyn-dist pull request #108: Fix release scripts

2017-09-28 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/108#discussion_r141639106 --- Diff: release/Vagrantfile --- @@ -76,7 +78,7 @@ Vagrant.configure(2) do |config| apt-get install -y default-jdk git subversion

[GitHub] brooklyn-server issue #830: Add support for kubernetes helm

2017-09-28 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/830 retest this please ---

[GitHub] brooklyn-server issue #826: Move chef from brooklyn-software-base to own mod...

2017-09-28 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/826 retest this please ---

[GitHub] brooklyn-docs pull request #217: Update brooklyn.properties to brooklyn.cfg

2017-09-26 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-docs/pull/217 Update brooklyn.properties to brooklyn.cfg Minor fix to rename properties to cfg. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] brooklyn-docs pull request #209: explain and use the `brooklyn-demo-sample` ...

2017-09-26 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/209#discussion_r141077472 --- Diff: guide/ops/externalized-configuration.md --- @@ -64,6 +68,18 @@ brooklyn.external.credentials.appId=MyApp In this case, the list

[GitHub] brooklyn-dist pull request #110: Improve verify brooklyn RC script

2017-09-22 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/110#discussion_r140456307 --- Diff: release/verify_brooklyn_rc.sh --- @@ -105,65 +115,74 @@ for ARCHIVE in $(find * -type f ! \( -name '*.asc' -o -name '

[GitHub] brooklyn-server pull request #840: Fix catalog YAML

2017-09-21 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-server/pull/840 Fix catalog YAML Square brackets within the yaml string meant it was interpreted as an array and broke the initial catalog load. This puts speach marks around so it's interpreted

[GitHub] brooklyn-dist pull request #108: Fix release scripts

2017-09-20 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-dist/pull/108 Fix release scripts This makes the following changes to the release scripts: * Fixes a typo in the maven version which is installed * Doesn't copy over the local gpg ke

[GitHub] brooklyn-docs pull request #214: Document `sshMonitoring.enabled`

2017-09-20 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/214#discussion_r139930384 --- Diff: guide/blueprints/custom-entities.md --- @@ -46,14 +46,48 @@ before running `launch.command` relative to where that file is installed (or

[GitHub] brooklyn-docs pull request #214: Document `sshMonitoring.enabled`

2017-09-20 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/214#discussion_r139929611 --- Diff: guide/blueprints/custom-entities.md --- @@ -46,14 +46,48 @@ before running `launch.command` relative to where that file is installed (or

[GitHub] brooklyn-server pull request #831: Add check for test resources

2017-09-19 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-server/pull/831 Add check for test resources Apache releases require there to be no binary files included in the release. Some of the tests depend on binary files and these tests must be skipped at

[GitHub] brooklyn-dist issue #106: Make vagrant work for Karaf

2017-09-18 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-dist/pull/106 Thanks @tbouron, I'll merge this now then. ---

[GitHub] brooklyn-server issue #827: Rebind test for scheduled policies

2017-09-18 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/827 The test failure looks unrelated and running the tests locally, I can't reproduce so I'm going to merge this now. ---

[GitHub] brooklyn-docs issue #213: Add docs for Scheduled and PeriodicEffectorPolicy

2017-09-16 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-docs/pull/213 Merging as brooklyn-server#822 is merged ---

[GitHub] brooklyn-dist pull request #106: Make vagrant work for Karaf

2017-09-15 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-dist/pull/106 Make vagrant work for Karaf Take only the changes from #105 which change for Karaf You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] brooklyn-docs pull request #213: Add docs for Scheduled and PeriodicEffector...

2017-09-14 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/213#discussion_r138929690 --- Diff: guide/blueprints/policies.md --- @@ -100,6 +100,39 @@ The ConnectionFailureDetector is an HA policy for monitoring an http connection

[GitHub] brooklyn-server issue #822: New periodic and scheduled effector policies

2017-09-14 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/822 I have added a PR for the documentation for this [here](https://github.com/apache/brooklyn-docs/pull/213). ---

[GitHub] brooklyn-docs pull request #213: Add docs for Scheduled and PeriodicEffector...

2017-09-14 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-docs/pull/213 Add docs for Scheduled and PeriodicEffectorPolicy Docs for [brooklyn-server#822](https://github.com/apache/brooklyn-server/pull/822) You can merge this pull request into a Git repository

[GitHub] brooklyn-server pull request #822: New periodic and scheduled effector polic...

2017-09-14 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/822#discussion_r138886618 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/action/PeriodicEffectorPolicy.java --- @@ -0,0 +1,151 @@ +/* + * Licensed to

[GitHub] brooklyn-server pull request #822: New periodic and scheduled effector polic...

2017-09-14 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/822#discussion_r138886787 --- Diff: policy/src/main/java/org/apache/brooklyn/policy/action/PeriodicEffectorPolicy.java --- @@ -0,0 +1,151 @@ +/* + * Licensed to

[GitHub] brooklyn-docs pull request #209: explain and use the `brooklyn-demo-sample` ...

2017-09-14 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/209#discussion_r138858735 --- Diff: guide/ops/cli/cli-usage-guide.md --- @@ -439,7 +439,7 @@ tvZoNUTN ssh: launching NginxControllerImpl{id... Sun Dec 20 19:18:08 GMT 20

[GitHub] brooklyn-docs pull request #209: explain and use the `brooklyn-demo-sample` ...

2017-09-14 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/209#discussion_r138858936 --- Diff: guide/ops/externalized-configuration.md --- @@ -64,6 +68,18 @@ brooklyn.external.credentials.appId=MyApp In this case, the list

[GitHub] brooklyn-docs pull request #209: explain and use the `brooklyn-demo-sample` ...

2017-09-14 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/209#discussion_r138858493 --- Diff: guide/blueprints/multiple-services.md --- @@ -41,8 +41,11 @@ Here there are a few things going on: * We've added a second se

[GitHub] brooklyn-dist pull request #105: Update Brooklyn vagrant

2017-09-14 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/105#discussion_r138851452 --- Diff: vagrant/src/main/vagrant/files/install_brooklyn.sh --- @@ -48,45 +48,53 @@ fi if [ ! "${INSTALL_FROM_LOCAL_DIST}" == &quo

[GitHub] brooklyn-dist pull request #105: Update Brooklyn vagrant

2017-09-14 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/105#discussion_r138848843 --- Diff: vagrant/src/main/vagrant/servers.yaml --- @@ -38,7 +38,7 @@ default_config: run_os_update: true servers: - name

[GitHub] brooklyn-docs pull request #208: update release notes for 0.12, adding a few...

2017-09-14 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/208#discussion_r138844352 --- Diff: guide/misc/release-notes.md --- @@ -14,19 +14,41 @@ to Brooklyn's commercial users for funding much of this develo

[GitHub] brooklyn-docs pull request #208: update release notes for 0.12, adding a few...

2017-09-14 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/208#discussion_r138844115 --- Diff: guide/misc/release-notes.md --- @@ -14,19 +14,41 @@ to Brooklyn's commercial users for funding much of this develo

[GitHub] brooklyn-library pull request #124: use external config provider for demo pa...

2017-09-13 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-library/pull/124#discussion_r138633960 --- Diff: examples/simple-web-cluster/src/main/resources/visitors-creation-script.sql --- @@ -19,18 +19,22 @@ create database visitors

[GitHub] brooklyn-dist pull request #104: Improve RPM/DEB packages

2017-09-13 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/104#discussion_r138614635 --- Diff: shared-packaging/src/main/resources/service/systemd/brooklyn.service --- @@ -22,12 +22,16 @@ Documentation=https://brooklyn.apache.org

[GitHub] brooklyn-dist pull request #104: Improve RPM/DEB packages

2017-09-13 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/104#discussion_r138614710 --- Diff: shared-packaging/src/main/resources/service/upstart/deb/brooklyn.conf --- @@ -33,11 +34,13 @@ pre-start script end script

[GitHub] brooklyn-dist pull request #104: Improve RPM/DEB packages

2017-09-13 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/104#discussion_r138611933 --- Diff: karaf/apache-brooklyn/src/main/filtered-resources/etc/brooklyn.cfg --- @@ -0,0 +1,24

[GitHub] brooklyn-dist pull request #104: Improve RPM/DEB packages

2017-09-13 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/104#discussion_r138608902 --- Diff: deb-packaging/deb/control/control --- @@ -19,6 +19,6 @@ Version: [[version]] Section: misc Priority: optional Architecture

[GitHub] brooklyn-dist pull request #104: Improve RPM/DEB packages

2017-09-13 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/104#discussion_r138614755 --- Diff: shared-packaging/src/main/resources/service/upstart/rpm/brooklyn.conf --- @@ -30,13 +31,14 @@ pre-start script end script

[GitHub] brooklyn-server pull request #819: Improve config key descriptions

2017-09-13 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/819#discussion_r138606016 --- Diff: core/src/main/java/org/apache/brooklyn/enricher/stock/Aggregator.java --- @@ -65,18 +66,22 @@ "'

[GitHub] brooklyn-server pull request #812: use external config in examples

2017-09-13 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/812#discussion_r138582530 --- Diff: camp/camp-brooklyn/src/test/resources/visitors-creation-script.sql --- @@ -19,18 +19,22 @@ create database visitors; use

[GitHub] brooklyn-docs pull request #210: [WIP] Update to Karaf as default

2017-09-08 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-docs/pull/210 [WIP] Update to Karaf as default Change the docs to specify Karaf as the default distribution * Change install instructions * Change paths * Change brooklyn.properties

[GitHub] brooklyn-dist pull request #103: Make karaf release the primary one

2017-09-08 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-dist/pull/103 Make karaf release the primary one As discussed on the mailing list this PR moves to making the karaf release the primary artifact. You can merge this pull request into a Git repository

[GitHub] brooklyn-server issue #805: Modify jcloudsLocation.releaseNode

2017-09-07 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/805 This PR swaps the mechanism Brooklyn is using to destroy a node to one which is less tested within Brooklyn. The problem it addresses has been fixed upstream in jclouds so assuming we can

[GitHub] brooklyn-server issue #805: Modify jcloudsLocation.releaseNode

2017-09-01 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/805 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] brooklyn-server issue #798: Fix template forward reference

2017-08-21 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/798 Thanks @ahgittin, merging now then. @Graeme-Miller was there a Jira for your issue? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-server pull request #802: Adds karaf application-list & enity-info ...

2017-08-21 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/802#discussion_r134225019 --- Diff: karaf/commands/src/main/java/org/apache/brooklyn/karaf/commands/EntityInfo.java --- @@ -0,0 +1,137 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #802: Adds karaf application-list & enity-info ...

2017-08-21 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/802#discussion_r134224747 --- Diff: karaf/commands/src/main/java/org/apache/brooklyn/karaf/commands/EntityInfo.java --- @@ -0,0 +1,137 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #795: Reverts #206

2017-08-14 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-server/pull/795 Reverts #206 Reverts #206 incorrectly merged You can merge this pull request into a Git repository by running: $ git pull https://github.com/drigodwin/brooklyn-server patch-2

[GitHub] brooklyn-docs pull request #204: Fix wrong indentation in Windows Azure ARM ...

2017-08-01 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/204#discussion_r130656924 --- Diff: guide/locations/_azure-ARM.md --- @@ -158,9 +158,8 @@ brooklyn.catalog: destroyOnFailure: false

[GitHub] brooklyn-server issue #782: Adds `PUT /applications/{appid}`

2017-07-28 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/782 I believe they use StringShortener to the maximum length required by the cloud see [here](https://github.com/apache/brooklyn-server/blob/master/core/src/main/java/org/apache/brooklyn/core

[GitHub] brooklyn-server issue #775: Useful getDataAsStringMap for VaultExternalConfi...

2017-07-24 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/775 Hi @bostko, I'm not clear what this is for. Could you give a description of why you want this and perhaps a test? Thanks. --- If your project is set up for it, you can reply to

[GitHub] brooklyn-server pull request #773: prevent benign error in file deletion shu...

2017-07-24 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/773#discussion_r129018661 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/os/Os.java --- @@ -317,21 +318,28 @@ public void run() throws IOException

[GitHub] brooklyn-server issue #763: Add 'first' to aggregator

2017-07-17 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/763 I've added a PR to change the docs to match this [here](https://github.com/apache/brooklyn-docs/pull/203). --- If your project is set up for it, you can reply to this email and have

[GitHub] brooklyn-docs pull request #203: Add first addition to Aggregator

2017-07-17 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-docs/pull/203 Add first addition to Aggregator Changes docs to match brooklyn-server#763 You can merge this pull request into a Git repository by running: $ git pull https://github.com/drigodwin

[GitHub] brooklyn-server pull request #761: Async entities

2017-07-13 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/761#discussion_r127176140 --- Diff: core/src/main/java/org/apache/brooklyn/entity/stock/AsyncApplicationImpl.java --- @@ -0,0 +1,473 @@ +/* + * Licensed to the

[GitHub] brooklyn-server pull request #761: Async entities

2017-07-13 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/761#discussion_r127177524 --- Diff: core/src/main/java/org/apache/brooklyn/entity/stock/AsyncApplicationImpl.java --- @@ -0,0 +1,473 @@ +/* + * Licensed to the

[GitHub] brooklyn-server issue #760: Add DigitalOcean2 and ProfitBricks features to K...

2017-07-12 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/760 I think that is a good point but probably outside the scope of this PR @andreaturli so it shouldn't stop this being merged. This looks fine to me, so I'm going to merge n

[GitHub] brooklyn-server issue #755: Added endpoint test boms

2017-07-05 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/755 Could you add a description to this PR saying what it's adding please @Graeme-Miller? --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] brooklyn-docs pull request #202: fixing broken links

2017-06-30 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/202#discussion_r125004866 --- Diff: guide/ops/osgi.md --- @@ -29,7 +29,7 @@ Start the instance with a console in the foreground using the following command bin/karaf

[GitHub] brooklyn-docs pull request #202: fixing broken links

2017-06-30 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/202#discussion_r124996617 --- Diff: guide/ops/osgi.md --- @@ -29,7 +29,7 @@ Start the instance with a console in the foreground using the following command bin/karaf

[GitHub] brooklyn-server issue #750: Adds a policy to create locations from an entity

2017-06-29 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/750 This looks really useful but it could probably do with some tests if that's possible @grkvlt? --- If your project is set up for it, you can reply to this email and have your

[GitHub] brooklyn-server issue #732: Adds brooklyn-container-service code

2017-06-29 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/732 I've tested this connecting to a docker swarm, k8s and openshift endpoint. I was able to connect and deploy things on each so this all looks good to me. I'm going to merge now

[GitHub] brooklyn-dist pull request #95: Add the container service dependencies to th...

2017-06-27 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/95#discussion_r124230107 --- Diff: all/pom.xml --- @@ -117,6 +117,26 @@ ${project.version

[GitHub] brooklyn-docs pull request #201: Update location structure

2017-06-23 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-docs/pull/201 Update location structure Updates the structure from #119. You can merge this pull request into a Git repository by running: $ git pull https://github.com/drigodwin/brooklyn-docs

[GitHub] brooklyn-docs pull request #198: [WIP] Versioning

2017-06-22 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/198#discussion_r123557270 --- Diff: guide/blueprints/catalog/versioning.md --- @@ -3,18 +3,118 @@ title: Versioning layout: website-normal

[GitHub] brooklyn-docs pull request #198: [WIP] Versioning

2017-06-22 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/198#discussion_r123558404 --- Diff: guide/blueprints/catalog/versioning.md --- @@ -3,18 +3,118 @@ title: Versioning layout: website-normal

[GitHub] brooklyn-docs pull request #198: [WIP] Versioning

2017-06-22 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/198#discussion_r123556880 --- Diff: guide/blueprints/catalog/bundle.md --- @@ -5,7 +5,25 @@ layout: website-normal ### Bundling Catalog Resources -It is

[GitHub] brooklyn-server issue #739: A default network is now created when deploying ...

2017-06-22 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/739 I'm going to merge this now, thankyou @Graeme-Miller! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] brooklyn-server pull request #739: A default network is now created when dep...

2017-06-21 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/739#discussion_r123211313 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/creator/DefaultAzureArmNetworkCreator.java --- @@ -0,0

[GitHub] brooklyn-server pull request #739: A default network is now created when dep...

2017-06-21 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/739#discussion_r123211259 --- Diff: locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/networking/creator/DefaultAzureArmNetworkCreatorTest.java

[GitHub] brooklyn-server issue #739: A default network is now created when deploying ...

2017-06-21 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/739 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] brooklyn-server issue #736: Test performance/scalability of many entities

2017-06-19 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/736 The test failure: ``` Error Message failed succeeds-eventually, 21 attempts, 3001ms elapsed: AssertionError: entity=Application[grc5o5nv]; attribute=Sensor: service.state

[GitHub] brooklyn-library pull request #117: Update MariaDB version

2017-06-15 Thread drigodwin
GitHub user drigodwin opened a pull request: https://github.com/apache/brooklyn-library/pull/117 Update MariaDB version MariaDB version `5.5.53` is no longer available so update to the latest version `10.2.6`. You can merge this pull request into a Git repository by running

[GitHub] brooklyn-server issue #733: Makes core-tests.jar installable in the catalog,...

2017-06-13 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/733 When I run this I get `Missing bundle symbolic name in BOM or MANIFEST`, am I doing something wrong @neykov? --- If your project is set up for it, you can reply to this email and have

[GitHub] brooklyn-server issue #725: Rename to AbstractRebindHistoricTest

2017-06-12 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-server/pull/725 This looks fine, thanks @aledsage --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] brooklyn-docs pull request #195: Advise users to increase OS opened files li...

2017-06-07 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/195#discussion_r120639785 --- Diff: guide/ops/troubleshooting/increase-system-resource-limits.md --- @@ -4,6 +4,16 @@ title: Increase System Resource Limits toc: /guide

[GitHub] brooklyn-docs issue #195: Advise users to increase OS opened files limit

2017-06-07 Thread drigodwin
Github user drigodwin commented on the issue: https://github.com/apache/brooklyn-docs/pull/195 This is a good addition, I've suggested some minor rewording. Thanks @bostko! --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] brooklyn-docs pull request #195: Advise users to increase OS opened files li...

2017-06-07 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/195#discussion_r120636138 --- Diff: guide/ops/troubleshooting/increase-system-resource-limits.md --- @@ -4,6 +4,16 @@ title: Increase System Resource Limits toc: /guide

[GitHub] brooklyn-docs pull request #195: Advise users to increase OS opened files li...

2017-06-07 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/195#discussion_r120636771 --- Diff: guide/ops/troubleshooting/increase-system-resource-limits.md --- @@ -4,6 +4,16 @@ title: Increase System Resource Limits toc: /guide

[GitHub] brooklyn-docs pull request #195: Advise users to increase OS opened files li...

2017-06-07 Thread drigodwin
Github user drigodwin commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/195#discussion_r12063 --- Diff: guide/ops/troubleshooting/increase-system-resource-limits.md --- @@ -4,6 +4,16 @@ title: Increase System Resource Limits toc: /guide

  1   2   3   4   >