[GitHub] brooklyn-server issue #285: Adding HttpExecutor to be used for interchangeab...

2016-09-05 Thread ygy
Github user ygy commented on the issue: https://github.com/apache/brooklyn-server/pull/285 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-server issue #285: Adding HttpExecutor to be used for interchangeab...

2016-09-05 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/285 Almost there, only concerned about the content length being available on responses. I'd like to see tests covering the extensions config key in jclouds and byon locations - can be done

[GitHub] brooklyn-server issue #285: Adding HttpExecutor to be used for interchangeab...

2016-08-29 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/285 LGTM - a few comments from @neykov that are not yet addressed. Have those been discussed? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-server issue #285: Adding HttpExecutor to be used for interchangeab...

2016-08-23 Thread bostko
Github user bostko commented on the issue: https://github.com/apache/brooklyn-server/pull/285 A few fixes in here https://github.com/ygy/brooklyn-server/pull/3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] brooklyn-server issue #285: Adding HttpExecutor to be used for interchangeab...

2016-08-22 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/285 Looks like a great start. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] brooklyn-server issue #285: Adding HttpExecutor to be used for interchangeab...

2016-08-22 Thread ygy
Github user ygy commented on the issue: https://github.com/apache/brooklyn-server/pull/285 @nakomis @neykov Can you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this