[GitHub] brooklyn-server issue #440: BROOKLYN-345: persist brooklyn.parameters (fixes...

2016-11-16 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/440 Compile time errors in the jenkins build: ``` [ERROR] /home/jenkins/jenkins-slave/workspace/brooklyn-server-pull-requests/camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/broo

[GitHub] brooklyn-server issue #440: BROOKLYN-345: persist brooklyn.parameters (fixes...

2016-11-16 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/440 Finished review. Happy to merge after resolving the "lost default overrides" problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] brooklyn-server issue #440: BROOKLYN-345: persist brooklyn.parameters (fixes...

2016-11-16 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/440 Failing jenkins tests: ``` Failed tests: ConfigNestedYamlTest.testCatalogParameterFromSuperYamlTypeAsSoftware:90->doTestWithBlueprint:101->checkEntity:122 missing 'field'

[GitHub] brooklyn-server issue #440: BROOKLYN-345: persist brooklyn.parameters (fixes...

2016-11-17 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/440 Thanks @neykov - `ConfigNestedYamlTest.testCatalogParameterFromSuperYamlTypeAsSoftware` is a very annoying and valid failure! There is a `MapConfigKey` defined on the java type (`

[GitHub] brooklyn-server issue #440: BROOKLYN-345: persist brooklyn.parameters (fixes...

2016-11-18 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/440 The problem that I'm looking at fixing for `ConfigNestedYamlTest.testCatalogParameterFromSuperYamlTypeAsSoftware` should also fix https://issues.apache.org/jira/browse/BROOKLYN-328. --- I

[GitHub] brooklyn-server issue #440: BROOKLYN-345: persist brooklyn.parameters (fixes...

2016-11-20 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-server/pull/440 The latest changes (particularly for the commit `entity.setConfig(key,v): lookup ownKey`) are motivated by fixing the tests that failed after the config-param override fix. Investigating th

[GitHub] brooklyn-server issue #440: BROOKLYN-345: persist brooklyn.parameters (fixes...

2016-11-24 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/440 i'll have a look at this ... likely some conflicts with https://github.com/apache/brooklyn-server/pull/462 --- If your project is set up for it, you can reply to this email and have your r

[GitHub] brooklyn-server issue #440: BROOKLYN-345: persist brooklyn.parameters (fixes...

2016-11-29 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/440 looks good, tests passing. merging. some follow-up to do in #462 which i'll do next. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu