Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
Thanks @ahgittin, got distracted and left it at `git push`.
Merged before seeing @aledsage's comment.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
LGTM as well; merging now :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
still seems not merged @neykov
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
Good idea about the listener. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
interesting comments @neykov -- but think this can be merged without those
(once you've finished)
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
@aledsage I like how you split out #485; this has been rebased and
conflicts merged. Should be easy to review now!
---
If your project is set up for it, you can reply to this email and ha
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
@aledsage I didn't pull in #485 for fun. The simplest fix for some of the
failures involves building an intermediate bundle thus
> Builds on #485 (using an intermediate JAR) for si
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
Wow, I wasn't expecting to see this set of commits of file-edits based on
the name of the PR and the description!
It would be great to review + merge your improvements for non-deter
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
This now extracts classpath folders to a temp folder on the filespace.
Builds on #485 (using an intermediate JAR) for simplicity. Assuming the `@`
escaping was the cause of orphans this s
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
working on the basis that the `getResource(..).getFile()` call might do
URL-escaping when we say `getResource()` and then not properly unescape it when
we do `getFile()`. that technique is
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
i wonder if the problem is that the `@` is being escaped when it shouldn't.
would explain why it fails non-deterministically, probably sometimes it runs
in the non-`@2` directory. and can
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
also, this line
```
2017-02-18 02:00:01,345 DEBUG o.a.b.c.m.p.FileBasedObjectStore [main]:
Persistence mode AUTO, directory
/home/jenkins/jenkins-slave/workspace/brooklyn-serve
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
that comment comes immediately after the `File[] subPathDirFiles =
subPathDir.listFiles(fileFilter);` so does seems like the dir is empty when the
failing test runs (as opposed to some othe
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
a healthy run also shows the `Creating directory` message, but the key
difference seems to be:
```
2017-02-14 16:16:13,575 DEBUG
o.a.b.c.m.h.ManagementPlaneSyncRecordPersisterT
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
(elsewhere in the log it refers to path
`/home/jenkins/jenkins-slave/workspace/brooklyn-server-pull-requests@2/launcher/target/surefire/surefirebooter8075241968007199755.jar!/META-INF/MANIFE
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
at the moment the contents look healthy in
https://builds.apache.org/job/brooklyn-server-pull-requests/ws/launcher/target/test-classes/orphaned-locations-test-data/data-with-orphaned-locatio
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
the debug log was still around, so we get a bit more info:
```
2017-02-18 02:00:01,331 DEBUG o.a.b.c.m.p.FileBasedObjectStore [main]:
File-based objectStore will use directory
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
nope, last failure shows this didn't fix the orphaned state failures either
:(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
Applied @neykov 's comments. If all tests pass then good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
+1 go ahead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/560
Curious. I'll amend comments here and merge if that's okay. Happy to remove
the setReuseAddr or not depending who gets to it first.
---
If your project is set up for it, you can reply
21 matches
Mail list logo
