[GitHub] brooklyn-server issue #737: Clean up inference around parsing `name:version`...

2017-06-28 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/737 great comments here @geomacy , addressed all except where commented above; moving on to #740 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] brooklyn-server issue #737: Clean up inference around parsing `name:version`...

2017-06-27 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/737 👍 I was going to look at that next :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] brooklyn-server issue #737: Clean up inference around parsing `name:version`...

2017-06-27 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/737 @geomacy left my comments in https://github.com/apache/brooklyn-server/pull/740 which includes this PR. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] brooklyn-server issue #737: Clean up inference around parsing `name:version`...

2017-06-26 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/737 Would also be interested in @neykov's comments on this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] brooklyn-server issue #737: Clean up inference around parsing `name:version`...

2017-06-22 Thread geomacy
Github user geomacy commented on the issue: https://github.com/apache/brooklyn-server/pull/737 @ahgittin haven't ignored this but haven't been able to find the bandwidth to look at it - will be off tomorrow, but will look at this and related PRs on Monday! --- If your project is s

[GitHub] brooklyn-server issue #737: Clean up inference around parsing `name:version`...

2017-06-21 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/737 re tests - see #740 which merges this and test pass --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] brooklyn-server issue #737: Clean up inference around parsing `name:version`...

2017-06-20 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/737 @geomacy @neykov ready for review. does not do the version changes discussed on ML but prepares us for them (and helped me understand them). this is mainly to fix issues where people have

[GitHub] brooklyn-server issue #737: Clean up inference around parsing `name:version`...

2017-06-20 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-server/pull/737 (the test failure is a test env config issue in hudson remoting) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj