[GitHub] brooklyn-server issue #745: Azure ARM default network fixes from PR suggesti...

2017-07-15 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/745 @Graeme-Miller Brooklyn has upgraded to jclouds 2.0.2, which opens the door to supporting default region as well. --- If your project is set up for it, you can reply to this email and have

[GitHub] brooklyn-server issue #745: Azure ARM default network fixes from PR suggesti...

2017-07-04 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/745 Thanks @Graeme-Miller, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-server issue #745: Azure ARM default network fixes from PR suggesti...

2017-07-04 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/745 @neykov I have rebased --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] brooklyn-server issue #745: Azure ARM default network fixes from PR suggesti...

2017-07-04 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/745 LGTM with the "waiting to complete" changes. @Graeme-Miller have you retried your test, has the failure rate improved? If no failure this is good to merge. Otherwise we need to look for

[GitHub] brooklyn-server issue #745: Azure ARM default network fixes from PR suggesti...

2017-06-29 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/745 Fine by me to merge the PR as it already improves on the existing functionality. Can you create another PR which targets post 2.0.1 jclouds, handling the default region case and mark it

[GitHub] brooklyn-server issue #745: Azure ARM default network fixes from PR suggesti...

2017-06-27 Thread Graeme-Miller
Github user Graeme-Miller commented on the issue: https://github.com/apache/brooklyn-server/pull/745 @neykov that's a good point about the default networking functionality being different in 2.0.1. I'd still recommend merging this PR as it is useful for downstream projects that use

[GitHub] brooklyn-server issue #745: Azure ARM default network fixes from PR suggesti...

2017-06-26 Thread neykov
Github user neykov commented on the issue: https://github.com/apache/brooklyn-server/pull/745 * re azure jclouds 2.0.1 not having enough functionality - the changes here (and in previous PR) will create the default network, but will not assign it to the nodes because `ipOptions`

[GitHub] brooklyn-server issue #745: Azure ARM default network fixes from PR suggesti...

2017-06-26 Thread duncangrant
Github user duncangrant commented on the issue: https://github.com/apache/brooklyn-server/pull/745 Tested with a location with no virtual network set but with overrideAuthenticateSudo set to true. Tested with a specified virtual network. --- If your project is set up for it,