Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/194
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/194#discussion_r67360931
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -2422,7 +2437,7 @@ protected JcloudsWinRm
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/194#discussion_r66627553
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/JcloudsLocationExternalConfigYamlTest.java
---
@@ -0,0 +1,143 @@
+
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/194#discussion_r66629162
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/config/ConfigBag.java ---
@@ -367,6 +367,22 @@ public Object getStringKey(String key) {
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/194#discussion_r66628716
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -2422,7 +2437,7 @@ protected JcloudsWinR
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/194#discussion_r66628347
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/config/ConfigBag.java ---
@@ -367,6 +367,22 @@ public Object getStringKey(String key) {
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/194#discussion_r66627723
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/config/ConfigBag.java ---
@@ -367,6 +367,22 @@ public Object getStringKey(String key) {
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/194#discussion_r66626931
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/JcloudsLocationExternalConfigYamlTest.java
---
@@ -0,0 +1,143 @@
+
GitHub user nakomis opened a pull request:
https://github.com/apache/brooklyn-server/pull/194
Prevents premature resolving of external config
If external config is resolved too early, it can lead to resolved values
being persisted (security flaw). Also, changes to the external confi
