[GitHub] brooklyn-server pull request #425: Factor security group code out into separ...

2016-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/425 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] brooklyn-server pull request #425: Factor security group code out into separ...

2016-11-23 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/425#discussion_r89303465 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/JcloudsLocationSecurityGroupCustomizer.java --- @@ -219,60

[GitHub] brooklyn-server pull request #425: Factor security group code out into separ...

2016-11-23 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/425#discussion_r89302809 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/JcloudsLocationSecurityGroupCustomizer.java --- @@ -219,60

[GitHub] brooklyn-server pull request #425: Factor security group code out into separ...

2016-11-23 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/425#discussion_r89302475 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/JcloudsLocationSecurityGroupCustomizer.java --- @@ -223,56

[GitHub] brooklyn-server pull request #425: Factor security group code out into separ...

2016-11-18 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/425#discussion_r88763504 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/JcloudsLocationSecurityGroupEditor.java --- @@ -0,0 +1,303

[GitHub] brooklyn-server pull request #425: Factor security group code out into separ...

2016-11-18 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/425#discussion_r88763287 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/JcloudsLocationSecurityGroupEditor.java --- @@ -0,0 +1,303

[GitHub] brooklyn-server pull request #425: Factor security group code out into separ...

2016-11-18 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/425#discussion_r88660968 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/JcloudsLocationSecurityGroupEditor.java --- @@ -0,0 +1,303

[GitHub] brooklyn-server pull request #425: Factor security group code out into separ...

2016-11-17 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/425#discussion_r88501073 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/JcloudsLocationSecurityGroupCustomizer.java --- @@ -223,56

[GitHub] brooklyn-server pull request #425: Factor security group code out into separ...

2016-11-16 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/425#discussion_r88353667 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/JcloudsLocationSecurityGroupEditor.java --- @@ -0,0 +1,30

[GitHub] brooklyn-server pull request #425: Factor security group code out into separ...

2016-11-16 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/425#discussion_r88353338 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/JcloudsLocationSecurityGroupEditor.java --- @@ -0,0 +1,30

[GitHub] brooklyn-server pull request #425: Factor security group code out into separ...

2016-11-16 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/425#discussion_r88352921 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/JcloudsLocationSecurityGroupEditor.java --- @@ -0,0 +1,30

[GitHub] brooklyn-server pull request #425: Factor security group code out into separ...

2016-11-16 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/425#discussion_r88352692 --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/JcloudsLocationSecurityGroupEditor.java --- @@ -0,0 +1,30