Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/440#discussion_r91068402
--- Diff:
core/src/main/java/org/apache/brooklyn/core/config/internal/AbstractConfigMapImpl.java
---
@@ -163,13 +163,18 @@ public ConfigBag getLoca
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/440#discussion_r90607484
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynComponentTemplateResolver.java
---
@@ -374,15 +37
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/440#discussion_r90607451
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynComponentTemplateResolver.java
---
@@ -374,15 +37
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/440#discussion_r90013209
--- Diff:
core/src/main/java/org/apache/brooklyn/core/config/internal/AbstractConfigMapImpl.java
---
@@ -163,13 +163,18 @@ public ConfigBag getLocalC
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/440#discussion_r90010996
--- Diff:
core/src/main/java/org/apache/brooklyn/core/config/internal/AbstractConfigMapImpl.java
---
@@ -163,13 +163,18 @@ public ConfigBag getLoca
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/440#discussion_r89962290
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynComponentTemplateResolver.java
---
@@ -374,15 +374,
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/440#discussion_r89965074
--- Diff:
core/src/main/java/org/apache/brooklyn/core/config/internal/AbstractConfigMapImpl.java
---
@@ -163,13 +163,18 @@ public ConfigBag getLocalC
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/440
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/440#discussion_r90009674
--- Diff:
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynComponentTemplateResolver.java
---
@@ -374,15 +37
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/440#discussion_r90008704
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ServiceFailureDetectorYamlTest.java
---
@@ -0,0 +1,189 @@
+/*
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/440#discussion_r88331232
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ServiceFailureDetectorYamlTest.java
---
@@ -0,0 +1,189 @@
+/*
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/440#discussion_r88287453
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/time/Time.java ---
@@ -157,7 +157,7 @@ public static String makeTimeStringRounded(long t
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/440#discussion_r88286904
--- Diff:
policy/src/main/java/org/apache/brooklyn/policy/ha/ServiceFailureDetector.java
---
@@ -230,6 +237,7 @@ protected void setActualState(Maybe
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/440#discussion_r88286511
--- Diff:
policy/src/main/java/org/apache/brooklyn/policy/ha/ServiceFailureDetector.java
---
@@ -230,6 +237,7 @@ protected void setActualState(Maybe
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/440#discussion_r88283163
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/dto/BasicEntityMemento.java
---
@@ -139,17 +142,28 @@ protected BasicEntityMemento(
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/440#discussion_r88249200
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/ServiceFailureDetectorYamlTest.java
---
@@ -0,0 +1,189 @@
+/*
+
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/440
BROOKLYN-345: persist brooklyn.parameters (fixes ServiceFailureDetector
rebind)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aleds
17 matches
Mail list logo
