[GitHub] brooklyn-ui issue #109: catalog saver to support 'application', 'template', ...

2018-11-20 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-ui/pull/109 Sure, happy to merge and we can make subsequent improvements in other PRs. Merging now. ---

[GitHub] brooklyn-ui issue #109: catalog saver to support 'application', 'template', ...

2018-11-20 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/109 @aledsage Are you happy to address your comment in a subsequent PR? I'm ok to merge this one but would like to check with you first. ---

[GitHub] brooklyn-ui issue #109: catalog saver to support 'application', 'template', ...

2018-11-20 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-ui/pull/109 @tbouron the itemType is included in the tooltip text, in parentheses at the end @aledsage i think you're flagging a problem with quick launch that it is cheating a bit using the `cata

[GitHub] brooklyn-ui issue #109: catalog saver to support 'application', 'template', ...

2018-11-20 Thread tbouron
Github user tbouron commented on the issue: https://github.com/apache/brooklyn-ui/pull/109 @ahgittin I'm wondering if the tooltip texts should include the item type, the same way you describe them in your previous comment. I think it's a good compromise so users have a reference they

[GitHub] brooklyn-ui issue #109: catalog saver to support 'application', 'template', ...

2018-11-20 Thread aledsage
Github user aledsage commented on the issue: https://github.com/apache/brooklyn-ui/pull/109 @ahgittin for 'template', is that really what it means in the product from a user's perspective? Something declared as a 'template' will appear in the quick launch, whereas other things will no

[GitHub] brooklyn-ui issue #109: catalog saver to support 'application', 'template', ...

2018-11-20 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-ui/pull/109 one other change, we weren't watching `bundle` and `symbolicName` so the validator didn't do everything it should, that's fixed too now ---

[GitHub] brooklyn-ui issue #109: catalog saver to support 'application', 'template', ...

2018-11-20 Thread ahgittin
Github user ahgittin commented on the issue: https://github.com/apache/brooklyn-ui/pull/109 @tbouron agree it would be nice to make the differences clearer but not sure how. the test to apply is whether it's clearer than before where we prompted for "Application" or "Entity" with no