[GitHub] incubator-brooklyn pull request: YAML: don’t wrap sub-entities i...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1138 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-brooklyn pull request: YAML: don’t wrap sub-entities i...

Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1138#issuecomment-171360894 see my improvements to this in #1143 but note i'm still working on that; it should merge this PR automatically btw. @aledsage yes case where we're

[GitHub] incubator-brooklyn pull request: YAML: don’t wrap sub-entities i...

Github user aledsage commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1138#issuecomment-171319459 @ahgittin @johnmccabe I definitely agree with you in the case where there are multiple entities within the plan - the most sensible thing is to compose al

[GitHub] incubator-brooklyn pull request: YAML: don’t wrap sub-entities i...

Github user johnmccabe commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1138#issuecomment-171296179 @ahgittin regarding the location/config/policies/enrichers in template 4, prior to 0.8.0-incubating they were getting merged --- If your project is set

[GitHub] incubator-brooklyn pull request: YAML: don’t wrap sub-entities i...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1138#discussion_r49582949 --- Diff: brooklyn-server/camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynAssemblyTemplateInstantiator.java

[GitHub] incubator-brooklyn pull request: YAML: don’t wrap sub-entities i...

Github user ahgittin commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1138#discussion_r49582715 --- Diff: brooklyn-server/camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynAssemblyTemplateInstantiator.java

[GitHub] incubator-brooklyn pull request: YAML: don’t wrap sub-entities i...

Github user ahgittin commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1138#issuecomment-171271486 well, we should definitely refactor so the added lines are shared code. i will look at cleaning up those pieces as a PR which builds on this. i d

[GitHub] incubator-brooklyn pull request: YAML: don’t wrap sub-entities i...

Github user johnmccabe commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1138#issuecomment-171245618 as an fyi we're still observing a number of issues related to this. - wrapper parent spec isn't being merged with the child entity (for example locat

[GitHub] incubator-brooklyn pull request: YAML: don’t wrap sub-entities i...

Github user johnmccabe commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1138#issuecomment-170982690 fyi @aledsage, deployed `4-resilient-bash-web-cluster-template` and observe the wrapping occur for the VanillaSoftwareProcess under the DynamicCluster (

[GitHub] incubator-brooklyn pull request: YAML: don’t wrap sub-entities i...

GitHub user aledsage opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1138 YAML: don’t wrap sub-entities in BasicApplication Previously, any catalog item of type “template” would always be wrapped in a BasicApplication. This was being done in three p