Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/117#issuecomment-52950989
All very interesting! I think we need a security expert!
http://www.2uo.de/myths-about-urandom/ quotes folk like
http://en.wikipedia.org/wiki/Daniel_
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn-site/pull/4#issuecomment-52949456
Take a look at https://people.apache.org/~richard/ for a preview...
(community pages are the best example)
---
If your project is set up for it,
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/124#issuecomment-52949329
with @neykov @sjcorbett - we all agree re Q1, not now, maybe in future. re
Q2, let's change the syntax for consistency with how policies are added to
servic
GitHub user richardcloudsoft opened a pull request:
https://github.com/apache/incubator-brooklyn-site/pull/4
Add second-level menus and improve site structure handling
Second level menus appear both as drop-down menus on the top navbar, and on
the right side of pages.
You can merge
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/124#issuecomment-52949105
@neykov makes a good point re Q2 (noting this as we discuss it) that when
using `demo_policy` subsqeuently it's going to be confusing when someone adds
confi
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/124#issuecomment-52948555
(form discussion - call this Q2)
Do we need to support adding a "policy" which is really multiple policies
simultaneously (ie a "policy set" acting a
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/124#issuecomment-52948306
(from discussion - call this Q1) Do we need to support adding multiple
policies to the catalog via a single YAML files? We don't currently even have
this fo
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/124#issuecomment-52947585
Looks good. Only minor code comments.
Just to confirm, for entities in the yaml format like:
brooklyn.catalog:
id: " + childCat
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/124#discussion_r16550590
--- Diff:
usage/camp/src/test/java/io/brooklyn/camp/brooklyn/CatalogYamlPolicyTest.java
---
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Ap
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/124#discussion_r16550521
--- Diff:
usage/camp/src/test/java/io/brooklyn/camp/brooklyn/CatalogYamlPolicyTest.java
---
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Ap
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/124#discussion_r16550371
--- Diff:
core/src/test/dependencies/osgi/entities/src/main/java/brooklyn/osgi/tests/SimplePolicy.java
---
@@ -0,0 +1,35 @@
+/*
+ * Lice
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/124#discussion_r16550299
--- Diff:
core/src/test/dependencies/osgi/entities/src/main/java/brooklyn/osgi/tests/SimplePolicy.java
---
@@ -0,0 +1,35 @@
+/*
+ * Lice
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/124#discussion_r16550266
--- Diff:
core/src/test/dependencies/osgi/entities/src/main/java/brooklyn/osgi/tests/SimplePolicy.java
---
@@ -0,0 +1,35 @@
+/*
+ * Lice
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/124#discussion_r16550195
--- Diff:
core/src/main/java/brooklyn/catalog/internal/CatalogItemBuilder.java ---
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Softwa
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/124#discussion_r16550010
--- Diff:
core/src/main/java/brooklyn/catalog/internal/BasicBrooklynCatalog.java ---
@@ -287,26 +324,39 @@ public void load() {
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/124#discussion_r16549863
--- Diff:
core/src/main/java/brooklyn/catalog/internal/BasicBrooklynCatalog.java ---
@@ -215,7 +203,56 @@ public void load() {
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/124#discussion_r16549801
--- Diff:
core/src/main/java/brooklyn/catalog/internal/BasicBrooklynCatalog.java ---
@@ -215,7 +203,56 @@ public void load() {
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/124#discussion_r16549657
--- Diff:
core/src/main/java/brooklyn/catalog/internal/BasicBrooklynCatalog.java ---
@@ -176,27 +179,12 @@ public void load() {
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/125#issuecomment-52944219
Seems to work. Merging.
Suggest we change the archetype to generate a pom that extends the new
`brooklyn-downstream-parent` (which only generates the
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/118
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/118#discussion_r16549081
--- Diff:
software/nosql/src/test/java/brooklyn/entity/nosql/couchdb/CouchDBNodeLiveTest.java
---
@@ -47,18 +47,18 @@
@DataProvid
[
https://issues.apache.org/jira/browse/BROOKLYN-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kennedy resolved BROOKLYN-12.
Resolution: Fixed
Fix Version/s: 0.7.0-SNAPSHOT
> Add Node.JS application support
>
[
https://issues.apache.org/jira/browse/BROOKLYN-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kennedy closed BROOKLYN-12.
--
Merged pull request #94
> Add Node.JS application support
> ---
>
>
[
https://issues.apache.org/jira/browse/BROOKLYN-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105498#comment-14105498
]
ASF GitHub Bot commented on BROOKLYN-12:
Github user asfgit closed the pull reque
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/94
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/121#issuecomment-52941703
Thanks for spotting @sjcorbett - thorough! I've incorporated those,
rebased, and pushed. Will merge now.
---
If your project is set up for it, you can reply
[
https://issues.apache.org/jira/browse/BROOKLYN-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105488#comment-14105488
]
ASF GitHub Bot commented on BROOKLYN-12:
Github user grkvlt commented on the pull
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/94#issuecomment-52940407
Ready to merge. Tested with a couple of example applications, a basic Hello
World and a Todo manager using Redis.
---
If your project is set up for it, you can
Like it. Feel free to update the Google doc. Or knowing you, you'll go
ahead and implement it. :)
--A
On 21/08/2014 14:38, Richard Downer wrote:
Alex,
Great proposal.
In my suggestion I had split "community" into two top level items,
"community" and "developers". The guides to making c
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/120
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/120#issuecomment-52938281
Thanks @neykov - I've added that, including the .m2 ignore stuff as my
downstream Eclipse project showed an error before I added it. I've also
rebased. Will
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/127
various 20140814
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn
fix/various-20140814
Alternatively y
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/113#issuecomment-52921679
Finished reviewing. Changes look good. Only minor comments, most of which
are not relevant for merging this.
@ahgittin once you've read through them,
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/113#discussion_r16539033
--- Diff:
usage/rest-server/src/test/java/brooklyn/rest/BrooklynRestApiLauncher.java ---
@@ -238,7 +241,7 @@ private static void
installBrooklyn
Alex,
Great proposal.
In my suggestion I had split "community" into two top level items,
"community" and "developers". The guides to making code contributions,
accessing CI and snapshot builds, etc. were present under the
"developers" menu. The "community" header was left for items about how
our
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/113#discussion_r16538643
--- Diff:
core/src/test/java/brooklyn/management/ha/HighAvailabilityManagerSplitBrainTest.java
---
@@ -303,31 +305,42 @@ protected void doTestCo
+1
--A
On 20/08/2014 20:23, Andrew Kennedy wrote:
+1
The changes sound reasonable, including the project move. The Guava method
naming conventions and patterns are familiar to most Java developers, so it
makes sense to copy them where we can. I really think the impact on
downstream projects
39 matches
Mail list logo
