[GitHub] incubator-brooklyn pull request: Brooklyn OSGification - step 1 (b...

Github user neykov commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/962#issuecomment-151397128 @hzbarcea, @CMoH The master build is failing after merging this PR, could you take a look. --- If your project is set up for it, you can reply to this email

Build failed in Jenkins: incubator-brooklyn-master-integration #240

See Changes: [cheepeero] [BROOKLYN-183] Skeleton for karaf container [cheepeero] [BROOKLYN-183] Skeleton of karaf shell commands project [cheepeero] [BROOKLYN-183] More on karaf integration [cheepeero] [BROOKLYN

Build failed in Jenkins: incubator-brooklyn-master-build #616

See Changes: [cheepeero] [BROOKLYN-183] Skeleton for karaf container [cheepeero] [BROOKLYN-183] Skeleton of karaf shell commands project [cheepeero] [BROOKLYN-183] More on karaf integration [cheepeero] [BROOKLYN-183] A

[GitHub] incubator-brooklyn pull request: License

GitHub user ahgittin opened a pull request: https://github.com/apache/incubator-brooklyn/pull/990 License minor edits to license metadata You can merge this pull request into a Git repository by running: $ git pull https://github.com/ahgittin/incubator-brooklyn license Alterna

[GitHub] incubator-brooklyn pull request: Ignore Groovy plugin in Eclipse b...

Github user hzbarcea commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/989#issuecomment-151322057 Forgot to mention, these changes seem to address all of @aledsage 's comments from #984 if I am not mistaken. --- If your project is set up for it, you can

[GitHub] incubator-brooklyn pull request: Ignore Groovy plugin in Eclipse b...

Github user hzbarcea commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/989#issuecomment-151321781 Reviewed, looks good, simple actually. Opened the project in Luna, all ok. There is a merge conflict because of the properties moving in #962 into th

[GitHub] incubator-brooklyn pull request: Brooklyn OSGification - step 1 (b...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/962 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-brooklyn pull request: Brooklyn OSGification - step 1 (b...

Github user hzbarcea commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/962#issuecomment-151317798 I ran more tests, didn't see any regression issue, but it's not impossible for something to have crept in, something to keep an eye on in the coming days. I

[GitHub] incubator-brooklyn pull request: Brooklyn OSGification - step 1 (b...

Github user splatch commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/962#issuecomment-151203926 :+1: Looks good for me. Builds and runs. There are small improvements which can be added later on to make things nicer but lets merge this for now. Ie. manif

[GitHub] incubator-brooklyn pull request: Convert Groovy tests to Java

Github user neykov commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/984#issuecomment-151168515 Addressed review comments in https://github.com/apache/incubator-brooklyn/pull/989. It's not clear whether the groovy-eclipse-compiler 2.9.2 is released after

[GitHub] incubator-brooklyn pull request: Ignore Groovy plugin in Eclipse b...

GitHub user neykov opened a pull request: https://github.com/apache/incubator-brooklyn/pull/989 Ignore Groovy plugin in Eclipse build The changes allow the project to be imported in vanilla "Eclipse for Java Developers" install without using additional plugins. Also upgrade

[GitHub] incubator-brooklyn pull request: MySqlCluster dump based replicati...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/965 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

Jenkins build is back to normal : incubator-brooklyn-master-windows #334

See

[GitHub] incubator-brooklyn pull request: MySqlCluster dump based replicati...

Github user neykov commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/965#issuecomment-151112179 Thanks @sjcorbett, addressed comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-brooklyn pull request: MySqlCluster dump based replicati...

Github user neykov commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/965#discussion_r42984381 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/GenericTypes.java --- @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Softwar

[GitHub] incubator-brooklyn pull request: MySqlCluster dump based replicati...

Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/965#discussion_r42981436 --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/GenericTypes.java --- @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Soft

[GitHub] incubator-brooklyn pull request: MySqlCluster dump based replicati...

Github user sjcorbett commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/965#issuecomment-151104457 Looks great. I've made two trivial comments. Happy for this to be merged. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] incubator-brooklyn pull request: Docflow amendments

Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/969 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-brooklyn pull request: Fix catalog item disabled/depreca...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/981 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-brooklyn pull request: MySqlCluster dump based replicati...

Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/965#discussion_r42980811 --- Diff: software/database/src/main/java/org/apache/brooklyn/entity/database/mysql/InitSlaveTaskBody.java --- @@ -0,0 +1,426 @@ +/* +

[GitHub] incubator-brooklyn pull request: Docflow amendments

Github user sjcorbett commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/969#issuecomment-151100228 Looks fine. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[jira] [Commented] (BROOKLYN-133) brooklyn.bat requires BROOKLYN_HOME to have a trailing "\" on Windows

[ https://issues.apache.org/jira/browse/BROOKLYN-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14973931#comment-14973931 ] Svetoslav Neykov commented on BROOKLYN-133: --- Diego thanks for the patch, could