Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/962#discussion_r46124182
--- Diff: pom.xml ---
@@ -72,11 +72,122 @@
+0.9.0-SNAPSHOT
+
1.7
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1074#discussion_r46010405
--- Diff:
core/src/test/java/org/apache/brooklyn/util/core/internal/ssh/SshToolAbstractIntegrationTest.java
---
@@ -264,8 +271,44 @@ public void
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1074
Add documentation and additional tests to SshToolAbstractIntegrationTest
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1045#issuecomment-159287775
Very good start for putting alternative WinRm implementations!
As part of this refactoring I want to remind you to review #950 .
My opinion is
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1045#discussion_r45739428
--- Diff:
software/winrm/src/main/java/org/apache/brooklyn/util/core/internal/winrm/WinRmTool.java
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1055
Fix BrooklynProperties.Factory.Builder.builderEmpty
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/incubator-brooklyn
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1054#issuecomment-158876867
@hzbarcea the reason I did this that it is in the tests and I think it is
better to have more fine control over the exceptions in tests.
Any other who
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1054
BROOKLYN-193 Test skipping invalid config values
- Exposed exceptions in RebindTestUtils
You can merge this pull request into a Git repository by running:
$ git pull https
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1033#issuecomment-157341283
Yes I tested with `rebind.failureMode.addConfig=continue` and without it
and it works as expected.
I am working on providing tests now. It will take me
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1033#discussion_r44921362
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/RebindManagerImpl.java
---
@@ -92,6 +92,9 @@
public static final
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1033
BROOKLYN-193: Add configuration for skipping invalid config
Add configuration option for skipping invalid config values
You can merge this pull request into a Git repository by running
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1015
Add documentation for the "unable to create new native thread" problem
Added a Problems section in faq.md describing how to increase ulimit.
@rdowner please advice wh
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1013#discussion_r44389092
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/internal/ssh/SshTool.java ---
@@ -49,7 +50,14 @@
* These keys are detected
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1007#issuecomment-154483716
@neykov, would you like to add more complicated test like the one bellow.
You should also assert that the name which will be passed when a user
selects
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/959#issuecomment-153782392
Thank you all for the discussion!
I made the changes and now I am testing.
---
If your project is set up for it, you can reply to this email and have
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/950#issuecomment-151855029
@ahgittin Yes it is still waiting for cloudsoft/winrm4j#2
I've upgraded the winrm4j version in this PR as well.
---
If your project is set up for it
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/991#discussion_r43144383
--- Diff:
software/database/src/main/java/org/apache/brooklyn/entity/database/mysql/MySqlClusterImpl.java
---
@@ -119,7 +121,7 @@ protected void
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/991#discussion_r43143884
--- Diff:
software/database/src/main/java/org/apache/brooklyn/entity/database/mysql/MySqlClusterImpl.java
---
@@ -119,7 +121,7 @@ protected void
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/988
Powershell scripting documentation
- Remove the unnecessary Invoke-Command
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/983#discussion_r42742105
--- Diff:
software/base/src/test/java/org/apache/brooklyn/entity/machine/SetHostnameCustomizerTest.java
---
@@ -64,4 +68,20 @@ public void
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/983#issuecomment-150189598
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/983#discussion_r42737031
--- Diff:
software/base/src/test/java/org/apache/brooklyn/entity/machine/SetHostnameCustomizerTest.java
---
@@ -64,4 +68,20 @@ public void
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/959#discussion_r42492781
--- Diff:
software/webapp/src/main/java/org/apache/brooklyn/entity/webapp/JavaWebAppSshDriver.java
---
@@ -93,11 +93,11 @@ protected String
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/964
Windows scripting documentation updates
- `$ErrorActionPreference`
- powershell commands limitations
You can merge this pull request into a Git repository by running:
$ git
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/957#discussion_r42135509
--- Diff: software/winrm/pom.xml ---
@@ -0,0 +1,65 @@
+
--- End diff --
What is the point creating a new module?
I see only
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/947#issuecomment-148404539
Closing in favour of #950
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bostko closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/947
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/959
Update Tomcat's webapp.url sensor to show the public hostname
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/incu
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/950
Windows file scripts
The PR includes #947 and it is
Dependent on cloudsoft/winrm4j#2
The most important file here is `WindowsScriptsWinrmExitStatusLiveTest`
You can merge
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/947
WinRM commands
Use executePsCommand and executeCmdCommand instead of executeScript
It is a small refactoring which cleans up the too simple executeScript
functionality.
You
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/944#issuecomment-146918927
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/940#issuecomment-146263797
Good changes!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/927
Add VanillaWindowsProcess to catalog items
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/incubator-brooklyn catalog_item
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/925#issuecomment-144004179
Yes it works.
I am testing now other mssql scripts whether they return exit code from the
commands.
---
If your project is set up for it, you can reply
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/925
MS SQL blueprint - improve installation script
pass the exit code from the install command to the install script
You can merge this pull request into a Git repository by running
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/920#issuecomment-142731738
@ygy can you review/test this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/920
Pass EntitlementContext to effectors
Do that explicitly for expunge
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/incubator
Github user bostko closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/916
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/917#issuecomment-142539074
Good to have more tests!
I think it is good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/916
Windows simple exit code Live test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/incubator-brooklyn
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/914
WinRm Test - fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/incubator-brooklyn
winrm_refactoring_execution
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/906#discussion_r39869652
--- Diff:
software/base/src/test/java/org/apache/brooklyn/entity/software/base/lifecycle/ScriptHelperUnitTest.java
---
@@ -0,0 +1,63
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/907#issuecomment-141444799
Good fixes. I like everything to be in one place.
OK to merge!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/907#discussion_r39851174
--- Diff: docs/guide/yaml/winrm/index.md ---
@@ -115,40 +116,172 @@ This is only a very simple example. A core complex
example can be found in the
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/907#discussion_r39849538
--- Diff: docs/guide/yaml/winrm/index.md ---
@@ -115,40 +116,172 @@ This is only a very simple example. A core complex
example can be found in the
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/907#discussion_r39849165
--- Diff: docs/guide/yaml/winrm/index.md ---
@@ -82,7 +82,8 @@ For example - here is a blueprint:
region: us-west-2
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/906
Capture exit code in AbstractSoftwareProcessWinrmDriver
- Refactor AbstractSoftwareProcessWinrmDriver implementation like
AbstractSoftwareProcessSshDriver
- ScriptHelperUnitTest exit
Github user bostko closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/905
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/905
ScriptHelper exit code test
- include test dependency EasyMock in brooklyn-software-base
You can merge this pull request into a Git repository by running:
$ git pull https
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/881#issuecomment-138328758
I will close this PR in favor of #877
The purpose of `CreateUserPolicyWithEntityLiveTest` is to verify that it
doesn't throw an exception.
Github user bostko closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/881
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/881
CreateUserPolicyWithEntityLiveTest
Verifies the behaviour of CreateUserPolicy
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/868#discussion_r3809
--- Diff:
core/src/main/java/org/apache/brooklyn/core/location/cloud/names/BasicCloudMachineNamer.java
---
@@ -41,9 +41,15 @@ protected String
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/866#discussion_r38088447
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/AbstractSoftwareProcessWinRmDriver.java
---
@@ -119,20 +136,53
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/866#issuecomment-135365840
@aledsage Thank you for the elaborative comments!
I fixed the addressed issues and added new config for powershell commands
for: post-install, pre-launch
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/866#discussion_r37966653
--- Diff:
core/src/test/java/org/apache/brooklyn/location/byon/ByonLocationResolverTest.java
---
@@ -345,7 +345,7 @@ public void
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/866#issuecomment-134934816
I will appreciate if anyone review it earlier.
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/866
Winrm commands stdin, stdout, stderr; Commands Live tests
This PR provides stdin, stderr and stdout support to the Windows commands.
Look the commits to see the changes
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/862#issuecomment-133361608
I think all fixes are correct.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/839
Ldap config fix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/incubator-brooklyn ldap_fixes
Alternatively you can review
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/831#issuecomment-131812084
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user bostko closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/816
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/816#issuecomment-130536456
@hzbarcea I saw it. You can test now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/816
[BROOKLYN-162] Renaming package brooklyn.location
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/incubator-brooklyn
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/815
BrooklynLauncherRebindCatalogTest
Fix test - assume the order on catalog rebind doesn't matter.
I didn't debug the actual rebinding code, but I assume since ids and
cata
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/808#issuecomment-129994305
@iyovcheva please check the osgi settings in usage/camp/src/test/resources/
---
If your project is set up for it, you can reply to this email and have your
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/784
LDAP authentication doc
Added an example brooklyn.properties for ldap
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/781#issuecomment-126631754
Good changes in both commits.
We will test it Live to confirm.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/780
Fix LDAP dc parameter
Fix LDAP connection parameter.
@grkvlt @aledsage Can you review it please?
You can merge this pull request into a Git repository by running:
$ git pull
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/778#issuecomment-126016545
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/777#issuecomment-126009012
Looks good to me too.
There is no breaking changes. Thank you for the refactoring!
---
If your project is set up for it, you can reply to this email and
Github user bostko closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/722
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user bostko closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/615
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/756
Kafka - fix escaping
Fixed the addressed issues
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/incubator-brooklyn
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/742#issuecomment-121922947
Yes it is just for the integration test, the java client doesn't implement
getting message, poll() is not implemented so I hardcoded this in the
integr
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/744#discussion_r34604623
--- Diff:
software/base/src/main/resources/brooklyn/entity/brooklynnode/brooklyn-node.yaml
---
@@ -22,8 +22,8 @@ name: Example Brooklyn Node
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/744
Update brooklyn-node.yaml example
Include the more reasonable `brooklynnode.distro.uploadurl` attribute in
the `brooklyn-node.yaml` example
You can merge this pull request into a Git
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/742
Fix KafkaIntegrationTest tests
- updated kafka version
- installing from binary instead of compiling from source
Note on `KafkaIntegrationTest.testTwoBrokerCluster`:
The
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/731#issuecomment-118779959
Svet suggested that everywhere we should use 0 as a default null value for
the average enricher because we could often have situations where some of the
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/732#issuecomment-118283018
I'd rather change the address in the `MongoDBShardClusterImpl`.
Also I think the getBrooklynAccessibleAddress is used for defining the
public u
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/731
Count the null values for the average enrichers
This fixes TomcatAutoScalerPolicyTest
Basically the problem is that after making a request to Tomcat uptade event
for
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/622#discussion_r33459189
--- Diff: docs/_build/build.sh ---
@@ -179,9 +179,20 @@ function test_site() {
}
function make_jekyll() {
+ if [ -f ../usage
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/722#issuecomment-116629151
Regarding java version check change.
`java -version` returns different output if openjdk is used
Example:
```
openjdk version "1.8
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/722#discussion_r33456465
--- Diff:
software/base/src/main/java/brooklyn/entity/java/JavaSoftwareProcessSshDriver.java
---
@@ -336,7 +336,7 @@ protected int tryJavaInstall
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/722#discussion_r3341
--- Diff:
software/webapp/src/test/java/brooklyn/entity/webapp/nodejs/NodeJsWebAppFixtureIntegrationTest.java
---
@@ -153,36 +140,16 @@ public
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/722
Fix NodeJsWebAppFixtureIntegrationTest
NFY
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/incubator-brooklyn test_fixes
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/615#issuecomment-114518589
I tested with [these
queries](http://docs.basho.com/riak/latest/dev/using/search) and it works
correctly
---
If your project is set up for it, you can
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/710
Remove obsolete Tomcat fail binding test
Basically the behavior was that it was expecting
`LocalhostMachineProvisioningLocation.obtainSpecificPort` to throw an exception
"por
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/707#issuecomment-114043722
Looks good. @ygy Can you remove sudo from the firewall-cmd related methods
in IptablesCommands.
This will improve the readability of
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/701#issuecomment-113613328
Very good changes, thank you!
I tested the cluster avarage values with
https://github.com/apache/incubator-brooklyn/blob/master/examples/simple-web
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/699
Fix JBoss6Server Integration Test
Remove unnecessary HOSTNAME vs ROOT_URL comparison
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/693
Fix for Java 8 compile error
remove final in order to fix variable initialization concern
You can merge this pull request into a Git repository by running:
$ git pull https
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/615#issuecomment-101074109
I didn't pay attention that Riak installs Solr on its own
http://docs.basho.com/riak/latest/ops/advanced/configs/search/#JVM-Installation
So we need
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/626
Riak bugfix
- Basho pulled out 2.1.0, reverted default version to 2.0.5
- packagecloud url was changed
You can merge this pull request into a Git repository by running:
$ git
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/615#issuecomment-98918998
I included non Solr specific fixes also.
@neykov Can you look at this. I think it is acceptable solution.
---
If your project is set up for it, you can
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/622
Revert the eager loading of the catalog items
Currently loading the documentation of a catalog item is little slow. I
think for the catalog items particularly, there is no reason for
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/615#issuecomment-97356931
This code is working and all of the entities are in green although I didn't
test with search queries against riak.
I will be grateful if you give me
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/615
Add Solr support
For review
Do not merge
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/incubator-brooklyn riak-solr
Github user bostko commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/612#discussion_r29048593
--- Diff:
software/webapp/src/main/java/brooklyn/entity/webapp/nodejs/NodeJsWebAppSshDriver.java
---
@@ -128,12 +124,19 @@ public void customize
GitHub user bostko opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/612
Nodejs riak sample app
- Refactoring the NodeJsWebAppSshDriver .
Install packages from package.json as non-root
You can merge this pull request into a Git repository by running
1 - 100 of 149 matches
Mail list logo
