[GitHub] incubator-brooklyn pull request: EntitySpec duplication should inc...

2015-11-20 Thread duncangrant
GitHub user duncangrant opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1051 EntitySpec duplication should include children If the memberspec of a dynamiccluster had a child entityspec then it would not be possible to set or expand the cluster to more than

[GitHub] incubator-brooklyn pull request: Fix cassandra for use in private ...

2015-09-17 Thread duncangrant
Github user duncangrant commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/897#issuecomment-141019059 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-brooklyn pull request: Describes AWS VPC issue

2015-06-23 Thread duncangrant
GitHub user duncangrant opened a pull request: https://github.com/apache/incubator-brooklyn/pull/711 Describes AWS VPC issue This describes the issue discussed on #705 https://github.com/apache/incubator-brooklyn/pull/705 You can merge this pull request into a Git repository by

[GitHub] incubator-brooklyn pull request: Catalog default niceness

2015-06-23 Thread duncangrant
Github user duncangrant commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/705#issuecomment-114416055 @ahgittin that change certainly seems to fix both issues I was having --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-brooklyn pull request: Catalog default niceness

2015-06-22 Thread duncangrant
Github user duncangrant commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/705#issuecomment-114259415 @ahgittin All the components fail. I can easily replicate with the following using master so you're right : name: Empty large S

[GitHub] incubator-brooklyn pull request: Catalog default niceness

2015-06-22 Thread duncangrant
Github user duncangrant commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/705#issuecomment-114076473 The Resilient Load-Balanced Web Cluster fails for me with a VPCResourceNotSpecified error. --- If your project is set up for it, you can reply to this

[GitHub] incubator-brooklyn pull request: Rabbit mq management flag

2015-04-08 Thread duncangrant
Github user duncangrant commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/584#issuecomment-90868528 Tests pass --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-brooklyn pull request: Rabbit mq management flag

2015-04-07 Thread duncangrant
Github user duncangrant commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/584#issuecomment-90619119 Goog point - I'll run the live tests in the morning (both before and after changes) --- If your project is set up for it, you can reply to this

[GitHub] incubator-brooklyn pull request: Rabbit mq management flag

2015-04-07 Thread duncangrant
Github user duncangrant commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/584#discussion_r27891098 --- Diff: software/messaging/src/main/java/brooklyn/entity/messaging/rabbit/RabbitSshDriver.java --- @@ -124,11 +125,21 @@ public void

[GitHub] incubator-brooklyn pull request: Rabbit mq management flag

2015-04-07 Thread duncangrant
Github user duncangrant commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/584#issuecomment-90611602 I think I've covered all Sam's review points. Once he is happy I'll squash the commits. --- If your project is set up for it, you ca

[GitHub] incubator-brooklyn pull request: Rabbit mq management flag

2015-04-07 Thread duncangrant
Github user duncangrant commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/584#discussion_r27878528 --- Diff: software/messaging/src/main/java/brooklyn/entity/messaging/rabbit/RabbitSshDriver.java --- @@ -124,11 +123,20 @@ public void

[GitHub] incubator-brooklyn pull request: Rabbit mq management flag

2015-04-07 Thread duncangrant
Github user duncangrant commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/584#discussion_r27869686 --- Diff: software/messaging/src/main/java/brooklyn/entity/messaging/rabbit/RabbitSshDriver.java --- @@ -186,6 +195,11 @@ public void kill

[GitHub] incubator-brooklyn pull request: Rabbit mq management flag

2015-04-07 Thread duncangrant
GitHub user duncangrant opened a pull request: https://github.com/apache/incubator-brooklyn/pull/584 Rabbit mq management flag Add flag enableManagementPlugin defaulting to false You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-brooklyn pull request: Cobertura to use maven plugin rat...

2015-02-27 Thread duncangrant
Github user duncangrant commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/455#issuecomment-76410811 The current ant-run based integration does produce output.xml. This is useful for integration with jenkins and if we want to produce reports from the

[GitHub] incubator-brooklyn pull request: Cobertura to use maven plugin rat...

2015-02-27 Thread duncangrant
Github user duncangrant closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/455 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-brooklyn pull request: Notes on setting up BYON nodes

2015-02-16 Thread duncangrant
GitHub user duncangrant opened a pull request: https://github.com/apache/incubator-brooklyn/pull/514 Notes on setting up BYON nodes @aledsage I don't think I need to go into much detail here but you may disagree. You can merge this pull request into a Git repository by ru

[GitHub] incubator-brooklyn pull request: Softlayer safe name length

2015-02-03 Thread duncangrant
Github user duncangrant commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/500#issuecomment-72635156 @andreaturli thanks - Squashed and rebased --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-brooklyn pull request: Softlayer safe name length

2015-02-03 Thread duncangrant
Github user duncangrant commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/500#issuecomment-72626276 @andreaturli So I think it is something to do with the length of the name of the blueprint. I'll dig into the code a bit but can you confirm tha

[GitHub] incubator-brooklyn pull request: Softlayer safe name length

2015-02-02 Thread duncangrant
Github user duncangrant commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/500#issuecomment-72481298 Yes - I should have been clearer. The values I was reporting were the values in the JcloudsMachineNAmer - so the fqdn length not the hostname length

[GitHub] incubator-brooklyn pull request: Softlayer safe name length

2015-02-02 Thread duncangrant
Github user duncangrant commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/500#issuecomment-72480513 @andreaturli I'm not sure i understand your question. The 9 chars are taken from the length either way so when the custom length is set

[GitHub] incubator-brooklyn pull request: Softlayer safe name length

2015-02-02 Thread duncangrant
Github user duncangrant commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/500#issuecomment-72467454 I should Have tried running this with a debugger to see what is going on. I'll let you know. --- If your project is set up for it, you can rep

[GitHub] incubator-brooklyn pull request: Softlayer safe name length

2015-02-02 Thread duncangrant
GitHub user duncangrant opened a pull request: https://github.com/apache/incubator-brooklyn/pull/500 Softlayer safe name length After extensive testing it would appear that: - anything up to 55 chars seems to be fine. - 56-58 characters you could jclouds exceptions while

[GitHub] incubator-brooklyn pull request: Cobertura to use maven plugin rat...

2015-01-30 Thread duncangrant
Github user duncangrant commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/455#issuecomment-72212305 The suggested fix is quite messy. Perhaps it would be better to just accept that we can't run coverage on a mac running 1.6? --- If your project i

[GitHub] incubator-brooklyn pull request: Cobertura to use maven plugin rat...

2015-01-21 Thread duncangrant
Github user duncangrant commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/455#issuecomment-70823014 What java version are you using? I'm using oracle jdk 1.7 - Alasdair thinks it might be to do with this. --- If your project is set up for it, yo

[GitHub] incubator-brooklyn pull request: Cobertura to use maven plugin rat...

2015-01-16 Thread duncangrant
GitHub user duncangrant opened a pull request: https://github.com/apache/incubator-brooklyn/pull/455 Cobertura to use maven plugin rather than ant-run PLEASE DON'T MERGE YET Seems to lose ability to output xml but does give us an aggregated report. Also when r

[GitHub] incubator-brooklyn pull request: Upgrade cobertura plus minor fixe...

2015-01-15 Thread duncangrant
Github user duncangrant commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/451#discussion_r23008377 --- Diff: pom.xml --- @@ -1657,8 +1658,8 @@ Coverage

[GitHub] incubator-brooklyn pull request: Upgrade cobertura plus minor fixe...

2015-01-15 Thread duncangrant
GitHub user duncangrant opened a pull request: https://github.com/apache/incubator-brooklyn/pull/451 Upgrade cobertura plus minor fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/duncangrant/incubator-brooklyn cobertura

[GitHub] incubator-brooklyn pull request: Documentation fixes

2015-01-06 Thread duncangrant
GitHub user duncangrant opened a pull request: https://github.com/apache/incubator-brooklyn/pull/433 Documentation fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/duncangrant/incubator-brooklyn feature/fix-docs

[GitHub] incubator-brooklyn pull request: Changed solr entity to use java i...

2014-12-01 Thread duncangrant
GitHub user duncangrant opened a pull request: https://github.com/apache/incubator-brooklyn/pull/368 Changed solr entity to use java interfaces Added main uri attribute to SolrServer entity Configured service up check to work with docker You can merge this pull request into a

[GitHub] incubator-brooklyn pull request: Replaced deprecated constructor

2014-12-01 Thread duncangrant
GitHub user duncangrant opened a pull request: https://github.com/apache/incubator-brooklyn/pull/367 Replaced deprecated constructor So as not to break usage of deprecated class You can merge this pull request into a Git repository by running: $ git pull https://github.com