Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1066#issuecomment-159929897
Thanks @ahgittin, @mikezaccardo, code updated as per comments above.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1066#discussion_r45849941
--- Diff:
usage/test-framework/src/main/java/org/apache/brooklyn/test/framework/SimpleShellCommandTest.java
---
@@ -87,21 +90,24
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1066#discussion_r45845108
--- Diff:
usage/test-framework/src/main/java/org/apache/brooklyn/test/framework/TestHttpCallImpl.java
---
@@ -66,31 +68,35 @@ public void start
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1066#discussion_r45844605
--- Diff:
usage/test-framework/src/main/java/org/apache/brooklyn/test/framework/SimpleShellCommandTest.java
---
@@ -87,21 +90,24
GitHub user geomacy opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1066
Updates to Test framework assertions to support multiple assertion failures.
At the moment in the test framework, as noted in
[#1030](https://github.com/apache/incubator-brooklyn/pull
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1030#issuecomment-158997862
I'll resolve the merge conflicts. I think I'd like to do the changes to
the assertions as a separate PR, it seems to be a bit of 'missi
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1030#issuecomment-158995925
I had a look today at using the new general purpose TestFrameworkAssertions
as per Alexâs comment
[above](https://github.com/apache/incubator-brooklyn
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1030#discussion_r45322611
--- Diff:
usage/test-framework/src/main/java/org/apache/brooklyn/test/framework/SimpleShellCommandTestImpl.java
---
@@ -0,0 +1,315
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1030#issuecomment-157748186
Re-opening PR as noted above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user geomacy closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1030
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1030#issuecomment-157748032
Commit includes updates as suggested by Aled, and also collapses the test
classes so that there is now just the one interface SimpleShellCommandTest and
GitHub user geomacy reopened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1030
SimpleCommand addition to brooklyn-test-framework
### Description
An additional feature for the brooklyn-test-framework.
Supports a test that runs a simple command
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1030#issuecomment-157727948
Forgot to mark tests as integration, will do so now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1032#issuecomment-157689774
Release notes updated and changes squashed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1030#issuecomment-157683343
Iâve made most of the changes to the simple command classes from the
review comments. The driver is gone, but I have had trouble trying to get rid
of
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1032#issuecomment-157673865
I've updated the core tool and response classes in
[14945f7](https://github.com/apache/incubator-brooklyn/commit/14945f75b1e0a4a5cc17dbb30459d092649
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1032#issuecomment-157391964
i.e. remove it altogether? Yes, I'll update the pull request accordingly.
---
If your project is set up for it, you can reply to this email and have
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1030#issuecomment-157388335
I want to be able to make assertions on the exit code, standard out and
error, so .requiringZeroAndReturningStandardOut wouldn't cover that.
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1030#discussion_r45050093
--- Diff:
usage/test-framework/src/main/java/org/apache/brooklyn/test/framework/SimpleCommand.java
---
@@ -0,0 +1,50
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1032#issuecomment-157317157
Or rather, should I just close this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1032#issuecomment-157316451
Ok, I shall leave this as-is then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1030#issuecomment-156983714
Thanks for all the comments Aled, if I haven't responded to any particular
one it's because I'll just go ahead with it. Will get on to mak
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1030#discussion_r44907814
--- Diff:
usage/test-framework/src/test/java/org/apache/brooklyn/test/framework/SimpleCommandImplIntegrationTest.java
---
@@ -0,0 +1,112
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1030#discussion_r44907503
--- Diff:
usage/test-framework/src/main/java/org/apache/brooklyn/test/framework/SimpleCommandSshDriver.java
---
@@ -0,0 +1,192
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1030#discussion_r44902950
--- Diff:
usage/test-framework/src/main/java/org/apache/brooklyn/test/framework/SimpleCommandImpl.java
---
@@ -0,0 +1,177
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1030#discussion_r44902697
--- Diff:
usage/test-framework/src/main/java/org/apache/brooklyn/test/framework/SimpleCommandImpl.java
---
@@ -0,0 +1,177
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1030#discussion_r44902605
--- Diff:
usage/test-framework/src/main/java/org/apache/brooklyn/test/framework/SimpleCommandImpl.java
---
@@ -0,0 +1,177
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1030#discussion_r44902571
--- Diff:
usage/test-framework/src/main/java/org/apache/brooklyn/test/framework/SimpleCommand.java
---
@@ -0,0 +1,50
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1030#discussion_r44902393
--- Diff:
usage/test-framework/src/main/java/org/apache/brooklyn/test/framework/SimpleCommand.java
---
@@ -0,0 +1,50
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1032#issuecomment-156574267
Will do that, thanks Aled.
G
On Fri, 13 Nov 2015 22:11 Aled Sage wrote:
> Thanks @geomacy <https://github.com/geomacy&
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/994#issuecomment-156502758
Have added the changes in
https://github.com/apache/incubator-brooklyn/pull/1032
---
If your project is set up for it, you can reply to this email and have
GitHub user geomacy opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1032
Restore old HttpTool / Response for backward compatibility
PR follow-up to comment
https://github.com/apache/incubator-brooklyn/pull/994#discussion_r44706399
You can merge this pull
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/994#issuecomment-156472799
hi @neykov, sorry I had indeed missed this comment. Will make changes as
you say.
---
If your project is set up for it, you can reply to this email and
GitHub user geomacy opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1030
SimpleCommand addition to brooklyn-test-framework
### Description
An additional feature for the brooklyn-test-framework.
Supports a test that runs a simple command
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1005#issuecomment-154354670
Thanks very much @ahgittin! I shall treat the task of separating any
"non-slow" tests from the rest as a low priority, as you say.
---
If yo
GitHub user geomacy opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1004
Make the HttpAssertsTest an integration test for now.
Later task will be to restructure to avoid sleeps where possible, see
conversation at
https://github.com/apache/incubator
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1000#issuecomment-154094942
Working on that now, per the conversation at
https://github.com/apache/incubator-brooklyn/pull/994#issuecomment-154074295
---
If your project is set up
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/994#issuecomment-154087549
I will move them to integration now and add a note to restructure in
future, but I will try to make that the near future while it's fresh in my
head. T
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/994#issuecomment-154074295
The sleeps are there to allow the test HTTP server time to shut down.
That's not required in all tests, so I could speed things up a bit by changing
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/994#issuecomment-153647425
Thanks @ahgittin and @aledsage for the comments. I have made some further
updates which I think address them all, but let me know if I've missed any
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/994#issuecomment-153148702
hi Alex et al. I have made the changes related to the comments by Alex in
the commits
[above](https://github.com/apache/incubator-brooklyn/pull/994#commits
Github user geomacy commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/995#issuecomment-153065910
@ahgittin will do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user geomacy opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/994
Add EntityAsserts and HttpUtils.
This are added to allow core code to make assertions on entities without
without having a dependency on TestNG.
For now, deprecate
GitHub user geomacy opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/969
Docflow amendments
Pull request with a number of minor updates to documentation, arising from
Belfast 'First Encounter'
(https://docs.google.com/
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/966#discussion_r42393804
--- Diff: docs/guide/start/concept-quickstart.md ---
@@ -0,0 +1,35 @@
+---
+title: Brooklyn Concepts Quickstart
+layout: website
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/966#discussion_r42393337
--- Diff: docs/guide/start/concept-quickstart.md ---
@@ -0,0 +1,35 @@
+---
+title: Brooklyn Concepts Quickstart
+layout: website
GitHub user geomacy opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/966
Add a "quick overview of concepts" page to Getting Started.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/geomacy
GitHub user geomacy opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/954
Amend text in creating-yaml.md
Amended paragraph in section "The Basic Structure" to clarify reference to
the copy icon and to add some apparently missing text.
You can merge
GitHub user geomacy opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/882
Fix broken link in top level README
Fixing link to developer guide.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/geomacy
49 matches
Mail list logo
