Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/616#discussion_r29843195
--- Diff:
usage/rest-api/src/main/java/brooklyn/rest/api/ApplicationApi.java ---
@@ -76,6 +76,12 @@ public JsonNode fetch(
valu
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/616#issuecomment-99818781
Looks like I'm a bit late to the party :), nvm just minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/616#discussion_r29842851
--- Diff:
usage/rest-api/src/main/java/brooklyn/rest/api/ApplicationApi.java ---
@@ -76,6 +76,12 @@ public JsonNode fetch(
value =
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/616#discussion_r29842548
--- Diff:
usage/rest-api/src/main/java/brooklyn/rest/api/ApplicationApi.java ---
@@ -76,6 +76,12 @@ public JsonNode fetch(
value =
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/616
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/616#discussion_r29659456
--- Diff: core/src/main/java/brooklyn/entity/basic/EntityPredicates.java ---
@@ -271,9 +274,38 @@ public boolean apply(@Nullable Entity input) {
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/616#issuecomment-98403388
@sjcorbett looks really good. Do you want to get rid of the unused import
in `ApplicationResource` and then merge?
---
If your project is set up for it, yo
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/616#discussion_r29550873
--- Diff:
usage/rest-server/src/main/java/brooklyn/rest/resources/ApplicationResource.java
---
@@ -79,9 +83,11 @@
import brooklyn.util.coll
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/616#discussion_r29550865
--- Diff:
usage/rest-server/src/main/java/brooklyn/rest/resources/ApplicationResource.java
---
@@ -216,9 +222,18 @@ public JsonNode fetch(String
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/616#discussion_r29550849
--- Diff: core/src/main/java/brooklyn/entity/basic/EntityPredicates.java ---
@@ -271,9 +274,38 @@ public boolean apply(@Nullable Entity input) {
GitHub user sjcorbett opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/616
EntityPredicates.hasInterfaceMatching
And uses as optional query parameter in ApplicationApi.list.
You can merge this pull request into a Git repository by running:
$ git pull htt
11 matches
Mail list logo
