[GitHub] incubator-brooklyn pull request: Fix service-not-up-diagnostics, a...

2015-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/912 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-brooklyn pull request: Fix service-not-up-diagnostics, a...

2015-09-21 Thread aledsage
Github user aledsage commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/912#issuecomment-142028481 Thanks @rdowner - jenkins has now confirmed that the tests pass. Merging. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] incubator-brooklyn pull request: Fix service-not-up-diagnostics, a...

2015-09-21 Thread aledsage
Github user aledsage commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/912#issuecomment-141979056 I've rebased against master (now that test is fixed in #913 ); can see if asfbot is happy now. --- If your project is set up for it, you can reply to this

[GitHub] incubator-brooklyn pull request: Fix service-not-up-diagnostics, a...

2015-09-21 Thread rdowner
Github user rdowner commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/912#issuecomment-141969594 Code looks OK. Jenkins PR builder reports failure, but this appears to be due to PR #909 breaking master. --- If your project is set up for it, you can repl

[GitHub] incubator-brooklyn pull request: Fix service-not-up-diagnostics, a...

2015-09-21 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/incubator-brooklyn/pull/912 Fix service-not-up-diagnostics, add subscription.notifyOfInitialValue, etc Various fixes for things encountered (or speculatively encountered for "notifyOfInitialValue"!) when testing u