Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#issuecomment-151539546
@geomacy +1 to these living in catalog, sooner rather than later. see the
email thread.
---
If your project is set up for it, you can reply to this email
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/987
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#issuecomment-151525296
@geomacy I believe this is on the roadmap, but out of scope for this PR.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r43128732
--- Diff:
core/src/main/java/org/apache/brooklyn/core/objs/AbstractBrooklynObject.java ---
@@ -55,8 +57,18 @@
@SetFromFlag(value = "tags")
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#issuecomment-151502821
+1 for the double dispatch and `RelationshipType`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#issuecomment-151502672
Perfect! Will merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r43122838
--- Diff:
core/src/main/java/org/apache/brooklyn/core/relations/ByObjectBasicRelationSupport.java
---
@@ -0,0 +1,104 @@
+/*
+ * Licensed t
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#issuecomment-151492373
all changes pushed, including `RelationshipType` and removed generics, and
comments for the double dispatch. need to see if tests pass but otherwise
ready
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#issuecomment-151477166
Re generics -- your intuition is spot on. There were relatively few places
we had to add the correctly-generically-typed interface methods and trivial
cast
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#issuecomment-151469204
I've added a comment on the double dispatch via `EntityRelations` statics:
```
/** This abstract impl delegates to {@link EntityRelations} for al
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#issuecomment-151464184
Very helpful comments @neykov . Have done most of them; still need to:
* Think about `SelfType` generics
* Check double dispatch
I saw
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r43109679
--- Diff:
core/src/main/java/org/apache/brooklyn/core/relations/ByObjectBasicRelationSupport.java
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r43108978
--- Diff:
core/src/main/java/org/apache/brooklyn/core/objs/AbstractBrooklynObject.java ---
@@ -55,8 +57,18 @@
@SetFromFlag(value = "tags
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r43107916
--- Diff:
core/src/main/java/org/apache/brooklyn/core/entity/EntityRelations.java ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache So
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r43107795
--- Diff:
api/src/main/java/org/apache/brooklyn/api/objs/BrooklynObject.java ---
@@ -141,4 +149,11 @@
*/
boolean unsub
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r43107521
--- Diff:
core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogItemDo.java
---
@@ -65,6 +64,19 @@ public SubscriptionSupportInter
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r43106895
--- Diff:
api/src/main/java/org/apache/brooklyn/api/mgmt/rebind/mementos/Memento.java ---
@@ -77,7 +79,8 @@
public Collection getT
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r43101977
--- Diff: api/src/main/java/org/apache/brooklyn/api/objs/Configurable.java
---
@@ -41,6 +41,11 @@
@Deprecated
public T setConf
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r43101561
--- Diff:
api/src/main/java/org/apache/brooklyn/api/objs/BrooklynObject.java ---
@@ -141,4 +149,11 @@
*/
boolean unsub
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#issuecomment-150919995
All good! Only minor comments.
What I strongly feel should be removed is the `PublicSelfType` and
`PrivateSelfType` generic types, unless there's a good te
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r42944179
--- Diff:
core/src/main/java/org/apache/brooklyn/core/relations/ByObjectBasicRelationSupport.java
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed t
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r42942650
--- Diff:
core/src/main/java/org/apache/brooklyn/core/objs/AbstractBrooklynObject.java ---
@@ -55,8 +57,18 @@
@SetFromFlag(value = "tags")
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r42942578
--- Diff:
core/src/main/java/org/apache/brooklyn/core/objs/AbstractBrooklynObject.java ---
@@ -55,8 +57,18 @@
@SetFromFlag(value = "tags")
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r42934310
--- Diff:
core/src/main/java/org/apache/brooklyn/core/entity/EntityRelations.java ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Soft
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r42934160
--- Diff:
api/src/main/java/org/apache/brooklyn/api/objs/BrooklynObject.java ---
@@ -141,4 +149,11 @@
*/
boolean unsubsc
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r42882539
--- Diff:
core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogItemDo.java
---
@@ -65,6 +64,19 @@ public SubscriptionSupportInterna
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r42882151
--- Diff:
api/src/main/java/org/apache/brooklyn/api/mgmt/rebind/mementos/Memento.java ---
@@ -77,7 +79,8 @@
public Collection getTag
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r42876869
--- Diff:
core/src/main/java/org/apache/brooklyn/core/objs/BrooklynObjectInternal.java ---
@@ -31,12 +31,12 @@
import com.google.common.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r42873976
--- Diff: api/src/main/java/org/apache/brooklyn/api/objs/Configurable.java
---
@@ -41,6 +41,11 @@
@Deprecated
public T setConfig
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r42873240
--- Diff: api/src/main/java/org/apache/brooklyn/api/objs/Configurable.java
---
@@ -41,6 +41,11 @@
@Deprecated
public T setConfig
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/987#discussion_r42872387
--- Diff:
api/src/main/java/org/apache/brooklyn/api/objs/BrooklynObject.java ---
@@ -141,4 +149,11 @@
*/
boolean unsubsc
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/987
Introduce relationships between brooklyn objects
adds BrooklynObject.relations() and relationships such as MANAGER_OF and
IN_GROUP.
includes tests, also convering persistence.
a
32 matches
Mail list logo
