[GitHub] incubator-brooklyn pull request: Readding dependency on jackson-ja...

2015-11-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1060 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-brooklyn pull request: Readding dependency on jackson-ja...

2015-11-24 Thread sjcorbett
Github user sjcorbett commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1060#issuecomment-159278410 @m4rkmckenna Thanks. Will merge this. By the way, If you use IntelliJ you can configure it to add the license header automatically when creating

[GitHub] incubator-brooklyn pull request: Readding dependency on jackson-ja...

2015-11-24 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1060#issuecomment-159247878 Added header and squashed my bad should have run a build when i added the bom --- If your project is set up for it, you can reply to this email a

[GitHub] incubator-brooklyn pull request: Readding dependency on jackson-ja...

2015-11-24 Thread sjcorbett
Github user sjcorbett commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1060#issuecomment-159241967 The Jenkins check is valid this time: ``` [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check (default) on project brook

[GitHub] incubator-brooklyn pull request: Readding dependency on jackson-ja...

2015-11-24 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1060#discussion_r45719555 --- Diff: usage/rest-client/src/test/java/org/apache/brooklyn/rest/client/BrooklynApiRestClientTest.java --- @@ -98,11 +98,21 @@ public void t

[GitHub] incubator-brooklyn pull request: Readding dependency on jackson-ja...

2015-11-24 Thread m4rkmckenna
GitHub user m4rkmckenna opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1060 Readding dependency on jackson-jaxrs to brooklyn-rest-client You can merge this pull request into a Git repository by running: $ git pull https://github.com/m4rkmckenna/incuba