[GitHub] [incubator-brpc] ufosky commented on issue #926: 为什么只有连接池模式才能关闭空闲连接

2019-09-22 Thread GitBox
ufosky commented on issue #926: 为什么只有连接池模式才能关闭空闲连接 URL: https://github.com/apache/incubator-brpc/issues/926#issuecomment-533951655 使用SelectiveChannel将正常节点和备用节点放到不同的subchannel里面,然后通过策略让一般情况选择正常节点的subchannel,但是现在的问题是一旦备用节点的channel建立了连接,就一直不断开了

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #929: add license to file that missing it

2019-09-22 Thread GitBox
jamesge commented on a change in pull request #929: add license to file that missing it URL: https://github.com/apache/incubator-brpc/pull/929#discussion_r326942152 ## File path: src/butil/file_util_linux.cc ## @@ -5,16 +5,31 @@ #include "butil/file_util.h" #include

[GitHub] [incubator-brpc] cdjingit commented on issue #926: 为什么只有连接池模式才能关闭空闲连接

2019-09-22 Thread GitBox
cdjingit commented on issue #926: 为什么只有连接池模式才能关闭空闲连接 URL: https://github.com/apache/incubator-brpc/issues/926#issuecomment-533944014 > 如果要让单连接模式可以关闭空闲连接,可以怎么实现? 如果节点没有被ns移除,你们如何让他空闲下来的?(如何让lb不选择这些backup节点?) This is an

Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02

2019-09-22 Thread tan zhongyi
OK, if you has merged all your change, Please make a tag, and we can go with rc03. Thanks 在 2019/9/22 下午5:53,“JiashunZhu” 写入: zhongyi, For 2,5&7, I think it is not necessary to expand the license header of boost, respecting the original license since they don't expand it

[GitHub] [incubator-brpc] zyearn opened a new pull request #929: add license to file that missing it

2019-09-22 Thread GitBox
zyearn opened a new pull request #929: add license to file that missing it URL: https://github.com/apache/incubator-brpc/pull/929 This is an automated message from the Apache Git Service. To respond to the message, please

Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc02

2019-09-22 Thread JiashunZhu
forgot to mention that I notice src/butil/linux_magic.h is referenced from linux kernel which has a GPL2.0 license, so I deleted it from source code. https://elixir.bootlin.com/linux/v5.0.21/source/include/uapi/linux/magic.h JiashunZhu 于2019年9月22日周日 下午5:53写道: > zhongyi, > > For 2,5&7, I