Re: [VOTE] Release Apache brpc(incubating) 0.9.6-rc03

2019-10-07 Thread Tan,Zhongyi
Thanks for your input, Von I will check with jiashun to clean these issues. Thanks 在 2019/9/27 下午3:03,“Gosling Von” 写入: Hi, -1, there are still many places need to be corrected. 1. Highly recommended use the apache mail to sign your release while not zhujiashun

[GitHub] [incubator-brpc] MR-workaholic commented on issue #824: fix lalb be disabled wrongly

2019-10-07 Thread GitBox
MR-workaholic commented on issue #824: fix lalb be disabled wrongly URL: https://github.com/apache/incubator-brpc/pull/824#issuecomment-539286264 @zyearn 哪具体哪些情况会出现"_base_weight is accidentally set to 0"?看代码,下游服务出现超长延时或者每个服务的平均weight小于1才会出现这种情况。而且“每个服务的平均weight小于1”会出现吗? ---

[GitHub] [incubator-brpc] jamesge commented on issue #852: bad performance for ParseFromCompressedData

2019-10-07 Thread GitBox
jamesge commented on issue #852: bad performance for ParseFromCompressedData URL: https://github.com/apache/incubator-brpc/issues/852#issuecomment-539297450 @libratiger > 如果自己比较明确数据格式的画,可以尝试streaming rpc,这个里面没有调用Pb的反序列化,brpc会把IOBuf交给用户来处理。 碰到这种场景,一般用http + body是pb更合理一些,brpc中的streaming

[GitHub] [incubator-brpc] jamesge edited a comment on issue #852: bad performance for ParseFromCompressedData

2019-10-07 Thread GitBox
jamesge edited a comment on issue #852: bad performance for ParseFromCompressedData URL: https://github.com/apache/incubator-brpc/issues/852#issuecomment-539297450 @libratiger > 如果自己比较明确数据格式的画,可以尝试streaming rpc,这个里面没有调用Pb的反序列化,brpc会把IOBuf交给用户来处理。 碰到这种场景,一般用http + body是pb更合理一些,brp

[GitHub] [incubator-brpc] MaggieCui opened a new issue #936: server端正常,但是服务端收到错误码

2019-10-07 Thread GitBox
MaggieCui opened a new issue #936: server端正常,但是服务端收到错误码 URL: https://github.com/apache/incubator-brpc/issues/936 在服务端正常的情况下,客户端首次请求收到110的错误,重试三次收到112的错误,这个问题要怎么排查? E1005 11:24:48.301865 2170565 heartbeat.cpp:333] 10.198.136.138:8204 Fail to send heartbeat to MDS 10.198.136.132:, **cn

[GitHub] [incubator-brpc] llhe opened a new pull request #937: Support symlink for config find_bin

2019-10-07 Thread GitBox
llhe opened a new pull request #937: Support symlink for config find_bin URL: https://github.com/apache/incubator-brpc/pull/937 For example, to configure the brpc build with self-built version of protobuf/protoc, like this: ``` $ ll third_party/install/protobuf/bin/ total 57412

[GitHub] [incubator-brpc] libratiger commented on issue #852: bad performance for ParseFromCompressedData

2019-10-07 Thread GitBox
libratiger commented on issue #852: bad performance for ParseFromCompressedData URL: https://github.com/apache/incubator-brpc/issues/852#issuecomment-539301544 > @libratiger > > > 如果自己比较明确数据格式的画,可以尝试streaming rpc,这个里面没有调用Pb的反序列化,brpc会把IOBuf交给用户来处理。 > > 碰到这种场景,一般用http + body是pb更

[GitHub] [incubator-brpc] jamesge commented on issue #933: 是否支持multipart/form-data的解析

2019-10-07 Thread GitBox
jamesge commented on issue #933: 是否支持multipart/form-data的解析 URL: https://github.com/apache/incubator-brpc/issues/933#issuecomment-539302178 目前不支持上传超大文件(持续传输) This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-brpc] jamesge commented on issue #935: 咨询一下,brpc 客户端能支持绑定一个特定的IP吗?

2019-10-07 Thread GitBox
jamesge commented on issue #935: 咨询一下,brpc 客户端能支持绑定一个特定的IP吗? URL: https://github.com/apache/incubator-brpc/issues/935#issuecomment-539303038 Channel创建时可以指定ip。如果你需要获得某次访问选择的机器的话,调用Controller::remote_side() This is an automated

[GitHub] [incubator-brpc] jamesge commented on issue #936: server端正常,但是客户端收到错误码

2019-10-07 Thread GitBox
jamesge commented on issue #936: server端正常,但是客户端收到错误码 URL: https://github.com/apache/incubator-brpc/issues/936#issuecomment-539306279 这个错误的表面原因是[连续3次](https://github.com/apache/incubator-brpc/blob/fc07b7bf45c4b2aa90ae5c832f3b48a8da124640/src/brpc/socket.cpp#L93)rpc超时触发熔断,client会对那个server[每隔

[GitHub] [incubator-brpc] MaggieCui commented on issue #936: server端正常,但是客户端收到错误码

2019-10-07 Thread GitBox
MaggieCui commented on issue #936: server端正常,但是客户端收到错误码 URL: https://github.com/apache/incubator-brpc/issues/936#issuecomment-539317987 > 这个错误的表面原因是[连续3次](https://github.com/apache/incubator-brpc/blob/fc07b7bf45c4b2aa90ae5c832f3b48a8da124640/src/brpc/socket.cpp#L93)rpc超时触发熔断,client会对那个serve

[GitHub] [incubator-brpc] MaggieCui edited a comment on issue #936: server端正常,但是客户端收到错误码

2019-10-07 Thread GitBox
MaggieCui edited a comment on issue #936: server端正常,但是客户端收到错误码 URL: https://github.com/apache/incubator-brpc/issues/936#issuecomment-539317987 > 这个错误的表面原因是[连续3次](https://github.com/apache/incubator-brpc/blob/fc07b7bf45c4b2aa90ae5c832f3b48a8da124640/src/brpc/socket.cpp#L93)rpc超时触发熔断,client会对

[GitHub] [incubator-brpc] jamesge edited a comment on issue #936: server端正常,但是客户端收到错误码

2019-10-07 Thread GitBox
jamesge edited a comment on issue #936: server端正常,但是客户端收到错误码 URL: https://github.com/apache/incubator-brpc/issues/936#issuecomment-539306279 这个错误的表面原因是[连续3次](https://github.com/apache/incubator-brpc/blob/fc07b7bf45c4b2aa90ae5c832f3b48a8da124640/src/brpc/socket.cpp#L93)连接超时触发熔断,client会对那个ser

[GitHub] [incubator-brpc] jamesge commented on issue #936: server端正常,但是客户端收到错误码

2019-10-07 Thread GitBox
jamesge commented on issue #936: server端正常,但是客户端收到错误码 URL: https://github.com/apache/incubator-brpc/issues/936#issuecomment-539350676 检查下日志中是否有连续的Connection timed out This is an automated message from the Apache Git Service. T

[GitHub] [incubator-brpc] MaggieCui commented on issue #936: server端正常,但是客户端收到错误码

2019-10-07 Thread GitBox
MaggieCui commented on issue #936: server端正常,但是客户端收到错误码 URL: https://github.com/apache/incubator-brpc/issues/936#issuecomment-539351202 > 检查下日志中是否有连续的Connection timed out 没有连续的。偶尔出现一下,我们这边是每隔10s发送一次,本次失败,下次就成功了 This is

[incubator-brpc] 01/03: remove exec bit from two source files

2019-10-07 Thread jamesge
This is an automated email from the ASF dual-hosted git repository. jamesge pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git commit c155614a4015c9ba460386fc0986d4ff35c08ce0 Author: jamesge AuthorDate: Mon Oct 7 23:12:54 2019 -0700 remove

[incubator-brpc] 02/03: remove exec bit from README files

2019-10-07 Thread jamesge
This is an automated email from the ASF dual-hosted git repository. jamesge pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git commit 8534fe84deac7dc012868b45b55c258a1ff6a5d8 Author: jamesge AuthorDate: Mon Oct 7 23:14:15 2019 -0700 remove

[incubator-brpc] branch master updated (3747d4c -> 40fd868)

2019-10-07 Thread jamesge
This is an automated email from the ASF dual-hosted git repository. jamesge pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git. from 3747d4c Merge pull request #883 from mesalock-linux/yj_mesalink_client_auth_fix new c155614 remove e

[incubator-brpc] 03/03: remove unused options.proto from some protos

2019-10-07 Thread jamesge
This is an automated email from the ASF dual-hosted git repository. jamesge pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git commit 40fd868f1d113385d65a3a2db6e86ad63ce4aac2 Author: jamesge AuthorDate: Mon Oct 7 23:14:47 2019 -0700 remove

[GitHub] [incubator-brpc] jamesge commented on issue #936: server端正常,但是客户端收到错误码

2019-10-07 Thread GitBox
jamesge commented on issue #936: server端正常,但是客户端收到错误码 URL: https://github.com/apache/incubator-brpc/issues/936#issuecomment-539357347 用的什么负载均衡方式? This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-brpc] MaggieCui commented on issue #936: server端正常,但是客户端收到错误码

2019-10-07 Thread GitBox
MaggieCui commented on issue #936: server端正常,但是客户端收到错误码 URL: https://github.com/apache/incubator-brpc/issues/936#issuecomment-539359483 没有负载均衡。我们是一个分布式存储系统,由元数据节点mds和各存储节点组成。各存储节点每隔10s向mds发送心跳。假期期间发现某些存储节点发送心跳偶尔出现失败的情况,且失败的errcode和text都相同。查看metric发现mds的实际实用的线程数量较小,cpu压力也很小,按道理来说不会出现超时的情况 -

[GitHub] [incubator-brpc] jamesge commented on issue #936: server端正常,但是客户端收到错误码

2019-10-07 Thread GitBox
jamesge commented on issue #936: server端正常,但是客户端收到错误码 URL: https://github.com/apache/incubator-brpc/issues/936#issuecomment-539370334 mds只是一台机器,client通过ip去访问它么?如果是这样的话,只能解释为,mds偶尔断线导致的健康检查,下面日志中应该有Checking开头,指向10.198.136.132:的内容 -