[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-11-27 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r351585370 ## File path: src/brpc/redis.h ## @@ -209,7 +212,51 @@ class RedisResponse : public ::google::protobuf::Message { std::ost

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-11-27 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r351585165 ## File path: src/brpc/redis_message.cpp ## @@ -19,29 +19,85 @@ #include #include "butil/logging.h" -#include "brpc/re

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-11-27 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r350649862 ## File path: test/brpc_redis_unittest.cpp ## @@ -547,4 +549,442 @@ TEST_F(RedisTest, quote_and_escape) { request.Clea

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-11-27 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r351584310 ## File path: src/brpc/policy/redis_protocol.cpp ## @@ -52,62 +56,287 @@ struct InputResponse : public InputMessageBase {

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-11-27 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r351583191 ## File path: src/brpc/redis.h ## @@ -209,7 +212,51 @@ class RedisResponse : public ::google::protobuf::Message { std::ost

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-11-27 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r351579486 ## File path: src/brpc/redis.h ## @@ -124,7 +127,7 @@ class RedisRequest : public ::google::protobuf::Message { void P

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-11-27 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r351584844 ## File path: src/brpc/policy/redis_protocol.cpp ## @@ -52,62 +56,287 @@ struct InputResponse : public InputMessageBase {

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-11-27 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r351584650 ## File path: src/brpc/policy/redis_protocol.cpp ## @@ -52,62 +56,287 @@ struct InputResponse : public InputMessageBase {

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #972: Redis server protocol

2019-11-27 Thread GitBox
jamesge commented on a change in pull request #972: Redis server protocol URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r351585705 ## File path: src/brpc/redis_command.h ## @@ -40,6 +40,41 @@ butil::Status RedisCommandByComponents(butil::IOBuf* buf,

[GitHub] [incubator-brpc] zptan commented on issue #975: pthread模式能否使用server-thread-local

2019-11-27 Thread GitBox
zptan commented on issue #975: pthread模式能否使用server-thread-local URL: https://github.com/apache/incubator-brpc/issues/975#issuecomment-559065695 @jamesge 谢谢gejun,刚才试过了,拿1000个request压了一下,没出问题 This is an automated message from th

[GitHub] [incubator-brpc] zptan closed issue #975: pthread模式能否使用server-thread-local

2019-11-27 Thread GitBox
zptan closed issue #975: pthread模式能否使用server-thread-local URL: https://github.com/apache/incubator-brpc/issues/975 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [incubator-brpc] jamesge commented on issue #965: bthread支持类似omp的并行计算的方法

2019-11-27 Thread GitBox
jamesge commented on issue #965: bthread支持类似omp的并行计算的方法 URL: https://github.com/apache/incubator-brpc/issues/965#issuecomment-559011579 这个视角不错,不过bthread的主要设计目的简化网络和IO中的多线程交互,而omp的主要使用场景是cpu-intensive的,如科学运算,这个场景中使用bthread也没什么优势。所以应该不会支持。