[incubator-brpc] branch master updated: fix_brpc_get_verion_name

2019-12-05 Thread jamesge
This is an automated email from the ASF dual-hosted git repository. jamesge pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new eecbee2 fix_brpc_get_verion_name

[GitHub] [incubator-brpc] jamesge merged pull request #987: fix_brpc_get_verion_name

2019-12-05 Thread GitBox
jamesge merged pull request #987: fix_brpc_get_verion_name URL: https://github.com/apache/incubator-brpc/pull/987 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [incubator-brpc] zyearn opened a new pull request #987: fix_brpc_get_verion_name

2019-12-05 Thread GitBox
zyearn opened a new pull request #987: fix_brpc_get_verion_name URL: https://github.com/apache/incubator-brpc/pull/987 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-brpc] zgb40302 commented on issue #985: crash

2019-12-05 Thread GitBox
zgb40302 commented on issue #985: crash URL: https://github.com/apache/incubator-brpc/issues/985#issuecomment-562428619 线上环境,去掉-O2会影响性能。30多台设备,不是每台都有,所以应用代码的概率应该不大。 This is an automated message from the Apache Git Service. To

[incubator-brpc] branch master updated (161fbb3 -> ba4a2f9)

2019-12-05 Thread jamesge
This is an automated email from the ASF dual-hosted git repository. jamesge pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git. from 161fbb3 Merge pull request #983 from zyearn/add_test_license new 6a2be8b fix_missing_brpc_version_in_

[GitHub] [incubator-brpc] jamesge merged pull request #984: fix_missing_brpc_version_in_release

2019-12-05 Thread GitBox
jamesge merged pull request #984: fix_missing_brpc_version_in_release URL: https://github.com/apache/incubator-brpc/pull/984 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-brpc] jamesge commented on issue #985: crash

2019-12-05 Thread GitBox
jamesge commented on issue #985: crash URL: https://github.com/apache/incubator-brpc/issues/985#issuecomment-562413561 可以试一下: 1. 去掉-O2重新编译brpc然后尝试复现问题,可能有更准确的栈;2. 运行asan看看是否有内存方面的问题,此类问题大概率和应用代码的内存问题相关。 This is an automated

[GitHub] [incubator-brpc] cool-colo opened a new issue #986: 0.96 release WRR负载均衡分配的QPS不均匀

2019-12-05 Thread GitBox
cool-colo opened a new issue #986: 0.96 release WRR负载均衡分配的QPS不均匀 URL: https://github.com/apache/incubator-brpc/issues/986 **Describe the bug (描述bug)** 0.96 release WRR负载均衡分配的QPS不均匀 老版本正常的,新版就经常出现下游QPS不均匀的问题。 新版平时波动也比老版本大, 偶尔出非常大的波动(上线,或qps高峰期经常出现) **To Reproduce (复现方法)**

[GitHub] [incubator-brpc] zgb40302 opened a new issue #985: crash

2019-12-05 Thread GitBox
zgb40302 opened a new issue #985: crash URL: https://github.com/apache/incubator-brpc/issues/985 **Describe the bug (描述bug)** #0 0x7f8c26c211f7 in raise () from /lib64/libc.so.6 #1 0x7f8c26c228e8 in abort () from /lib64/libc.so.6 #2 0x011dc455 in __gnu_cxx::__ver

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #984: fix_missing_brpc_version_in_release

2019-12-05 Thread GitBox
jamesge commented on a change in pull request #984: fix_missing_brpc_version_in_release URL: https://github.com/apache/incubator-brpc/pull/984#discussion_r354244557 ## File path: tools/get_brpc_version.sh ## @@ -0,0 +1,10 @@ +#!/bin/bash + +output=$(cat $1/RELEASE_VERSION)

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #984: fix_missing_brpc_version_in_release

2019-12-05 Thread GitBox
jamesge commented on a change in pull request #984: fix_missing_brpc_version_in_release URL: https://github.com/apache/incubator-brpc/pull/984#discussion_r354190288 ## File path: RELEASE_VERSION ## @@ -0,0 +1 @@ +30ff183a Review comment: 这个不是release version吧 ---

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #984: fix_missing_brpc_version_in_release

2019-12-05 Thread GitBox
jamesge commented on a change in pull request #984: fix_missing_brpc_version_in_release URL: https://github.com/apache/incubator-brpc/pull/984#discussion_r354244156 ## File path: Makefile ## @@ -23,7 +23,7 @@ include config.mk # 2. Added -D__const__= : Avoid over-optimiza

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #984: fix_missing_brpc_version_in_release

2019-12-05 Thread GitBox
jamesge commented on a change in pull request #984: fix_missing_brpc_version_in_release URL: https://github.com/apache/incubator-brpc/pull/984#discussion_r354243423 ## File path: CMakeLists.txt ## @@ -91,7 +91,7 @@ include_directories( ) execute_process( -COMMAND b

[GitHub] [incubator-brpc] jamesge commented on issue #976: brpc能否做到完全不依赖于protocol buffer

2019-12-05 Thread GitBox
jamesge commented on issue #976: brpc能否做到完全不依赖于protocol buffer URL: https://github.com/apache/incubator-brpc/issues/976#issuecomment-562054774 确实在一些场景中可能需要适配已有的协议,但从设计成熟度来说,pb是最好的(此处没有之一),且pb本身是个框架,是可以支持其他序列化格式的(比较繁琐,百度内有应用),所以brpc不太可能和pb脱钩。

[incubator-brpc] branch master updated (30ff183 -> 161fbb3)

2019-12-05 Thread jamesge
This is an automated email from the ASF dual-hosted git repository. jamesge pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git. from 30ff183 Merge pull request #981 from dyike/master new f7589c7 add_test_license new 8847db2 add_

[GitHub] [incubator-brpc] jamesge merged pull request #983: add test license

2019-12-05 Thread GitBox
jamesge merged pull request #983: add test license URL: https://github.com/apache/incubator-brpc/pull/983 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [incubator-brpc] zyearn opened a new pull request #984: fix_missing_brpc_version_in_release

2019-12-05 Thread GitBox
zyearn opened a new pull request #984: fix_missing_brpc_version_in_release URL: https://github.com/apache/incubator-brpc/pull/984 This is an automated message from the Apache Git Service. To respond to the message, please log