[GitHub] [incubator-brpc] joshuafc opened a new pull request #997: Http empty uri should check whether user registered restful_mappings, instead of directly use IndexServer.

2019-12-14 Thread GitBox
joshuafc opened a new pull request #997: Http empty uri should check whether user registered restful_mappings, instead of directly use IndexServer. URL: https://github.com/apache/incubator-brpc/pull/997 Http empty uri should check whether user registered restful_mappings, instead of direct

[GitHub] [incubator-brpc] joshuafc commented on issue #997: Http empty uri should check whether user registered restful_mappings, instead of directly use IndexServer.

2019-12-14 Thread GitBox
joshuafc commented on issue #997: Http empty uri should check whether user registered restful_mappings, instead of directly use IndexServer. URL: https://github.com/apache/incubator-brpc/pull/997#issuecomment-565713727 So we can `server.AddService(&srv, brpc::SERVER_DOESNT_OWN_SERVICE,

Re: vote to accept helei as committer

2019-12-14 Thread tan zhongyi
Hi, all, Vote is closed. We got 5 +1 from Zhujiashun, James Ge, zhangyi chen, rujie jiang, Zhongyi Tan. And No -1. So the vote result is Go. Congratulation to helei. Welcome to join brpc as committer. On 2019/12/13 08:19:42, tan zhongyi mailto:z...@gmail.com>> wrote: > +1> > > > > 在 2019/12/

Re: 申请成为brpc committer

2019-12-14 Thread tan zhongyi
Hi, all, Vote is closed. We got 5 +1 from Zhujiashun, James Ge, zhangyi chen, rujie jiang, Zhongyi Tan. And No -1. So the vote result is Go. Congratulation to gaidong. Welcome to join brpc as committer. On 2019/12/13 08:19:55, tan zhongyi mailto:z...@gmail.com>> wrote: > +1> > > > > > > 在 2